Skip to contentSkip to conversation

tmio: call tmiofb_set_par in tmiofb_probe

PATCH In review Dmitry Eremin-Solenikov 2 participants 3 messages Oct 17, 2013 – Oct 19, 2013 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tmio: call tmiofb_set_par in tmiofb_probe

Call tmiofb_set_par() to initlaize fixed variable before registering framebuffer. This is necessary for current kexecboot.

---
 drivers/video/tmiofb.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/video/tmiofb.c +5 -1
index deb8733..69fd0f7 100644
@@ -774,6 +774,10 @@ static int tmiofb_probe(struct platform_device *dev)
 	if (retval)
 		goto err_hw_init;
 
+	retval = tmiofb_set_par(info);
+	if (retval)
+		goto err_set_par;
+
 	fb_videomode_to_modelist(data->modes, data->num_modes,
 				 &info->modelist);
 
@@ -787,7 +791,7 @@ static int tmiofb_probe(struct platform_device *dev)
 	return 0;
 
 err_register_framebuffer:
-/*err_set_par:*/
+err_set_par:
 	tmiofb_hw_stop(dev);
 err_hw_init:
 	if (cell->disable)
Signature · 1 line
1.8.4.rc3
#1 lore raw
Quoted 13 lines · Dmitry Eremin-Solenikov

Call tmiofb_set_par() to initlaize fixed variable before registering framebuffer. This is necessary for current kexecboot.

---
 drivers/video/tmiofb.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/video/tmiofb.c +0 -0
index deb8733..69fd0f7 100644

drivers/video/tmiofb.c static int tmiofb_probe(struct platform_device *dev) · line 780

Quoted 7 lines
drivers/video/tmiofb.c +4 -0
@@ -774,6 +774,10 @@ static int tmiofb_probe(struct platform_device *dev)
 	if (retval)
 		goto err_hw_init;
 
+	retval = tmiofb_set_par(info);
+	if (retval)
+		goto err_set_par;
+

sorry no fix kexecboot

Best Regards,
J.

Quoted 19 lines
drivers/video/tmiofb.c +1 -1
 	fb_videomode_to_modelist(data->modes, data->num_modes,
 				 &info->modelist);
 
@@ -787,7 +791,7 @@ static int tmiofb_probe(struct platform_device *dev)
 	return 0;
 
 err_register_framebuffer:
-/*err_set_par:*/
+err_set_par:
 	tmiofb_hw_stop(dev);
 err_hw_init:
 	if (cell->disable)
Signature · 6 lines
1.8.4.rc3

--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#2 lore raw
In reply to Dmitry Eremin-Solenikov
Quoted 17 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 16 lines · Dmitry Eremin-Solenikov

Call tmiofb_set_par() to initlaize fixed variable before registering framebuffer. This is necessary for current kexecboot.

---
 drivers/video/tmiofb.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/video/tmiofb.c +0 -0
index deb8733..69fd0f7 100644
@@ -774,6 +774,10 @@ static int tmiofb_probe(struct platform_device *dev)
      if (retval)
              goto err_hw_init;
 
Quoted 6 lines

drivers/video/tmiofb.c static int tmiofb_probe(struct platform_device *dev) · line 780

Quoted 4 lines
drivers/video/tmiofb.c +4 -0
+     retval = tmiofb_set_par(info);
+     if (retval)
+             goto err_set_par;
+

sorry no fix kexecboot

So calling set_par in _probe() is deprecated/fromn upon? Why?

Signature · 2 lines
With best wishes
Dmitry