Skip to contentSkip to conversation

xfstests: use minimum log size in xfs/016

PATCH In review Brian Foster 3 participants 3 messages Oct 18, 2013 – Oct 22, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfstests: use minimum log size in xfs/016

Test xfs/016 fails to run due to invalid mkfs options. The log size is reported as too small according to the minimum log size calculation:

log size 512 blocks too small, minimum size is 853 blocks

Update log_size to the currently specified minimum.

---
 tests/xfs/016 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/xfs/016 +1 -1
index 2fc6af2..e52f80c 100755
@@ -181,7 +181,7 @@ _supported_os Linux
 rm -f $seqres.full
 
 # mkfs sizes
-log_size=2097152
+log_size=3493888
 log_size_bb=`expr $log_size / 512`
 
 _require_scratch
Signature · 6 lines
1.8.1.4

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Reviewed-by on v1 1/1
#1 lore raw
Quoted 18 lines · Brian Foster

Test xfs/016 fails to run due to invalid mkfs options. The log size is reported as too small according to the minimum log size calculation:

log size 512 blocks too small, minimum size is 853 blocks

Update log_size to the currently specified minimum.

---
 tests/xfs/016 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/xfs/016 +0 -0
index 2fc6af2..e52f80c 100755

tests/xfs/016 _supported_os Linux · line 185

Quoted 6 lines
tests/xfs/016 +1 -1
@@ -181,7 +181,7 @@ _supported_os Linux
 rm -f $seqres.full
 
 # mkfs sizes
-log_size=2097152
+log_size=3493888
 log_size_bb=`expr $log_size / 512`

That shoul dbe fine. I've been ignoring xfs/016 because the configurations I test throw this:

xfs/016 21s ... [not run] Cannot mkfs for this test using MKFS_OPTIONS specified

And so I haven't noticed if it was failing or not.

Cheers,

Dave.

Signature · 7 lines
Dave Chinner
[email protected]

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs