Skip to contentSkip to conversation

ASoC: tegra: Remove redundant initialisation of compat_filter_fn

PATCH In review Mark Brown 4 participants 5 messages Oct 19, 2013 – Oct 22, 2013 3 messages not in the archive

Subsystems (3)
lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 ASoC: tegra: Remove redundant initialisation of compat_filter_fn

From: Mark Brown <[email protected]>

Setting a field in a static struct to NULL has no effect so don't bother (and don't generate false positives for grep).

---
 sound/soc/tegra/tegra_pcm.c | 1 -
 1 file changed, 1 deletion(-)
sound/soc/tegra/tegra_pcm.c +0 -1
index f056f63..7b2d23b 100644
@@ -56,7 +56,6 @@ static const struct snd_pcm_hardware tegra_pcm_hardware = {
 static const struct snd_dmaengine_pcm_config tegra_dmaengine_pcm_config = {
 	.pcm_hardware = &tegra_pcm_hardware,
 	.prepare_slave_config = snd_dmaengine_pcm_prepare_slave_config,
-	.compat_filter_fn = NULL,
 	.prealloc_buffer_size = PAGE_SIZE * 8,
 };
 
Signature · 1 line
1.8.4.rc3
#1 lore raw
Quoted 4 lines · Mark Brown

From: Mark Brown <[email protected]>

Setting a field in a static struct to NULL has no effect so don't bother (and don't generate false positives for grep).

The idea was to make it explicit that tegra uses the compat path, but with the filter function set to NULL.

- Lars

A message that is not in the archive (sent off-list or not yet received): 1382188623-19494-1-git-send-email-broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org

#3 lore raw
Quoted 4 lines · Mark Brown

From: Mark Brown <[email protected]>

Setting a field in a static struct to NULL has no effect so don't bother (and don't generate false positives for grep).

I'm fine with this either way, so feel free to take my ack whichever way you work this out with Lars-Peter.

A message that is not in the archive (sent off-list or not yet received): [email protected]

#5 lore raw
Quoted 8 lines · Stephen Warren
Quoted 4 lines · Mark Brown

From: Mark Brown <[email protected]>

Setting a field in a static struct to NULL has no effect so don't bother (and don't generate false positives for grep).

I'm fine with this either way, so feel free to take my ack whichever way you work this out with Lars-Peter.

I don't care that much either, just wanted to give an explanation why things are the way they are. Mark, if you want to merge this patch you can add:

Btw. wasn't there a plan to move tegra to the generic dma bindings? If not I think it might be a good idea to add the possibility to let the DMA driver overwrite the DT attribute parsing done by of_dma_match_channel(). This would spare drivers from having to do the parsing manually and it would allow the tegra pcm driver to just follow the normal OF path in the generic-dmaengine-pcm driver and didn't had to rely on the compat path.

- Lars

A message that is not in the archive (sent off-list or not yet received): 52666422.9010505-Qo5EllUWu/[email protected]

#7 lore raw
Quoted 7 lines · Lars-Peter Clausen
Quoted 6 lines · Stephen Warren
Quoted 4 lines · Mark Brown

From: Mark Brown <[email protected]>

Setting a field in a static struct to NULL has no effect so don't bother (and don't generate false positives for grep).

Quoted 8 lines
Quoted 2 lines

I'm fine with this either way, so feel free to take my ack whichever way you work this out with Lars-Peter.

I don't care that much either, just wanted to give an explanation why things are the way they are. Mark, if you want to merge this patch you can add:

Btw. wasn't there a plan to move tegra to the generic dma bindings?

IIRC, it's been using them for a release or two.