Skip to contentSkip to conversation

HID: i2c-hid: Stop querying for init reports

PATCH In review Bibek Basu 2 participants 2 messages Oct 21, 2013 – Oct 30, 2013 HID

lore
Share & tools
lore

Bibek Basu

author
#0 lore raw

PATCH 1/1 HID: i2c-hid: Stop querying for init reports

According to specifications, HID over I2C devices are not bound to respond to query for INPUT REPORTS. Thus dropping the call during init as many devices does not respond causing error messages during boot.

---
 drivers/hid/i2c-hid/i2c-hid.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/hid/i2c-hid/i2c-hid.c +0 -4
index fd7ce37..ae48d18 100644
@@ -455,10 +455,6 @@ static void i2c_hid_init_reports(struct hid_device *hid)
 	}
 
 	list_for_each_entry(report,
-		&hid->report_enum[HID_INPUT_REPORT].report_list, list)
-		i2c_hid_init_report(report, inbuf, ihid->bufsize);
-
-	list_for_each_entry(report,
 		&hid->report_enum[HID_FEATURE_REPORT].report_list, list)
 		i2c_hid_init_report(report, inbuf, ihid->bufsize);
 
Signature · 1 line
1.8.1.5
#1 lore raw
Quoted 7 lines · Bibek Basu

According to specifications, HID over I2C devices are not bound to respond to query for INPUT REPORTS. Thus dropping the call during init as many devices does not respond causing error messages during boot.

I am queuing this for 3.13. Thanks,

Signature · 2 lines
Jiri Kosina
SUSE Labs