Skip to contentSkip to conversation

qemu-img: add special exit code if bdrv_check is not supported

PATCH Superseded Peter Lieven 2 participants 3 messages Oct 22, 2013

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 qemu-img: add special exit code if bdrv_check is not supported

currently it is not possible to distinguish by exitcode if there has been an error or if bdrv_check is not supported by the image format. Change the exitcode from 1 to 255 for the latter case.

---
 qemu-img.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
qemu-img.c +1 -1
index 9fb3016..163aa3f 100644
@@ -609,7 +609,7 @@ static int img_check(int argc, char **argv)
         if (output_format == OFORMAT_HUMAN) {
             error_report("This image format does not support checks");
         }
-        ret = 1;
+        ret = 255;
         goto fail;
     }
 
Signature · 1 line
1.7.9.5
Reviewed-by on v1 1/1
#1 lore raw
Quoted 3 lines · Peter Lieven

currently it is not possible to distinguish by exitcode if there has been an error or if bdrv_check is not supported by the image format. Change the exitcode from 1 to 255 for the latter case.

Why 255? Sure, 'xargs' handles $?=255 differently than most other status, but in general, $? > 128 starts to be ambiguous with death by signal (on the other hand, most systems stop at 64 signals rather than 128). Most applications that use differentiated exit status just use 1 and 2, rather than 1 and 255.

Quoted 5 lines
---
 qemu-img.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

But I don't care strongly enough to reject this, so if no one else complains about the choice:

Quoted 15 lines
qemu-img.c +1 -1
index 9fb3016..163aa3f 100644
@@ -609,7 +609,7 @@ static int img_check(int argc, char **argv)
         if (output_format == OFORMAT_HUMAN) {
             error_report("This image format does not support checks");
         }
-        ret = 1;
+        ret = 255;
         goto fail;
     }
 
Signature · 2 lines
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org
#2 lore raw
Quoted 9 lines · Eric Blake
Quoted 3 lines · Peter Lieven

currently it is not possible to distinguish by exitcode if there has been an error or if bdrv_check is not supported by the image format. Change the exitcode from 1 to 255 for the latter case.

Why 255? Sure, 'xargs' handles $?=255 differently than most other status, but in general, $? > 128 starts to be ambiguous with death by signal (on the other hand, most systems stop at 64 signals rather than 128). Most applications that use differentiated exit status just use 1 and 2, rather than 1 and 255.

I would also be fine with 63. Someone started to make some choices for check->leaks, check->corruptions using 2,3, ... I wanted to avoid conflicts if someone adds a 4,5,6 ...

Peter