Skip to contentSkip to conversation

udev: Update touchscreen rule for ID_INPUT_TOUCHSCREEN

PATCH In review Tom Rini 4 participants 5 messages Oct 22, 2013 – Apr 24, 2014

lore
Share & tools
lore

Tom Rini

author
#0 lore raw

PATCH 1/1 udev: Update touchscreen rule for ID_INPUT_TOUCHSCREEN

Since udev 174 udev has been running input_id as a built-in command and setting this value in the environment for touchscreens. Use this logic to detect when to make a touchscreen0 symlink.

---
 meta/recipes-core/udev/udev/local.rules |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/udev/udev/local.rules +1 -1
index 72d92ef..d0b0216 100644
@@ -17,5 +17,5 @@
 ACTION=="add", DEVPATH=="/devices/*", ENV{MODALIAS}=="?*", RUN+="/sbin/modprobe $env{MODALIAS}"
 
 # Create a symlink to any touchscreen input device
-SUBSYSTEM=="input", KERNEL=="event[0-9]*", ATTRS{modalias}=="input:*-e0*,3,*a0,1,*18,*", SYMLINK+="input/touchscreen0"
+SUBSYSTEM=="input", KERNEL=="event[0-9]*", ENV{ID_INPUT_TOUCHSCREEN}=="1", SYMLINK+="input/touchscreen0"
 
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 14 lines · Tom Rini

Since udev 174 udev has been running input_id as a built-in command and setting this value in the environment for touchscreens. Use this logic to detect when to make a touchscreen0 symlink.

---
 meta/recipes-core/udev/udev/local.rules |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/udev/udev/local.rules +0 -0
index 72d92ef..d0b0216 100644

meta/recipes-core/udev/udev/local.rules line 20

Quoted 5 lines
meta/recipes-core/udev/udev/local.rules +1 -1
@@ -17,5 +17,5 @@
 ACTION=="add", DEVPATH=="/devices/*", ENV{MODALIAS}=="?*", RUN+="/sbin/modprobe $env{MODALIAS}"
 
 # Create a symlink to any touchscreen input device
-SUBSYSTEM=="input", KERNEL=="event[0-9]*", ATTRS{modalias}=="input:*-e0*,3,*a0,1,*18,*", SYMLINK+="input/touchscreen0"
+SUBSYSTEM=="input", KERNEL=="event[0-9]*", ENV{ID_INPUT_TOUCHSCREEN}=="1", SYMLINK+="input/touchscreen0"

Ping

Signature · 1 line
Tom
#2 lore raw
Quoted 18 lines · Tom Rini
Quoted 16 lines · Tom Rini

Since udev 174 udev has been running input_id as a built-in command and setting this value in the environment for touchscreens. Use this logic to detect when to make a touchscreen0 symlink.

---
 meta/recipes-core/udev/udev/local.rules |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/udev/udev/local.rules +0 -0
index 72d92ef..d0b0216 100644
@@ -17,5 +17,5 @@
 ACTION=="add", DEVPATH=="/devices/*", ENV{MODALIAS}=="?*", RUN+="/sbin/modprobe $env{MODALIAS}"
 
Quoted 5 lines

meta/recipes-core/udev/udev/local.rules line 20

Quoted 3 lines
meta/recipes-core/udev/udev/local.rules +1 -1
 # Create a symlink to any touchscreen input device
-SUBSYSTEM=="input", KERNEL=="event[0-9]*", ATTRS{modalias}=="input:*-e0*,3,*a0,1,*18,*", SYMLINK+="input/touchscreen0"
+SUBSYSTEM=="input", KERNEL=="event[0-9]*", ENV{ID_INPUT_TOUCHSCREEN}=="1", SYMLINK+="input/touchscreen0"

Ping

Was it ever reviewed? Ping^2

Signature · 1 line
Denys
#3 lore raw
Quoted 23 lines · On Wednesday 23 April 2014 19:41:56 Denys Dmytriyenko wrote:
Quoted 22 lines · Tom Rini
Quoted 21 lines · Tom Rini

Since udev 174 udev has been running input_id as a built-in command and setting this value in the environment for touchscreens. Use this logic to detect when to make a touchscreen0 symlink.

---

 meta/recipes-core/udev/udev/local.rules |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/meta/recipes-core/udev/udev/local.rules index 72d92ef..d0b0216 100644

meta/recipes-core/udev/udev/local.rules +0 -0
@@ -17,5 +17,5 @@
 
 ACTION=="add", DEVPATH=="/devices/*", ENV{MODALIAS}=="?*",
 RUN+="/sbin/modprobe $env{MODALIAS}"
 
 # Create a symlink to any touchscreen input device
Quoted 8 lines
Quoted 6 lines
Quoted 5 lines

-SUBSYSTEM=="input", KERNEL=="event[0-9]*", ATTRS{modalias}=="input:*-e0*,3,*a0,1,*18,*", SYMLINK+="input/touchscreen0" +SUBSYSTEM=="input", KERNEL=="event[0-9]*", ENV{ID_INPUT_TOUCHSCREEN}=="1", SYMLINK+="input/touchscreen0">

Ping

Was it ever reviewed? Ping^2

Sorry, what do you mean? It was reviewed and merged:

http://cgit.openembedded.org/openembedded-core/commit/?id=5abcfcd4380aacafc45d776f557738fb18089113

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
#4 lore raw
Quoted 31 lines · Paul Eggleton
Quoted 30 lines · On Wednesday 23 April 2014 19:41:56 Denys Dmytriyenko wrote:
Quoted 28 lines · Tom Rini
Quoted 22 lines · Tom Rini

Since udev 174 udev has been running input_id as a built-in command and setting this value in the environment for touchscreens. Use this logic to detect when to make a touchscreen0 symlink.

---

 meta/recipes-core/udev/udev/local.rules |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/meta/recipes-core/udev/udev/local.rules index 72d92ef..d0b0216 100644

meta/recipes-core/udev/udev/local.rules +0 -1
@@ -17,5 +17,5 @@
 
 ACTION=="add", DEVPATH=="/devices/*", ENV{MODALIAS}=="?*",
 RUN+="/sbin/modprobe $env{MODALIAS}"
 
 # Create a symlink to any touchscreen input device
 
-SUBSYSTEM=="input", KERNEL=="event[0-9]*",
Quoted 4 lines

ATTRS{modalias}=="input:*-e0*,3,*a0,1,*18,*", SYMLINK+="input/touchscreen0" +SUBSYSTEM=="input", KERNEL=="event[0-9]*", ENV{ID_INPUT_TOUCHSCREEN}=="1", SYMLINK+="input/touchscreen0">

Ping

Quoted 5 lines
Quoted 1 line

Was it ever reviewed? Ping^2

Sorry, what do you mean? It was reviewed and merged:

http://cgit.openembedded.org/openembedded-core/commit/?id=5abcfcd4380aacafc45d776f557738fb18089113

Oops, I guess I looked in Dora and it was merged after the release. Sorry for the noise.

Signature · 1 line
Denys