Skip to contentSkip to conversation

ARM: bcm2835: add missing mbox overscan response field

PATCH New Andre Heider 4 participants 8 messages Oct 22, 2013 – Nov 9, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 ARM: bcm2835: add missing mbox overscan response field

Add the missing "right" field to struct bcm2835_mbox_tag_overscan.

---
 arch/arm/include/asm/arch-bcm2835/mbox.h | 1 +
 1 file changed, 1 insertion(+)
arch/arm/include/asm/arch-bcm2835/mbox.h +1 -0
index 24abe57..6b806ec 100644
@@ -350,6 +350,7 @@ struct bcm2835_mbox_tag_overscan {
 			u32 top;
 			u32 bottom;
 			u32 left;
+			u32 right;
 		} resp;
 	} body;
 };
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/2 ARM: bcm2835: add missing mbox overscan response field

Quoted 1 line · Andre Heider

Add the missing "right" field to struct bcm2835_mbox_tag_overscan.

This one patch,

You need to send/cc this patch to Albert Aribauld, since he applies ARM patches. Or, perhaps just make sure the patch gets assigned to him in patchwork?

#2 lore raw

PATCH 1/2 ARM: bcm2835: add missing mbox overscan response field

Quoted 9 lines · Stephen Warren
Quoted 1 line · Andre Heider

Add the missing "right" field to struct bcm2835_mbox_tag_overscan.

This one patch,

You need to send/cc this patch to Albert Aribauld, since he applies ARM patches. Or, perhaps just make sure the patch gets assigned to him in patchwork?

Okay, I did the patchwork dance :)

Thanks,
Andre

#3 lore raw

PATCH 1/2 ARM: bcm2835: add missing mbox overscan response field

Hi Andre,

Quoted 7 lines · Andre Heider
Quoted 6 lines · Stephen Warren
Quoted 1 line · Andre Heider

Add the missing "right" field to struct bcm2835_mbox_tag_overscan.

This one patch,

Quoted 8 lines
Quoted 3 lines

You need to send/cc this patch to Albert Aribauld, since he applies ARM patches. Or, perhaps just make sure the patch gets assigned to him in patchwork?

Okay, I did the patchwork dance :)

Thanks,
Andre

In fact, the series could be applied as a whole by the same custodian -- and actually, I'd prefer it to be applied as a whole, since patch 1/2 alone looks like dead/useless code, whereas it makes sense if applied along with 2/2.

Amicalement,

Signature · 1 line
Albert.
#4 lore raw

PATCH 1/2 ARM: bcm2835: add missing mbox overscan response field

Quoted 18 lines · Albert ARIBAUD

Hi Andre,

Quoted 13 lines · Andre Heider
Quoted 9 lines · Stephen Warren
Quoted 1 line · Andre Heider

Add the missing "right" field to struct bcm2835_mbox_tag_overscan.

This one patch,

You need to send/cc this patch to Albert Aribauld, since he applies ARM patches. Or, perhaps just make sure the patch gets assigned to him in patchwork?

Okay, I did the patchwork dance :)

Quoted 7 lines
Quoted 2 lines

Thanks,
Andre

In fact, the series could be applied as a whole by the same custodian -- and actually, I'd prefer it to be applied as a whole, since patch 1/2 alone looks like dead/useless code, whereas it makes sense if applied along with 2/2.

So, there are 2 patches and 2 custodians. One of you has to ack the patch for the other to merge them both through the other's subsystem, right? I guess you want Anatolij to take both of these through the video tree based on your comments. If so, can you ack this patch and re-assign them both in patchwork, so he knows that?

#5 lore raw

PATCH 1/2 ARM: bcm2835: add missing mbox overscan response field

Hi Stephen,

Quoted 5 lines · Stephen Warren

So, there are 2 patches and 2 custodians. One of you has to ack the patch for the other to merge them both through the other's subsystem, right? I guess you want Anatolij to take both of these through the video tree based on your comments. If so, can you ack this patch and re-assign them both in patchwork, so he knows that?

Done (although I suspect that in this instance, my Ack was not really needed, as the change was quite trivial and did not require any ARM- specific knowledge).

Amicalement,

Signature · 1 line
Albert.
#6 lore raw

PATCH 1/2 ARM: bcm2835: add missing mbox overscan response field

In reply to Andre Heider

Hi Andre,

Quoted 12 lines · Andre Heider

Add the missing "right" field to struct bcm2835_mbox_tag_overscan.

---
 arch/arm/include/asm/arch-bcm2835/mbox.h | 1 +
 1 file changed, 1 insertion(+)
arch/arm/include/asm/arch-bcm2835/mbox.h +0 -0
index 24abe57..6b806ec 100644

arch/arm/include/asm/arch-bcm2835/mbox.h struct bcm2835_mbox_tag_overscan { · line 356

Quoted 7 lines
arch/arm/include/asm/arch-bcm2835/mbox.h +1 -0
@@ -350,6 +350,7 @@ struct bcm2835_mbox_tag_overscan {
 			u32 top;
 			u32 bottom;
 			u32 left;
+			u32 right;
 		} resp;
 	} body;
 };

Amicalement,

Signature · 1 line
Albert.