Skip to contentSkip to conversation

stress: disable documentation

PATCH New Arnout Vandecappelle (Essensium/Mind) 3 participants 5 messages Oct 23, 2013 – Oct 24, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 stress: disable documentation

It fails to build with my makeinfo version. Note that the autobuilders don't see this, probably because they don't have makeinfo installed.

---
 package/stress/stress.mk | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
package/stress/stress.mk +4 -1
index 63efb66..b058031 100644
@@ -17,7 +17,10 @@ STRESS_AUTORECONF = YES
 #
 # If the BR2_PREFER_STATIC_LIB is not defined, we have to specify
 # --disable-static explicitly to get stress linked dynamically.
+#
+# Also, disable documentation by undefining makeinfo
 STRESS_CONF_OPT = \
-	$(if $(BR2_PREFER_STATIC_LIB),,--disable-static)
+	$(if $(BR2_PREFER_STATIC_LIB),,--disable-static) \
+	MAKEINFO=:
 
 $(eval $(autotools-package))
Signature · 1 line
1.8.4.rc3
#1 lore raw

PATCH 1/1 stress: disable documentation

Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle (Essensium/Mind) <[email protected]> writes:

It fails to build with my makeinfo version. Note that the autobuilders don't see this, probably because they don't have makeinfo installed.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 stress: disable documentation

In reply to Arnout Vandecappelle (Essensium/Mind)
Quoted 13 lines · Arnout Vandecappelle (Essensium/Mind)

It fails to build with my makeinfo version. Note that the autobuilders don't see this, probably because they don't have makeinfo installed.

---
 package/stress/stress.mk | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
package/stress/stress.mk +0 -0
index 63efb66..b058031 100644

package/stress/stress.mk STRESS_AUTORECONF = YES · line 24

Quoted 9 lines
package/stress/stress.mk +4 -1
@@ -17,7 +17,10 @@ STRESS_AUTORECONF = YES
 #
 # If the BR2_PREFER_STATIC_LIB is not defined, we have to specify
 # --disable-static explicitly to get stress linked dynamically.
+#
+# Also, disable documentation by undefining makeinfo
 STRESS_CONF_OPT = \
-       $(if $(BR2_PREFER_STATIC_LIB),,--disable-static)
+       $(if $(BR2_PREFER_STATIC_LIB),,--disable-static) \
+       MAKEINFO=:

What is the significance of this colon?

Thanks,
Thomas

#3 lore raw

PATCH 1/1 stress: disable documentation

Quoted 10 lines · Thomas De Schampheleire
Quoted 8 lines · Arnout Vandecappelle (Essensium/Mind)

It fails to build with my makeinfo version. Note that the autobuilders don't see this, probably because they don't have makeinfo installed.

---
  package/stress/stress.mk | 5 ++++-
  1 file changed, 4 insertions(+), 1 deletion(-)
Quoted 16 lines
Quoted 5 lines
package/stress/stress.mk +0 -0
index 63efb66..b058031 100644

package/stress/stress.mk STRESS_AUTORECONF = YES · line 24

Quoted 9 lines
package/stress/stress.mk +4 -1
@@ -17,7 +17,10 @@ STRESS_AUTORECONF = YES
  #
  # If the BR2_PREFER_STATIC_LIB is not defined, we have to specify
  # --disable-static explicitly to get stress linked dynamically.
+#
+# Also, disable documentation by undefining makeinfo
  STRESS_CONF_OPT = \
-       $(if $(BR2_PREFER_STATIC_LIB),,--disable-static)
+       $(if $(BR2_PREFER_STATIC_LIB),,--disable-static) \
+       MAKEINFO=:

What is the significance of this colon?

It's just an empty command. I could have used 'true' as well. In
practice, they're the same. However, POSIX defines 'true' to take no arguments, while ':' ignores its arguments, so ':' is more pedantically correct.

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#4 lore raw

PATCH 1/1 stress: disable documentation

Quoted 8 lines · Arnout Vandecappelle
Quoted 7 lines · Thomas De Schampheleire
Quoted 5 lines
package/stress/stress.mk +3 -1
+# Also, disable documentation by undefining makeinfo
  STRESS_CONF_OPT = \
-       $(if $(BR2_PREFER_STATIC_LIB),,--disable-static)
+       $(if $(BR2_PREFER_STATIC_LIB),,--disable-static) \
+       MAKEINFO=:
Quoted 6 lines
Quoted 1 line

What is the significance of this colon?

It's just an empty command. I could have used 'true' as well. In practice,
they're the same. However, POSIX defines 'true' to take no arguments, while ':' ignores its arguments, so ':' is more pedantically correct.

This is new to me, thanks!

Best regards,
Thomas