net:sched fix a bug about memery leak
Subsystems (3)
PATCH 1/1 net:sched fix a bug about memery leak
From: Jing Wang <[email protected]>
the code isn't properly release memory
Signed-off-by Jing Wang <[email protected]>
--- net/sched/cls_route.c | 9 ++++++--- 1 files changed, 6 insertions(+), 3 deletions(-)
net/sched/cls_route.c +6 -3
@@ -466,11 +466,11 @@ static int route4_change(struct net *net, struct sk_buff *in_skb, goto reinsert; } - err = -ENOBUFS ; + err = -ENOMEM ;if (head ==NULL ) { head =kzalloc (sizeof (struct route4_head ),GFP_KERNEL );if (head ==NULL ) - goto errout; + goto errhead;tcf_tree_lock (tp); tp->root = head;
@@ -479,7 +479,7 @@ static int route4_change(struct net *net, struct sk_buff *in_skb, f =kzalloc (sizeof (struct route4_filter ),GFP_KERNEL );if (f ==NULL ) - goto errout; + goto errflt; err =route4_set_parms (net, tp, base, f, handle, head, tb, tca[TCA_RATE ],1 );
@@ -517,6 +517,9 @@ reinsert: errout:kfree (f); +errflt: +kfree (head); +errhead:return err; }
Signature · 1 line
1.7.1
Hello.
Quoted 13 lines · Jing Wang
From: Jing Wang <[email protected]>
the code isn't properly release memory
Signed-off-by Jing Wang <[email protected]>--- net/sched/cls_route.c | 9 ++++++--- 1 files changed, 6 insertions(+), 3 deletions(-)net/sched/cls_route.c +0
-0
[...]
net/sched/cls_route.c reinsert: · line 521
Quoted 6 lines
net/sched/cls_route.c +2
-0@@ -517,6 +517,9 @@ reinsert: errout:kfree (f); +errflt: +kfree (head);
Please indent with tab, not spaces.
WBR, Sergei