Skip to contentSkip to conversation

natsemi: fix legacy printk() style

PATCH In review Drew McGowen 2 participants 2 messages Oct 24, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 natsemi: fix legacy printk() style

Fixed printk() calls to use KERN_* prefix (some were not changed because they are continuations of a previous line).

---
 drivers/net/ethernet/natsemi/natsemi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/natsemi/natsemi.c +2 -2
index 7a5e295..cd39d8e 100644
@@ -814,7 +814,7 @@ static int natsemi_probe1(struct pci_dev *pdev, const struct pci_device_id *ent)
 #ifndef MODULE
 	static int printed_version;
 	if (!printed_version++)
-		printk(version);
+		printk(KERN_INFO version);
 #endif
 
 	i = pci_enable_device(pdev);
@@ -3360,7 +3360,7 @@ static int __init natsemi_init_mod (void)
 {
 /* when a module, this is printed whether or not devices are found in probe */
 #ifdef MODULE
-	printk(version);
+	printk(KERN_INFO version);
 #endif
 
 	return pci_register_driver(&natsemi_driver);
Signature · 1 line
1.8.1.2
#1 lore raw
Quoted 2 lines · Drew McGowen

Fixed printk() calls to use KERN_* prefix (some were not changed because they are continuations of a previous line).

[]

drivers/net/ethernet/natsemi/natsemi.c

Quoted 1 line
drivers/net/ethernet/natsemi/natsemi.c +0 -0

[]

drivers/net/ethernet/natsemi/natsemi.c static int natsemi_probe1(struct pci_dev *pdev, const struct pci_device_id *ent) · line 817

Quoted 6 lines
drivers/net/ethernet/natsemi/natsemi.c +1 -1
@@ -814,7 +814,7 @@ static int natsemi_probe1(struct pci_dev *pdev, const struct pci_device_id *ent)
 #ifndef MODULE
 	static int printed_version;
 	if (!printed_version++)
-		printk(version);
+		printk(KERN_INFO version);

pr_info_once("%s\n", version);

And remove the trailing newline from version

drivers/net/ethernet/natsemi/natsemi.c static int __init natsemi_init_mod (void) · line 3363

Quoted 6 lines
drivers/net/ethernet/natsemi/natsemi.c +1 -1
@@ -3360,7 +3360,7 @@ static int __init natsemi_init_mod (void)
 {
 /* when a module, this is printed whether or not devices are found in probe */
 #ifdef MODULE
-	printk(version);
+	printk(KERN_INFO version);
	pr_info("%s\n", version);

Nicer to use netdev_<level> too.