Skip to contentSkip to conversation

ns83820: printk() cleanup

PATCH In review Luke C. Jones 2 participants 2 messages Oct 24, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ns83820: printk() cleanup

From: "Luke C. Jones" <[email protected]>

In an effort to bring all printk calls up to style standards, added log levels to printk calls.

---
 drivers/net/ethernet/natsemi/ns83820.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/ethernet/natsemi/ns83820.c +3 -3
index d3b4700..d7f849d 100644
@@ -1580,7 +1580,7 @@ static void ns83820_tx_timeout(struct net_device *ndev)
 	{
 		u32 isr;
 		isr = readl(dev->base + ISR);
-		printk("irq: %08x imr: %08x\n", isr, dev->IMR_cache);
+		printk(KERN_DEBUG "irq: %08x imr: %08x\n", isr, dev->IMR_cache);
 		ns83820_do_isr(ndev, isr);
 	}
 #endif
@@ -1603,7 +1603,7 @@ static void ns83820_tx_watch(unsigned long data)
 	struct ns83820 *dev = PRIV(ndev);
 
 #if defined(DEBUG)
-	printk("ns83820_tx_watch: %u %u %d\n",
+	printk(KERN_DEBUG "ns83820_tx_watch: %u %u %d\n",
 		dev->tx_done_idx, dev->tx_free_idx, atomic_read(&dev->nr_tx_skbs)
 		);
 #endif
@@ -2026,7 +2026,7 @@ static int ns83820_init_one(struct pci_dev *pci_dev,
 		goto out_free_irq;
 	}
 
-	printk("%s: ns83820.c: 0x22c: %08x, subsystem: %04x:%04x\n",
+	printk(KERN_INFO "%s: ns83820.c: 0x22c: %08x, subsystem: %04x:%04x\n",
 		ndev->name, le32_to_cpu(readl(dev->base + 0x22c)),
 		pci_dev->subsystem_vendor, pci_dev->subsystem_device);
 
Signature · 1 line
1.8.1.2
#1 lore raw
Quoted 2 lines · Luke C. Jones

In an effort to bring all printk calls up to style standards, added log levels to printk calls.

[]

drivers/net/ethernet/natsemi/ns83820.c

Quoted 1 line
drivers/net/ethernet/natsemi/ns83820.c +0 -0

[]

drivers/net/ethernet/natsemi/ns83820.c static void ns83820_tx_timeout(struct net_device *ndev) · line 1583

Quoted 6 lines
drivers/net/ethernet/natsemi/ns83820.c +1 -1
@@ -1580,7 +1580,7 @@ static void ns83820_tx_timeout(struct net_device *ndev)
 	{
 		u32 isr;
 		isr = readl(dev->base + ISR);
-		printk("irq: %08x imr: %08x\n", isr, dev->IMR_cache);
+		printk(KERN_DEBUG "irq: %08x imr: %08x\n", isr, dev->IMR_cache);

netdev_dbg(ndev, etc...)

drivers/net/ethernet/natsemi/ns83820.c static void ns83820_tx_watch(unsigned long data) · line 1608

Quoted 8 lines
drivers/net/ethernet/natsemi/ns83820.c +1 -1
@@ -1603,7 +1603,7 @@ static void ns83820_tx_watch(unsigned long data)
 	struct ns83820 *dev = PRIV(ndev);
 
 #if defined(DEBUG)
-	printk("ns83820_tx_watch: %u %u %d\n",
+	printk(KERN_DEBUG "ns83820_tx_watch: %u %u %d\n",
 		dev->tx_done_idx, dev->tx_free_idx, atomic_read(&dev->nr_tx_skbs)
 		);

netdev_dbg()

drivers/net/ethernet/natsemi/ns83820.c static int ns83820_init_one(struct pci_dev *pci_dev, · line 2032

Quoted 10 lines
drivers/net/ethernet/natsemi/ns83820.c +1 -1
 #endif
@@ -2026,7 +2026,7 @@ static int ns83820_init_one(struct pci_dev *pci_dev,
 		goto out_free_irq;
 	}
 
-	printk("%s: ns83820.c: 0x22c: %08x, subsystem: %04x:%04x\n",
+	printk(KERN_INFO "%s: ns83820.c: 0x22c: %08x, subsystem: %04x:%04x\n",
 		ndev->name, le32_to_cpu(readl(dev->base + 0x22c)),
 		pci_dev->subsystem_vendor, pci_dev->subsystem_device);
 

netdev_info()