Skip to contentSkip to conversation

update-rc.d.bbclass: Fix host/target test in postinst

PATCH New Jacob Kroon 1 participant 1 message Oct 27, 2013

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 update-rc.d.bbclass: Fix host/target test in postinst

When running the postinst script I get a shell warning:

sh: argument expected

and the service is never stopped. This patch fixes the warning message and stops the service.

Patch v2: Hans Beckérus pointed out that the patch is not correct.
This version uses the syntax proposed by Hans. I've tested that the postinst script works correctly when run on the target, both when the init script exists and when it doesn't exist.

---
 meta/classes/update-rc.d.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/update-rc.d.bbclass +1 -1
index e14659d..9437e9c 100644
@@ -16,7 +16,7 @@ updatercd_postinst() {
 # test if there is a previous init script there, ie, we are updating the package
 # if so, we stop the service and remove it before we install from the new package
 if type update-rc.d >/dev/null 2>/dev/null; then
-	if [ -z "$D" -a `test -f "${INIT_D_DIR}/${INITSCRIPT_NAME}"` ]; then
+	if [ -z "$D" -a -f "${INIT_D_DIR}/${INITSCRIPT_NAME}" ]; then
 		${INIT_D_DIR}/${INITSCRIPT_NAME} stop
 	fi
 	if [ -n "$D" ]; then
Signature · 1 line
1.8.3.1