HID: wiimote: fix inverted pro-controller axes
Subsystems (2)
PATCH 1/1 HID: wiimote: fix inverted pro-controller axes
The analog-stick vertical axes are inverted. Fix that! Otherwise, games and other gamepad applications need to carry their own fixups (which they thankfully haven't done, yet).
Cc <[email protected]> # 3.11+
Reported-by Rafael Brune <[email protected]>
Signed-off-by David Herrmann <[email protected]>
--- drivers/hid/hid-wiimote-modules.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/hid/hid-wiimote-modules.c +2 -2
@@ -1656,9 +1656,9 @@ static void wiimod_pro_in_ext(struct wiimote_data *wdata, const __u8 *ext) ry = (ext[6 ] &0xff ) | ((ext[7 ] &0x0f ) <<8 );input_report_abs (wdata->extension.input,ABS_X , lx -0x800 ); -input_report_abs (wdata->extension.input,ABS_Y , ly -0x800 ); +input_report_abs (wdata->extension.input,ABS_Y ,0x800 - ly);input_report_abs (wdata->extension.input,ABS_RX , rx -0x800 ); -input_report_abs (wdata->extension.input,ABS_RY , ry -0x800 ); +input_report_abs (wdata->extension.input,ABS_RY ,0x800 - ry); input_report_key(wdata->extension.input, wiimod_pro_map[WIIMOD_PRO_KEY_RIGHT],
Signature · 1 line
1.8.4.1
Quoted 7 lines · David Herrmann
The analog-stick vertical axes are inverted. Fix that! Otherwise, games and other gamepad applications need to carry their own fixups (which they thankfully haven't done, yet).
Cc <[email protected]> # 3.11+Reported-by Rafael Brune <[email protected]>Signed-off-by David Herrmann <[email protected]>
Tested-by Rafael Brune <[email protected]>
Quoted 27 lines
---
drivers/hid/hid-wiimote-modules.c| 4 ++--1 file changed, 2 insertions(+), 2 deletions(-)drivers/hid/hid-wiimote-modules.c +2
-2@@ -1656,9 +1656,9 @@ static void wiimod_pro_in_ext(struct wiimote_data *wdata, const __u8 *ext) ry = (ext[6 ] &0xff ) | ((ext[7 ] &0x0f ) <<8 );input_report_abs (wdata->extension.input,ABS_X , lx -0x800 ); -input_report_abs (wdata->extension.input,ABS_Y , ly -0x800 ); +input_report_abs (wdata->extension.input,ABS_Y ,0x800 - ly);input_report_abs (wdata->extension.input,ABS_RX , rx -0x800 ); -input_report_abs (wdata->extension.input,ABS_RY , ry -0x800 ); +input_report_abs (wdata->extension.input,ABS_RY ,0x800 - ry); input_report_key(wdata->extension.input, wiimod_pro_map[WIIMOD_PRO_KEY_RIGHT],Signature · 6 lines
1.8.4.1 -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Jiri Kosina
AppliedQuoted 8 lines · Rafael Brune
Quoted 7 lines
The analog-stick vertical axes are inverted. Fix that! Otherwise, games and other gamepad applications need to carry their own fixups (which they thankfully haven't done, yet).
Cc <[email protected]> # 3.11+Reported-by Rafael Brune <[email protected]>Signed-off-by David Herrmann <[email protected]>Tested-by Rafael Brune <[email protected]>
Applied, thanks.
Signature · 2 lines
Jiri Kosina SUSE Labs