arc_emac: drop redundant mac address check
Subsystems (2)
PATCH v2 1/1 arc_emac: drop redundant mac address check
Checking if MAC address is valid using is_valid_ether_addr() is already done in of_get_mac_address(). While at it, reorganize checking so it matches checks in other drivers.
Signed-off-by Luka Perkov <[email protected]>
CC Alexey Brodkin <[email protected]>
CC David Miller <[email protected]>
---v1->v2:
* cosmetic commit message fix based on comment from David Miller
--- drivers/net/ethernet/arc/emac_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/ethernet/arc/emac_main.c +3 -3
@@ -725,10 +725,10 @@ static int arc_emac_probe(struct platform_device *pdev)/* Get MAC address from device tree */ mac_addr =of_get_mac_address (pdev->dev.of_node); -if (!mac_addr || !is_valid_ether_addr (mac_addr)) -eth_hw_addr_random (ndev); -else +if (mac_addr)memcpy (ndev->dev_addr, mac_addr,ETH_ALEN ); +else +eth_hw_addr_random (ndev);dev_info (&pdev->dev,"MAC address is now %pM\n" , ndev->dev_addr);
Signature · 1 line
1.8.4.2
From: Luka Perkov <[email protected]>
Date: Wed, 30 Oct 2013 00:11:00 +0100
Quoted 5 lines
Checking if MAC address is valid using
is_valid_ether_addr()is already done inof_get_mac_address(). While at it, reorganize checking so it matches checks in other drivers.Signed-off-by Luka Perkov <[email protected]>
Applied.