drm/i915/vlv: Fix typo in the DPIO register define.
Subsystems (2)
PATCH 1/1 drm/i915/vlv: Fix typo in the DPIO register define.
Incorrect definition DPIO_TX3_SWING_CTL4.
Signed-off-by Chon Ming Lee <[email protected]>
--- drivers/gpu/drm/i915/i915_reg.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/gpu/drm/i915/i915_reg.h +1 -1
@@ -444,7 +444,7 @@#define _DPIO_TX3_SWING_CTL4_A 0x690#define _DPIO_TX3_SWING_CTL4_B 0x2a90 -#define DPIO_TX3_SWING_CTL4 (pipe) _PIPE(pipe, _DPIO_TX_SWING_CTL4_A, \ +#define DPIO_TX3_SWING_CTL4 (pipe) _PIPE(pipe, _DPIO_TX3_SWING_CTL4_A, \ _DPIO_TX3_SWING_CTL4_B)/*
Signature · 1 line
1.7.7.6
Quoted 3 lines · Chon Ming Lee
Incorrect definition
DPIO_TX3_SWING_CTL4.Signed-off-by Chon Ming Lee <[email protected]>
Reviewed-by Ville Syrjälä <[email protected]>
Based on the specs, the typo meant that HDMI B ended up using "incorrect" de-emphasis for the TMDS data lanes.
Quoted 24 lines
--- drivers/gpu/drm/i915/i915_reg.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/gpu/drm/i915/i915_reg.h +1
-1@@ -444,7 +444,7 @@#define _DPIO_TX3_SWING_CTL4_A 0x690#define _DPIO_TX3_SWING_CTL4_B 0x2a90 -#define DPIO_TX3_SWING_CTL4 (pipe) _PIPE(pipe, _DPIO_TX_SWING_CTL4_A, \ +#define DPIO_TX3_SWING_CTL4 (pipe) _PIPE(pipe, _DPIO_TX3_SWING_CTL4_A, \ _DPIO_TX3_SWING_CTL4_B)/* Signature · 6 lines
1.7.7.6 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 2 lines
Ville Syrjälä Intel OTC
Daniel Vetter
AppliedQuoted 6 lines · Ville Syrjälä
Quoted 3 lines · Chon Ming Lee
Incorrect definition
DPIO_TX3_SWING_CTL4.Signed-off-by Chon Ming Lee <[email protected]>Reviewed-by Ville Syrjälä <[email protected]>
Queued for -next, thanks for the patch.
Quoted 2 lines
Based on the specs, the typo meant that HDMI B ended up using "incorrect" de-emphasis for the TMDS data lanes.
I've added this explanation to the commit message to describe the impact a bit better. Next time around please elaborate a bit more about the impact of a change so other people have an idea how important a patch is or whether it might help for a given issue they have.
Thanks, Daniel
Quoted 33 lines
Quoted 25 lines
--- drivers/gpu/drm/i915/i915_reg.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/gpu/drm/i915/i915_reg.h +1
-1@@ -444,7 +444,7 @@#define _DPIO_TX3_SWING_CTL4_A 0x690#define _DPIO_TX3_SWING_CTL4_B 0x2a90 -#define DPIO_TX3_SWING_CTL4 (pipe) _PIPE(pipe, _DPIO_TX_SWING_CTL4_A, \ +#define DPIO_TX3_SWING_CTL4 (pipe) _PIPE(pipe, _DPIO_TX3_SWING_CTL4_A, \ _DPIO_TX3_SWING_CTL4_B)/* Signature · 6 lines
1.7.7.6 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfxSignature · 6 lines
Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch