ARM: imx6q: add missing sentinel to divider table
Subsystems (3)
PATCH 1/1 ARM: imx6q: add missing sentinel to divider table
The clk_enet_ref_table[] is missing a final empty entry as end of list marker. Also make the existing markers more obvious.
--- arch/arm/mach-imx/clk-imx6q.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)
arch/arm/mach-imx/clk-imx6q.c +3 -2
@@ -122,13 +122,14 @@ static struct clk_div_table clk_enet_ref_table[] = { { .val = 1, .div = 10, }, { .val = 2, .div = 5, }, { .val = 3, .div = 4, }, + { /* sentinel */ } }; static struct clk_div_table post_div_table[] = { { .val = 2, .div = 1, }, { .val = 1, .div = 2, }, { .val = 0, .div = 4, }, - { } + { /* sentinel */ } }; static struct clk_div_table video_div_table[] = {
@@ -136,7 +137,7 @@ static struct clk_div_table video_div_table[] = { { .val = 1, .div = 2, }, { .val = 2, .div = 1, }, { .val = 3, .div = 4, }, - { } + { /* sentinel */ } }; static void __init imx6q_clocks_init(struct device_node *ccm_node)
Signature · 1 line
1.7.2.5
PATCH 1/1 ARM: imx6q: add missing sentinel to divider table
Hi,
Quoted 6 lines · Lothar Wa?mann
The clk_enet_ref_table[] is missing a final empty entry as end of list marker. Also make the existing markers more obvious.
Signed-off-by Lothar Wa?mann <[email protected]>--- arch/arm/mach-imx/clk-imx6q.c | 5 +++--
There is something else that looks suspicious in this file:
The video_div_table[] has four entries:
| { .val = 0, .div = 1, },
| { .val = 1, .div = 2, },
| { .val = 2, .div = 1, },
| { .val = 3, .div = 4, },But the code that sets the dividers to '1' as a workaround for the TO1.0 chip revision only two dividers are modified, one of which is already '1':
|if (cpu_is_imx6q() && imx_get_soc_revision() == IMX_CHIP_REVISION_1_0) {
| post_div_table[1].div = 1;
| post_div_table[2].div = 1;
| video_div_table[1].div = 1;
| video_div_table[2].div = 1;
^This probably should be '3' instead?
Lothar Wa?mann
Signature · 9 lines
___________________________________________________________ Ka-Ro electronics GmbH | Pascalstra?e 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Gesch?ftsf?hrer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | info at karo-electronics.de ___________________________________________________________
Shawn Guo
AppliedPATCH 1/1 ARM: imx6q: add missing sentinel to divider table
In reply to Lothar WaßmannQuoted 3 lines · Lothar Wa?mann
The clk_enet_ref_table[] is missing a final empty entry as end of list marker. Also make the existing markers more obvious.
Signed-off-by Lothar Wa?mann <[email protected]>
Please have a blank line between commit log and SoB in the later patches.
Applied, thanks.