drm/i915: use the correct register when turning VDD off
Subsystems (2)
A message that is not in the archive (sent off-list or not yet received): bf13e81b904a37d94d83dd6c3b53a147719a3ead
PATCH 1/1 drm/i915: use the correct register when turning VDD off
From: Paulo Zanoni <[email protected]>
That explains why I was seeing 2 consecutive "Turning eDP VDD off" messages.
Regression introduced by:
commit bf13e81b904a37d94d83dd6c3b53a147719a3ead
Author: Jani Nikula <[email protected]>
Date: Fri Sep 6 07:40:05 2013 +0300
drm/i915: add support for per-pipe power sequencing on vlv
--- drivers/gpu/drm/i915/intel_dp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_dp.c +2 -2
@@ -1125,8 +1125,8 @@ static void ironlake_panel_vdd_off_sync(struct intel_dp *intel_dp) pp =ironlake_get_pp_control (intel_dp); pp &= ~EDP_FORCE_VDD ; - pp_stat_reg =_pp_ctrl_reg (intel_dp); - pp_ctrl_reg =_pp_stat_reg (intel_dp); + pp_ctrl_reg =_pp_ctrl_reg (intel_dp); + pp_stat_reg =_pp_stat_reg (intel_dp);I915_WRITE (pp_ctrl_reg, pp);POSTING_READ (pp_ctrl_reg);
Signature · 1 line
1.8.3.1
Quoted 5 lines · Paulo Zanoni
From: Paulo Zanoni <[email protected]>
That explains why I was seeing 2 consecutive "Turning eDP VDD off" messages.
Quoted 7 lines
Regression introduced by:
commitbf13e81b904a37d94d83dd6c3b53a147719a3ead
Author: Jani Nikula <[email protected]>
Date: Fri Sep 6 07:40:05 2013 +0300
drm/i915: add support for per-pipe power sequencing on vlvSigned-off-by Paulo Zanoni <[email protected]>
Good catch,
Quoted 26 lines
--- drivers/gpu/drm/i915/intel_dp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/intel_dp.c +2
-2@@ -1125,8 +1125,8 @@ static void ironlake_panel_vdd_off_sync(struct intel_dp *intel_dp) pp =ironlake_get_pp_control (intel_dp); pp &= ~EDP_FORCE_VDD ; - pp_stat_reg =_pp_ctrl_reg (intel_dp); - pp_ctrl_reg =_pp_stat_reg (intel_dp); + pp_ctrl_reg =_pp_ctrl_reg (intel_dp); + pp_stat_reg =_pp_stat_reg (intel_dp);I915_WRITE (pp_ctrl_reg, pp);POSTING_READ (pp_ctrl_reg);Signature · 6 lines
1.8.3.1 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 1 line
Jani Nikula, Intel Open Source Technology Center