Skip to contentSkip to conversation

tcp: enable sockets to use MSG_FASTOPEN by default

PATCH Applied Yuchung Cheng 4 participants 5 messages Oct 31, 2013 – Nov 5, 2013

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tcp: enable sockets to use MSG_FASTOPEN by default

Applications have started to use Fast Open (e.g., Chrome browser has such an optional flag) and the feature has gone through several generations of kernels since 3.7 with many real network tests. It's time to enable this flag by default for applications to test more conveniently and extensively.

---
 Documentation/networking/ip-sysctl.txt | 4 ++--
 net/ipv4/tcp_fastopen.c                | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
Documentation/networking/ip-sysctl.txt +2 -2
index a46d785..6c00983 100644
@@ -451,7 +451,7 @@ tcp_fastopen - INTEGER
 	connect() to perform a TCP handshake automatically.
 
 	The values (bitmap) are
-	1: Enables sending data in the opening SYN on the client.
+	1: Enables sending data in the opening SYN on the client w/ MSG_FASTOPEN.
 	2: Enables TCP Fast Open on the server side, i.e., allowing data in
 	   a SYN packet to be accepted and passed to the application before
 	   3-way hand shake finishes.
@@ -464,7 +464,7 @@ tcp_fastopen - INTEGER
 	   different ways of setting max_qlen without the TCP_FASTOPEN socket
 	   option.
 
-	Default: 0
+	Default: 1
 
 	Note that the client & server side Fast Open flags (1 and 2
 	respectively) must be also enabled before the rest of flags can take
net/ipv4/tcp_fastopen.c +1 -1
index 766032b..f195d93 100644
@@ -8,7 +8,7 @@
 #include <net/inetpeer.h>
 #include <net/tcp.h>
 
-int sysctl_tcp_fastopen __read_mostly;
+int sysctl_tcp_fastopen __read_mostly = TFO_CLIENT_ENABLE;
 
 struct tcp_fastopen_context __rcu *tcp_fastopen_ctx;
 
Signature · 1 line
1.8.4.1
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Yuchung Cheng

Applications have started to use Fast Open (e.g., Chrome browser has such an optional flag) and the feature has gone through several generations of kernels since 3.7 with many real network tests. It's time to enable this flag by default for applications to test more conveniently and extensively.

---

#2 lore raw
Quoted 7 lines · Eric Dumazet
Quoted 6 lines · Yuchung Cheng

Applications have started to use Fast Open (e.g., Chrome browser has such an optional flag) and the feature has gone through several generations of kernels since 3.7 with many real network tests. It's time to enable this flag by default for applications to test more conveniently and extensively.

Quoted 5 lines
Quoted 3 lines

---

Which TCP/IP stacks besides Linux have Fast Open at this point and for how long have they had it? Basically, how prevalent are servers out there (both Internet and intranet) with support for Fast Open?

http://news.netcraft.com/archives/2013/11/01/november-2013-web-server-survey.html
doesn't go down to the OS level, and
http://www.netcraft.com/internet-data-mining/ssl-survey/ is only from May and was in the context of SSL sides, but it does provide an interesting break-down of "OS share" which looks reasonably stable going back three years and so probably isn't too far off presently.

<insert the same sort of question about those firewalls and intermediate devices which make our lives so much fun here>

rick jones

#3 lore raw
Quoted 15 lines · Rick Jones
Quoted 14 lines · Eric Dumazet
Quoted 10 lines · Yuchung Cheng

Applications have started to use Fast Open (e.g., Chrome browser has such an optional flag) and the feature has gone through several generations of kernels since 3.7 with many real network tests. It's time to enable this flag by default for applications to test more conveniently and extensively.

---

Quoted 6 lines
Quoted 1 line

Which TCP/IP stacks besides Linux have Fast Open at this point and for how long have they had it? Basically, how prevalent are servers out there (both Internet and intranet) with support for Fast Open?

google.com supports it. we are working on enabling more Android and ChromeOS to use it.

Quoted 13 lines

http://news.netcraft.com/archives/2013/11/01/november-2013-web-server-survey.html
doesn't go down to the OS level, and
http://www.netcraft.com/internet-data-mining/ssl-survey/ is only from May and was in the context of SSL sides, but it does provide an interesting break-down of "OS share" which looks reasonably stable going back three years and so probably isn't too far off presently.

<insert the same sort of question about those firewalls and intermediate devices which make our lives so much fun here>

rick jones

maintainer Applied
#4 lore raw
In reply to Yuchung Cheng

From: Yuchung Cheng <[email protected]>
Date: Thu, 31 Oct 2013 09:19:32 -0700

Quoted 8 lines

Applications have started to use Fast Open (e.g., Chrome browser has such an optional flag) and the feature has gone through several generations of kernels since 3.7 with many real network tests. It's time to enable this flag by default for applications to test more conveniently and extensively.

Applied.