Skip to contentSkip to conversation

qemu: use PACKAGECONFIG to address nss dependencies

PATCH In review Hongxu Jia 3 participants 9 messages Oct 31, 2013 – Nov 1, 2013

lore
Share & tools
lore

Hongxu Jia

author
#0 lore raw

cover qemu: use PACKAGECONFIG to address nss dependencies

The following changes since commit 523f2a9ea970713fb775bc48f84b67420b1106a0:

cross-canadian: Improve comment (2013-10-30 18:01:34 +0000)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib hongxu/fix-qemu-nss
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=hongxu/fix-qemu-nss

Hongxu Jia (1):
qemu: use PACKAGECONFIG to address nss dependencies

 meta/recipes-devtools/qemu/qemu.inc | 1 +
 1 file changed, 1 insertion(+)
Signature · 1 line
1.8.1.2
author
#1 lore raw

PATCH 1/1 qemu: use PACKAGECONFIG to address nss dependencies

Use PACKAGECONFIG to explicitly address nss dependencies rather than tested by configure.

It avoided potential errors while multiple builds shared a common state_cache.

---
 meta/recipes-devtools/qemu/qemu.inc | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-devtools/qemu/qemu.inc +1 -0
index 1b861d7..87a7275 100644
@@ -83,6 +83,7 @@ do_install_append() {
 PACKAGECONFIG ??= ""
 PACKAGECONFIG[virtfs] = "--enable-virtfs --enable-attr,--disable-virtfs,libcap attr,"
 PACKAGECONFIG[aio] = "--enable-linux-aio,--disable-linux-aio,libaio,"
+PACKAGECONFIG[nss] = "--enable-smartcard-nss,--disable-smartcard-nss,nss,"
 
 # Qemu target will not build in world build for ARM or Mips
 BROKEN_qemuarm = "1"
Signature · 1 line
1.8.1.2
#2 lore raw
Quoted 5 lines · Hongxu Jia

Use PACKAGECONFIG to explicitly address nss dependencies rather than tested by configure.

It avoided potential errors while multiple builds shared a common state_cache.

There are more floating dependencies in qemu.inc, see
http://patchwork.openembedded.org/patch/56935/

and even this list isn't complete, there is also:
WARN: packages/armv5te-oe-linux-gnueabi/qemu/qemu/latest lost dependency on cairo gdk-pixbuf gnutls gtk+ libvte

Can you please improve it to fix them all?

Quoted 25 lines
---
 meta/recipes-devtools/qemu/qemu.inc | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-devtools/qemu/qemu.inc +1 -0
index 1b861d7..87a7275 100644
@@ -83,6 +83,7 @@ do_install_append() {
 PACKAGECONFIG ??= ""
 PACKAGECONFIG[virtfs] = "--enable-virtfs --enable-attr,--disable-virtfs,libcap attr,"
 PACKAGECONFIG[aio] = "--enable-linux-aio,--disable-linux-aio,libaio,"
+PACKAGECONFIG[nss] = "--enable-smartcard-nss,--disable-smartcard-nss,nss,"
 
 # Qemu target will not build in world build for ARM or Mips
 BROKEN_qemuarm = "1"
Signature · 6 lines
1.8.1.2

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
author
#3 lore raw
Quoted 6 lines · Martin Jansa
Quoted 5 lines · Hongxu Jia

Use PACKAGECONFIG to explicitly address nss dependencies rather than tested by configure.

It avoided potential errors while multiple builds shared a common state_cache.

Quoted 8 lines

There are more floating dependencies in qemu.inc, see
http://patchwork.openembedded.org/patch/56935/

and even this list isn't complete, there is also:
WARN: packages/armv5te-oe-linux-gnueabi/qemu/qemu/latest lost dependency on cairo gdk-pixbuf gnutls gtk+ libvte

Can you please improve it to fix them all?

OK, I will try to fix them as possible as I can.

Drop this patch, wait for V2.

//Hongxu

Quoted 24 lines
Quoted 24 lines
---
  meta/recipes-devtools/qemu/qemu.inc | 1 +
  1 file changed, 1 insertion(+)
meta/recipes-devtools/qemu/qemu.inc +1 -0
index 1b861d7..87a7275 100644
@@ -83,6 +83,7 @@ do_install_append() {
  PACKAGECONFIG ??= ""
  PACKAGECONFIG[virtfs] = "--enable-virtfs --enable-attr,--disable-virtfs,libcap attr,"
  PACKAGECONFIG[aio] = "--enable-linux-aio,--disable-linux-aio,libaio,"
+PACKAGECONFIG[nss] = "--enable-smartcard-nss,--disable-smartcard-nss,nss,"
 
  # Qemu target will not build in world build for ARM or Mips
  BROKEN_qemuarm = "1"
Signature · 6 lines
1.8.1.2

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
#4 lore raw
Quoted 13 lines · Hongxu Jia
Quoted 12 lines · Martin Jansa
Quoted 5 lines · Hongxu Jia

Use PACKAGECONFIG to explicitly address nss dependencies rather than tested by configure.

It avoided potential errors while multiple builds shared a common state_cache.

There are more floating dependencies in qemu.inc, see
http://patchwork.openembedded.org/patch/56935/

and even this list isn't complete, there is also:
WARN: packages/armv5te-oe-linux-gnueabi/qemu/qemu/latest lost dependency on cairo gdk-pixbuf gnutls gtk+ libvte

Quoted 6 lines
Quoted 2 lines

Can you please improve it to fix them all?

OK, I will try to fix them as possible as I can.

Drop this patch, wait for V2.

Part of the problem here is that qemu-native has some "floating" dependencies by design. If the native system has graphics support, qemu will have too. If it doesn't it won't have. This works out to be quite useful for people. Some people have headless build machines they don't want to install X on, equally some have build machines which do have X and they do want graphical qemu.

How do we support both?

Cheers,

Richard

#5 lore raw
Quoted 21 lines · Richard Purdie
Quoted 13 lines · Hongxu Jia
Quoted 12 lines · Martin Jansa
Quoted 5 lines · Hongxu Jia

Use PACKAGECONFIG to explicitly address nss dependencies rather than tested by configure.

It avoided potential errors while multiple builds shared a common state_cache.

There are more floating dependencies in qemu.inc, see
http://patchwork.openembedded.org/patch/56935/

and even this list isn't complete, there is also:
WARN: packages/armv5te-oe-linux-gnueabi/qemu/qemu/latest lost dependency on cairo gdk-pixbuf gnutls gtk+ libvte

Quoted 6 lines
Quoted 2 lines

Can you please improve it to fix them all?

OK, I will try to fix them as possible as I can.

Drop this patch, wait for V2.

Quoted 8 lines

Part of the problem here is that qemu-native has some "floating" dependencies by design. If the native system has graphics support, qemu will have too. If it doesn't it won't have. This works out to be quite useful for people. Some people have headless build machines they don't want to install X on, equally some have build machines which do have X and they do want graphical qemu.

How do we support both?

Aren't reproducible builds more important than automagically enabled graphics support, what if such automagically enabled qemu-native gets reused from sstate on headless server without graphics support?

We can extend documentation to say that in order to enable graphics support for qemu-native you need to set PACKAGECONFIG_pn-qemu-native += "foo bar"
in local.conf (or to remove some to disable it, but enabling explicitly is imho better because we don't have graphics native support in ASSUME_PROVIDED).

Regards,

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#6 lore raw
Quoted 29 lines · Martin Jansa
Quoted 28 lines · Richard Purdie
Quoted 13 lines · Hongxu Jia
Quoted 12 lines · Martin Jansa
Quoted 5 lines · Hongxu Jia

Use PACKAGECONFIG to explicitly address nss dependencies rather than tested by configure.

It avoided potential errors while multiple builds shared a common state_cache.

There are more floating dependencies in qemu.inc, see
http://patchwork.openembedded.org/patch/56935/

and even this list isn't complete, there is also:
WARN: packages/armv5te-oe-linux-gnueabi/qemu/qemu/latest lost dependency on cairo gdk-pixbuf gnutls gtk+ libvte

Quoted 6 lines
Quoted 2 lines

Can you please improve it to fix them all?

OK, I will try to fix them as possible as I can.

Drop this patch, wait for V2.

Part of the problem here is that qemu-native has some "floating" dependencies by design. If the native system has graphics support, qemu will have too. If it doesn't it won't have. This works out to be quite useful for people. Some people have headless build machines they don't want to install X on, equally some have build machines which do have X and they do want graphical qemu.

Quoted 5 lines
Quoted 1 line

How do we support both?

Aren't reproducible builds more important than automagically enabled graphics support, what if such automagically enabled qemu-native gets reused from sstate on headless server without graphics support?

I agree there is a problem here. Equally, there is an important use case which people do use and care about which this patch removes.

Quoted 6 lines

We can extend documentation to say that in order to enable graphics support for qemu-native you need to set PACKAGECONFIG_pn-qemu-native += "foo bar"
in local.conf (or to remove some to disable it, but enabling explicitly is imho better because we don't have graphics native support in ASSUME_PROVIDED).

I think we'll have to do something like this, yes. I'd like to see the patches adding this documentation to local.conf before we change things though.

Cheers,

Richard

author
#7 lore raw
Quoted 41 lines · Richard Purdie
Quoted 27 lines · Martin Jansa
Quoted 26 lines · Richard Purdie
Quoted 10 lines · Hongxu Jia
Quoted 9 lines · Martin Jansa
Quoted 5 lines · Hongxu Jia

Use PACKAGECONFIG to explicitly address nss dependencies rather than tested by configure.

It avoided potential errors while multiple builds shared a common state_cache.

There are more floating dependencies in qemu.inc, see
http://patchwork.openembedded.org/patch/56935/

Quoted 8 lines
Quoted 5 lines

and even this list isn't complete, there is also:
WARN: packages/armv5te-oe-linux-gnueabi/qemu/qemu/latest lost dependency on cairo gdk-pixbuf gnutls gtk+ libvte

Can you please improve it to fix them all?

OK, I will try to fix them as possible as I can.

Drop this patch, wait for V2.

Part of the problem here is that qemu-native has some "floating" dependencies by design. If the native system has graphics support, qemu will have too. If it doesn't it won't have. This works out to be quite useful for people. Some people have headless build machines they don't want to install X on, equally some have build machines which do have X and they do want graphical qemu.

Quoted 4 lines
Quoted 1 line

How do we support both?

Aren't reproducible builds more important than automagically enabled graphics support, what if such automagically enabled qemu-native gets reused from sstate on headless server without graphics support?

I agree there is a problem here. Equally, there is an important use case which people do use and care about which this patch removes.

Quoted 6 lines

We can extend documentation to say that in order to enable graphics support for qemu-native you need to set PACKAGECONFIG_pn-qemu-native += "foo bar"
in local.conf (or to remove some to disable it, but enabling explicitly is imho better because we don't have graphics native support in ASSUME_PROVIDED).

Quoted 3 lines

I think we'll have to do something like this, yes. I'd like to see the patches adding this documentation to local.conf before we change things though.

OK, how about add the above documentation as comments in the patch.
...

meta/recipes-devtools/qemu/qemu.inc +4 -1
@@ -79,6 +79,10 @@ do_install_append() {
 }
 # END of qemu-mips workaround
 
+# Disable the following flags by default. Such as graphics is
+# disabled for qemu-native, if you need to enable them, set
+# PACKAGECONFIG_pn-qemu-native += "foo bar" in local.conf
+# or just comment out them to let configure do the test.
 PACKAGECONFIG ??= ""
 PACKAGECONFIG[virtfs] = "--enable-virtfs 
--enable-attr,--disable-virtfs,libcap attr,"

PACKAGECONFIG[aio] = "--enable-linux-aio,--disable-linux-aio,libaio,"
...

or add them to meta-yocto/conf/local.conf.sample.extended or some place else?

And I could not exactly figure out which flags affected the graphics.

//Hongxu

Quoted 4 lines

Cheers,

Richard

#8 lore raw
Quoted 51 lines · Hongxu Jia
Quoted 41 lines · Richard Purdie
Quoted 27 lines · Martin Jansa
Quoted 26 lines · Richard Purdie
Quoted 10 lines · Hongxu Jia
Quoted 9 lines · Martin Jansa
Quoted 5 lines · Hongxu Jia

Use PACKAGECONFIG to explicitly address nss dependencies rather than tested by configure.

It avoided potential errors while multiple builds shared a common state_cache.

There are more floating dependencies in qemu.inc, see
http://patchwork.openembedded.org/patch/56935/

Quoted 8 lines
Quoted 5 lines

and even this list isn't complete, there is also:
WARN: packages/armv5te-oe-linux-gnueabi/qemu/qemu/latest lost dependency on cairo gdk-pixbuf gnutls gtk+ libvte

Can you please improve it to fix them all?

OK, I will try to fix them as possible as I can.

Drop this patch, wait for V2.

Part of the problem here is that qemu-native has some "floating" dependencies by design. If the native system has graphics support, qemu will have too. If it doesn't it won't have. This works out to be quite useful for people. Some people have headless build machines they don't want to install X on, equally some have build machines which do have X and they do want graphical qemu.

Quoted 4 lines
Quoted 1 line

How do we support both?

Aren't reproducible builds more important than automagically enabled graphics support, what if such automagically enabled qemu-native gets reused from sstate on headless server without graphics support?

I agree there is a problem here. Equally, there is an important use case which people do use and care about which this patch removes.

Quoted 6 lines

We can extend documentation to say that in order to enable graphics support for qemu-native you need to set PACKAGECONFIG_pn-qemu-native += "foo bar"
in local.conf (or to remove some to disable it, but enabling explicitly is imho better because we don't have graphics native support in ASSUME_PROVIDED).

Quoted 3 lines

I think we'll have to do something like this, yes. I'd like to see the patches adding this documentation to local.conf before we change things though.

OK, how about add the above documentation as comments in the patch.
...

meta/recipes-devtools/qemu/qemu.inc do_install_append() { · line 85

Quoted 7 lines
meta/recipes-devtools/qemu/qemu.inc +4 -0
@@ -79,6 +79,10 @@ do_install_append() {
  }
  # END of qemu-mips workaround
 
+# Disable the following flags by default. Such as graphics is
+# disabled for qemu-native, if you need to enable them, set
+# PACKAGECONFIG_pn-qemu-native += "foo bar" in local.conf
+# or just comment out them to let configure do the test.

From this comment it's not clear that people need to comment out PACKAGECONFIG[foo] lines (not PACKAGECONFIG values) and I believe that setting right PACKAGECONFIG_pn-qemu-native is more reliable and easier (I don't know if you can easily remove PACKAGECONFIG varflag from local.conf.

Once I explicitly enable graphics support in my local.conf I would prefer qemu-native configure to fail if my host distribution is changes and became incompatible.

Quoted 19 lines
meta/recipes-devtools/qemu/qemu.inc +0 -1
  PACKAGECONFIG ??= ""
  PACKAGECONFIG[virtfs] = "--enable-virtfs 
--enable-attr,--disable-virtfs,libcap attr,"
  PACKAGECONFIG[aio] = "--enable-linux-aio,--disable-linux-aio,libaio,"
...

or add them to meta-yocto/conf/local.conf.sample.extended or some place else?

And I could not exactly figure out which flags affected the graphics.

//Hongxu

Quoted 4 lines

Cheers,

Richard

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]