libcap-ng: disable_on_avr32
PATCH 1/1 libcap-ng: disable_on_avr32
From: Simon Dawson <[email protected]>
Thread-local storage is not available in the avr32 toolchain, so libcap-ng must be disabled on avr32. Fixed build failures such as the following.
http://autobuild.buildroot.net/results/05f/05f73cb74ee7bfb1c337100312726de034366a7d/
--- package/libcap-ng/Config.in | 1 + 1 file changed, 1 insertion(+)
package/libcap-ng/Config.in +1 -0
@@ -1,5 +1,6 @@ config BR2_PACKAGE_LIBCAP_NG bool "libcap-ng" + depends on !BR2_avr32 # TLS not available help The libcap-ng library is intended to make programming with posix capabilities much easier than the traditional libcap
Signature · 1 line
1.8.3.2
PATCH 1/1 libcap-ng: disable_on_avr32
Simon,
Quoted 17 lines · spdawson at gmail.com
From: Simon Dawson <[email protected]>
Thread-local storage is not available in the avr32 toolchain, so libcap-ng must be disabled on avr32. Fixed build failures such as the following.
http://autobuild.buildroot.net/results/05f/05f73cb74ee7bfb1c337100312726de034366a7d/
Signed-off-by Simon Dawson <[email protected]>--- package/libcap-ng/Config.in | 1 + 1 file changed, 1 insertion(+)package/libcap-ng/Config.in +0
-0
package/libcap-ng/Config.in line 6
Quoted 6 lines
package/libcap-ng/Config.in +1
-0@@ -1,5 +1,6 @@ config BR2_PACKAGE_LIBCAP_NG bool "libcap-ng" + depends on !BR2_avr32 # TLS not available help The libcap-ng library is intended to make programming with posix capabilities much easier than the traditional libcap
Thanks! I already sent a somewhat similar patch at
http://patchwork.ozlabs.org/patch/280889/, but Peter complained that the problem was really related to the absence of TLS support rather than AVR32, and that the TLS support could also be disabled on other architectures using the BR2_GCC_ENABLE_TLS option. However, the problem is that this option only exists for internal toolchains: for external toolchains, we have absolutely no idea whether they have TLS support or not.
My own point of view would be to remove the possibility of configuring out TLS support, and simply assume TLS support is always enabled when thread support is available. What do others think about this?
Also, you forgot to propagate the dependency to the 'ofono' package, which selects libcap-ng.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 libcap-ng: disable_on_avr32
Quoted 36 lines · Thomas Petazzoni
Simon,
Quoted 17 lines · spdawson at gmail.com
From: Simon Dawson <[email protected]>
Thread-local storage is not available in the avr32 toolchain, so libcap-ng must be disabled on avr32. Fixed build failures such as the following.
http://autobuild.buildroot.net/results/05f/05f73cb74ee7bfb1c337100312726de034366a7d/Signed-off-by Simon Dawson <[email protected]>--- package/libcap-ng/Config.in | 1 + 1 file changed, 1 insertion(+)package/libcap-ng/Config.in +0
-0package/libcap-ng/Config.in line 6
Quoted 6 lines
package/libcap-ng/Config.in +1
-0@@ -1,5 +1,6 @@ config BR2_PACKAGE_LIBCAP_NG bool "libcap-ng" + depends on !BR2_avr32 # TLS not available help The libcap-ng library is intended to make programming with posix capabilities much easier than the traditional libcapThanks! I already sent a somewhat similar patch at
http://patchwork.ozlabs.org/patch/280889/, but Peter complained that the problem was really related to the absence of TLS support rather than AVR32, and that the TLS support could also be disabled on other architectures using theBR2_GCC_ENABLE_TLSoption. However, the problem is that this option only exists for internal toolchains: for external toolchains, we have absolutely no idea whether they have TLS support or not.
Quoted 3 lines
My own point of view would be to remove the possibility of configuring out TLS support, and simply assume TLS support is always enabled when thread support is available. What do others think about this?
Fine by me.
However, IIRC TLS is only available for NPTL, and this is not available
for all architectures. So it is just moving the problem around.
Regards,
Arnout
Quoted 8 lines
Also, you forgot to propagate the dependency to the 'ofono' package, which selects libcap-ng.
Best regards,
Thomas
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F