Skip to contentSkip to conversation

Richard Purdie : gcc: Fix strange C++ repo issues

oe-commits Martin Jansa 2 participants 2 messages Nov 4, 2013 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 20131014154535.D40A750398@opal

#1 lore raw
Quoted 23 lines · On Mon, Oct 14, 2013 at 03:45:35PM +0000, [email protected] wrote:
Module: openembedded-core.git
Branch: master
Commit: 9f6c4edf40963d1f3fb9f7e2d2b7a866aa1afe57
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=9f6c4edf40963d1f3fb9f7e2d2b7a866aa1afe57
Author: Richard Purdie <[email protected]>
Date:   Wed Oct  9 20:37:49 2013 +0000

gcc: Fix strange C++ repo issues

---

 meta/recipes-devtools/gcc/gcc-4.8.inc              |    1 +
 .../gcc/gcc-4.8/0047-repomembug.patch              |   53 ++++++++++++++++++++
 2 files changed, 54 insertions(+), 0 deletions(-)
meta/recipes-devtools/gcc/gcc-4.8.inc +0 -0
index 4af98f8..8d50bf7 100644

meta/recipes-devtools/gcc/gcc-4.8.inc SRC_URI = "${GNU_MIRROR}/gcc/gcc-${PV}/gcc-${PV}.tar.bz2 \ · line 80

Quoted 5 lines
meta/recipes-devtools/gcc/gcc-4.8.inc +1 -0
@@ -76,6 +76,7 @@ SRC_URI = "${GNU_MIRROR}/gcc/gcc-${PV}/gcc-${PV}.tar.bz2 \
 	   file://0044-gengtypes.patch \
 	   file://0045-gcc-4.8-PR57717-PowerPC-E500v2.patch \
 	   file://0046-libatomic-deptracking.patch \
+	   file://0047-repomembug.patch \
 	  "

Don't mix tabs and spaces in multiline variables.

All tabs in meta/recipes-devtools/gcc/gcc-4.8.inc are used incorrectly.

#2 lore raw
Quoted 32 lines · Martin Jansa
Quoted 23 lines · On Mon, Oct 14, 2013 at 03:45:35PM +0000, [email protected] wrote:
Module: openembedded-core.git
Branch: master
Commit: 9f6c4edf40963d1f3fb9f7e2d2b7a866aa1afe57
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=9f6c4edf40963d1f3fb9f7e2d2b7a866aa1afe57
Author: Richard Purdie <[email protected]>
Date:   Wed Oct  9 20:37:49 2013 +0000

gcc: Fix strange C++ repo issues

---

 meta/recipes-devtools/gcc/gcc-4.8.inc              |    1 +
 .../gcc/gcc-4.8/0047-repomembug.patch              |   53 ++++++++++++++++++++
 2 files changed, 54 insertions(+), 0 deletions(-)
meta/recipes-devtools/gcc/gcc-4.8.inc +0 -0
index 4af98f8..8d50bf7 100644

meta/recipes-devtools/gcc/gcc-4.8.inc SRC_URI = "${GNU_MIRROR}/gcc/gcc-${PV}/gcc-${PV}.tar.bz2 \ · line 80

Quoted 5 lines
meta/recipes-devtools/gcc/gcc-4.8.inc +1 -0
@@ -76,6 +76,7 @@ SRC_URI = "${GNU_MIRROR}/gcc/gcc-${PV}/gcc-${PV}.tar.bz2 \
 	   file://0044-gengtypes.patch \
 	   file://0045-gcc-4.8-PR57717-PowerPC-E500v2.patch \
 	   file://0046-libatomic-deptracking.patch \
+	   file://0047-repomembug.patch \
 	  "

Don't mix tabs and spaces in multiline variables.

Quoted 1 line

All tabs in meta/recipes-devtools/gcc/gcc-4.8.inc are used incorrectly.

Agreed, however I just copied the existing style which was better than the alternatives. Whitespace changes need to be in a separate patch.

Cheers,

Richard