ath10k: Fix un-initialized debug objects.
PATCH 1/1 ath10k: Fix un-initialized debug objects.
From: Ben Greear <[email protected]>
If the 'ar' registration fails early, the debug objects were not initialized, and trouble ensued when the object was later destroyed and the un-initialized objects were accessed.
Per Kalle's suggestion, move the debug_destroy to the core_unregister method.
Signed-off-by Ben Greear <[email protected]>
--- drivers/net/wireless/ath/ath10k/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/wireless/ath/ath10k/core.c +2 -2
@@ -738,8 +738,6 @@ EXPORT_SYMBOL(ath10k_core_create);void ath10k_core_destroy (struct ath10k *ar) { -ath10k_debug_destroy (ar); -flush_workqueue (ar->workqueue);destroy_workqueue (ar->workqueue);
@@ -986,6 +984,8 @@ void ath10k_core_unregister(struct ath10k *ar)ath10k_mac_unregister (ar);ath10k_core_free_firmware_files (ar); + +ath10k_debug_destroy (ar); }EXPORT_SYMBOL (ath10k_core_unregister);
Signature · 7 lines
1.7.11.7 _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
Kalle Valo
AppliedQuoted 11 lines · [email protected] writes:
From: Ben Greear <[email protected]>
If the 'ar' registration fails early, the debug objects were not initialized, and trouble ensued when the object was later destroyed and the un-initialized objects were accessed.
Per Kalle's suggestion, move the
debug_destroyto thecore_unregistermethod.Signed-off-by Ben Greear <[email protected]>
Thanks, applied.
Signature · 6 lines
Kalle Valo _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k