ath10k: Add logging to better determine some VIF/STA creation failures.
PATCH 1/1 ath10k: Add logging to better determine some VIF/STA creation failures.
From: Ben Greear <[email protected]>
--- drivers/net/wireless/ath/ath10k/mac.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-)
drivers/net/wireless/ath/ath10k/mac.c +10 -6
@@ -322,12 +322,16 @@ static int ath10k_peer_create(struct ath10k *ar, u32 vdev_id, const u8 *addr)lockdep_assert_held (&ar->conf_mutex); ret =ath10k_wmi_peer_create (ar, vdev_id, addr); -if (ret) +if (ret) { +ath10k_dbg (ATH10K_DBG_WMI ,"wmi_peer_create failed: %i\n" , ret);return ret; + } ret =ath10k_wait_for_peer_created (ar, vdev_id, addr); -if (ret) +if (ret) { +ath10k_dbg (ATH10K_DBG_WMI ,"wmi_wait_for_peer_created failed: %i\n" , ret);return ret; + }return 0 ; }
@@ -2404,8 +2408,8 @@ static void ath10k_bss_info_changed(struct ieee80211_hw *hw, ret =ath10k_peer_create (ar, arvif->vdev_id, info->bssid);if (ret) -ath10k_warn ("Failed to add peer: %pM for VDEV: %d\n" , - info->bssid, arvif->vdev_id); +ath10k_warn ("Failed to add peer: %pM for VDEV: %d ret: %i\n" , + info->bssid, arvif->vdev_id, ret);if (vif->type ==NL80211_IFTYPE_STATION ) {/*
@@ -2687,8 +2691,8 @@ static int ath10k_sta_state(struct ieee80211_hw *hw, ret =ath10k_peer_create (ar, arvif->vdev_id, sta->addr);if (ret) -ath10k_warn ("Failed to add peer: %pM for VDEV: %d\n" , - sta->addr, arvif->vdev_id); +ath10k_warn ("Failed to add peer: %pM for VDEV: %d, ret: %i\n" , + sta->addr, arvif->vdev_id, ret); }else if ((old_state ==IEEE80211_STA_NONE && new_state ==IEEE80211_STA_NOTEXIST )) {/*
Signature · 7 lines
1.7.11.7 _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
Quoted 2 lines · [email protected] writes:
From: Ben Greear <[email protected]>
I did some changes to this patch:
https://github.com/kvalo/ath/commit/20c062b93a1addc863d15334dd1eb5892a759f78
The patch is still on ath-next-test branch. Please take a look and if it's ok for you, send you S-o-b tag so that I can apply it (it was missing).
Signature · 6 lines
Kalle Valo _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
Quoted 5 lines · Kalle Valo
Quoted 2 lines · [email protected] writes:
From: Ben Greear <[email protected]>
Quoted 7 lines
I did some changes to this patch:
https://github.com/kvalo/ath/commit/20c062b93a1addc863d15334dd1eb5892a759f78
The patch is still on ath-next-test branch. Please take a look and if it's ok for you, send you S-o-b tag so that I can apply it (it was missing).
This part has some grammar issues, it seems to say that the failure is due to changed bssid. Maybe make it instead:
Failed to add peer %pM for vdev %d when changing bssid, error: %i
- ath10k_warn("Failed to add peer: %pM for VDEV: %d\n",
- info->bssid, arvif->vdev_id);
+ ath10k_warn("Failed to add peer %pM for vdev %d due to changed bssid: %i\n",
+ info->bssid, arvif->vdev_id, ret);
Either way, it's better than what was there before, so:
Signature · 8 lines
Ben Greear <[email protected]> Candela Technologies Inc http://www.candelatech.com _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
Quoted 24 lines · Ben Greear
Quoted 5 lines · Kalle Valo
Quoted 2 lines · [email protected] writes:
From: Ben Greear <[email protected]>
Quoted 7 lines
I did some changes to this patch:
https://github.com/kvalo/ath/commit/20c062b93a1addc863d15334dd1eb5892a759f78
The patch is still on ath-next-test branch. Please take a look and if it's ok for you, send you S-o-b tag so that I can apply it (it was missing).
This part has some grammar issues, it seems to say that the failure is due to changed bssid. Maybe make it instead:
Failed to add peer %pM for vdev %d when changing bssid, error: %i
drivers/net/wireless/ath/ath10k/mac.c +2
-2-ath10k_warn ("Failed to add peer: %pM for VDEV: %d\n" , - info->bssid, arvif->vdev_id); +ath10k_warn ("Failed to add peer %pM for vdev %d due to changed bssid: %i\n" , + info->bssid, arvif->vdev_id, ret);
Quoted 3 lines
Either way, it's better than what was there before, so:
Signed-off-by Ben Greear <[email protected]>
Good point, thanks. I just didn't use the word error as I thought that wasn't necessary. New version which I'll apply soon:
https://github.com/kvalo/ath/commit/ee309046323f2af1d2cd6f5c1361a6ce8dae5f87
Signature · 6 lines
Kalle Valo _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
Quoted 26 lines · Kalle Valo
Quoted 24 lines · Ben Greear
Quoted 5 lines · Kalle Valo
Quoted 2 lines · [email protected] writes:
From: Ben Greear <[email protected]>
Quoted 7 lines
I did some changes to this patch:
https://github.com/kvalo/ath/commit/20c062b93a1addc863d15334dd1eb5892a759f78
The patch is still on ath-next-test branch. Please take a look and if it's ok for you, send you S-o-b tag so that I can apply it (it was missing).
This part has some grammar issues, it seems to say that the failure is due to changed bssid. Maybe make it instead:
Failed to add peer %pM for vdev %d when changing bssid, error: %i
drivers/net/wireless/ath/ath10k/mac.c +2
-2-ath10k_warn ("Failed to add peer: %pM for VDEV: %d\n" , - info->bssid, arvif->vdev_id); +ath10k_warn ("Failed to add peer %pM for vdev %d due to changed bssid: %i\n" , + info->bssid, arvif->vdev_id, ret);
Quoted 9 lines
Quoted 3 lines
Either way, it's better than what was there before, so:
Signed-off-by Ben Greear <[email protected]>Good point, thanks. I just didn't use the word error as I thought that wasn't necessary. New version which I'll apply soon:
https://github.com/kvalo/ath/commit/ee309046323f2af1d2cd6f5c1361a6ce8dae5f87
Looks good.
Thanks,
Ben
Signature · 8 lines
Ben Greear <[email protected]> Candela Technologies Inc http://www.candelatech.com _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
Kalle Valo
AppliedThanks, applied with these changes:
commit 479398b07048342c7fdca89fd3a6cdb739e48a86
Author: Ben Greear <[email protected]> Date: Mon Nov 4 09:19:34 2013 -0800
ath10k: add logging to better determine some VIF/STA creation failures
Not all errors were properly notified, fix that.
kvalo: use ath10k_warn() for all messages, cosmetic changes to some of the messages
Signature · 6 lines
Kalle Valo _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k