Skip to contentSkip to conversation

media: marvell-ccic: drop resource free in driver remove

PATCH In review lbyang 2 participants 2 messages Nov 5, 2013 Media (V4L/DVB)

lore
Share & tools
lore

lbyang

author
#0 lore raw

PATCH 1/1 media: marvell-ccic: drop resource free in driver remove

From: Libin Yang <[email protected]>
Date: Tue, 5 Nov 2013 10:18:15 +0800
Subject: [PATCH] marvell-ccic: drop resource free in driver remove

The mmp-driver is using devm_* to allocate the resource. The old resource release methods are not appropriate here.

---
 drivers/media/platform/marvell-ccic/mmp-driver.c |    7 -------
 1 file changed, 7 deletions(-)
(quoted diff) +0 -0

b/drivers/media/platform/marvell-ccic/mmp-driver.c index 3458fa0..70cb57f 100644

drivers/media/platform/marvell-ccic/mmp-driver.c +0 -7
@@ -478,18 +478,11 @@ out_deinit_clk:
 static int mmpcam_remove(struct mmp_camera *cam)
 {
 	struct mcam_camera *mcam = &cam->mcam;
-	struct mmp_camera_platform_data *pdata;
 
 	mmpcam_remove_device(cam);
 	mccic_shutdown(mcam);
 	mmpcam_power_down(mcam);
-	pdata = cam->pdev->dev.platform_data;
-	gpio_free(pdata->sensor_reset_gpio);
-	gpio_free(pdata->sensor_power_gpio);
 	mcam_deinit_clk(mcam);
-	iounmap(cam->power_regs);
-	iounmap(mcam->regs);
-	kfree(cam);
 	return 0;
 }
 
Signature · 1 line
1.7.9.5