Skip to contentSkip to conversation

Bluetooth: Fix rejecting SMP security request in slave role

PATCH In review [email protected] 2 participants 2 messages Nov 5, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Bluetooth: Fix rejecting SMP security request in slave role

From: Johan Hedberg <[email protected]>

The SMP security request is for a slave role device to request the master role device to initiate a pairing request. If we receive this command while we're in the slave role we should reject it appropriately.

---
 net/bluetooth/smp.c | 3 +++
 1 file changed, 3 insertions(+)
net/bluetooth/smp.c +3 -0
index 85a2796cac61..4b07acb8293c 100644
@@ -742,6 +742,9 @@ static u8 smp_cmd_security_req(struct l2cap_conn *conn, struct sk_buff *skb)
 
 	BT_DBG("conn %p", conn);
 
+	if (!(conn->hcon->link_mode & HCI_LM_MASTER))
+		return SMP_CMD_NOTSUPP;
+
 	hcon->pending_sec_level = authreq_to_seclevel(rp->auth_req);
 
 	if (smp_ltk_encrypt(conn, hcon->pending_sec_level))
Signature · 1 line
1.8.3.1
maintainer
#1 lore raw

Hi Johan,

Quoted 8 lines

The SMP security request is for a slave role device to request the master role device to initiate a pairing request. If we receive this command while we're in the slave role we should reject it appropriately.

---
net/bluetooth/smp.c | 3 +++

1 file changed, 3 insertions(+)

patch has been applied to bluetooth-next tree.

Regards

Marcel