Skip to contentSkip to conversation

ARM: dts: voipac: Improve fixed voltage regulator definition

PATCH New Rostislav Lisovy 2 participants 2 messages Nov 5, 2013 – Nov 6, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: voipac: Improve fixed voltage regulator definition

---
 arch/arm/boot/dts/imx53-voipac-dmm-668.dtsi |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
arch/arm/boot/dts/imx53-voipac-dmm-668.dtsi +4 -1
index a7d03ad..4f1d8fa 100644
@@ -27,9 +27,12 @@
 
 	regulators {
 		compatible = "simple-bus";
+		#address-cells = <1>;
+		#size-cells = <0>;
 
-		reg_3p3v: 3p3v {
+		reg_3p3v: regulator at 0 {
 			compatible = "regulator-fixed";
+			reg = <0>;
 			regulator-name = "3P3V";
 			regulator-min-microvolt = <3300000>;
 			regulator-max-microvolt = <3300000>;
Signature · 1 line
1.7.10.4
Applied
#1 lore raw

PATCH 1/1 ARM: dts: voipac: Improve fixed voltage regulator definition

Quoted 10 lines · Rostislav Lisovy
---
 arch/arm/boot/dts/imx53-voipac-dmm-668.dtsi |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
arch/arm/boot/dts/imx53-voipac-dmm-668.dtsi +0 -0
index a7d03ad..4f1d8fa 100644

arch/arm/boot/dts/imx53-voipac-dmm-668.dtsi line 33

Quoted 8 lines
arch/arm/boot/dts/imx53-voipac-dmm-668.dtsi +3 -1
@@ -27,9 +27,12 @@
 
 	regulators {
 		compatible = "simple-bus";
+		#address-cells = <1>;
+		#size-cells = <0>;
 
-		reg_3p3v: 3p3v {
+		reg_3p3v: regulator at 0 {

Yeah, instead of using arbitrary node name, the generic regulator at num is more preferable. I will make this change to the rest of IMX dts files.

Applied, thanks.

Shawn

Quoted 8 lines
arch/arm/boot/dts/imx53-voipac-dmm-668.dtsi +1 -0
 			compatible = "regulator-fixed";
+			reg = <0>;
 			regulator-name = "3P3V";
 			regulator-min-microvolt = <3300000>;
 			regulator-max-microvolt = <3300000>;
Signature · 1 line
1.7.10.4