sendfile: add SF_Server into INSTALL_TARGETS in Makefile

PATCH In review Simon Xu 2 participants 4 messages Nov 6, 2013 – Nov 11, 2013

lore

Share & tools

lore

Simon Xu

author

2013-11-06 06:33 UTC #0 lore raw

PATCH 1/1 sendfile: add SF_Server into INSTALL_TARGETS in Makefile

sendfile01 always fails because SF_Server file is not installed.

Signed-off-by Simon Xu <[email protected]>

---
 testcases/network/tcp_cmds/sendfile/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

testcases/network/tcp_cmds/sendfile/Makefile +1 -1

index 124ce5d..17a985a 100644
@@ -27,7 +27,7 @@ include $(abs_srcdir)/../Makefile.inc
 
 CPPFLAGS		+= -I$(abs_srcdir)/../include
 
-INSTALL_TARGETS		:= sendfile01
+INSTALL_TARGETS		:= sendfile01 SF_Server
 
 MAKE_TARGETS		+= testsf_c testsf_s testsf_c6 testsf_s6

Signature · 13 lines

1.8.4.2


------------------------------------------------------------------------------
November Webinars for C, C++, Fortran Developers
Accelerate application performance with scalable programming models. Explore
techniques for threading, error checking, porting, and tuning. Get the most 
from the latest Intel processors and coprocessors. See abstracts and register
http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

[email protected]

2013-11-07 16:20 UTC #1 lore raw

Hi!

Quoted 12 lines

sendfile01 always fails because SF_Server file is not installed.
Signed-off-by Simon Xu <[email protected]>
---
 testcases/network/tcp_cmds/sendfile/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
testcases/network/tcp_cmds/sendfile/Makefile +0 -0
index 124ce5d..17a985a 100644

testcases/network/tcp_cmds/sendfile/Makefile include $(abs_srcdir)/../Makefile.inc · line 30

Quoted 5 lines

testcases/network/tcp_cmds/sendfile/Makefile +1 -1

@@ -27,7 +27,7 @@ include $(abs_srcdir)/../Makefile.inc
 
 CPPFLAGS		+= -I$(abs_srcdir)/../include
 
-INSTALL_TARGETS		:= sendfile01
+INSTALL_TARGETS		:= sendfile01 SF_Server

Good catch, but can you please rename the file to sendfile01_server and fix the execution accordingly before it gets applied?

Note that all the test binaries are installed into one directory which makes it harder to avoid collisions and figure out what belongs to what...

Signature · 13 lines

Cyril Hrubis
[email protected]

------------------------------------------------------------------------------
November Webinars for C, C++, Fortran Developers
Accelerate application performance with scalable programming models. Explore
techniques for threading, error checking, porting, and tuning. Get the most 
from the latest Intel processors and coprocessors. See abstracts and register
http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Simon Xu

author

2013-11-08 02:47 UTC #2 lore raw

PATCH 1/1 sendfile01: rename SF_Server to sendfile01_server and add it into Makefile

1) Rename SF_Server to sendfile01_server to avoid collisions
2) The test always fails because SF_Server is not installed, add sendfile01_server into sendfile01 makefile to install it.

Signed-off-by Simon Xu <[email protected]>

---
 testcases/network/tcp_cmds/sendfile/Makefile          | 2 +-
 testcases/network/tcp_cmds/sendfile/SF_Server         | 6 ------
 testcases/network/tcp_cmds/sendfile/sendfile01        | 2 +-
 testcases/network/tcp_cmds/sendfile/sendfile01_server | 6 ++++++
 4 files changed, 8 insertions(+), 8 deletions(-)
 delete mode 100755 testcases/network/tcp_cmds/sendfile/SF_Server
 create mode 100755 testcases/network/tcp_cmds/sendfile/sendfile01_server

testcases/network/tcp_cmds/sendfile/Makefile +1 -1

index 124ce5d..a8b0736 100644
@@ -27,7 +27,7 @@ include $(abs_srcdir)/../Makefile.inc
 
 CPPFLAGS		+= -I$(abs_srcdir)/../include
 
-INSTALL_TARGETS		:= sendfile01
+INSTALL_TARGETS		:= sendfile01 sendfile01_server
 
 MAKE_TARGETS		+= testsf_c testsf_s testsf_c6 testsf_s6

testcases/network/tcp_cmds/sendfile/SF_Server deleted +0 -6

deleted file mode 100755
index 2383ce4..0000000
@@ -1,6 +0,0 @@
-#!/bin/sh
-#set -x
-cd $3
-exec 1< /dev/null       # open descriptor 1
-exec 2< /dev/null       # open descriptor 1
-nohup ./testsf_s $1 $2 &

testcases/network/tcp_cmds/sendfile/sendfile01 +1 -1

index 46b90e2..ba61873 100755
@@ -84,7 +84,7 @@ do_test()
 
     mkdir -p $TCtmp
     PORT=$$
-    if ! rsh -l root $IPADDR "$LTPROOT/testcases/bin/SF_Server $IPADDR $PORT $LTPROOT/testcases/bin $SERVER"; then
+    if ! rsh -l root $IPADDR "$LTPROOT/testcases/bin/sendfile01_server $IPADDR $PORT $LTPROOT/testcases/bin $SERVER"; then
         end_testcase "rsh failed to $IPADDR as root failed"
     fi
     sleep 10

testcases/network/tcp_cmds/sendfile/sendfile01_server new file +6 -0

new file mode 100755
index 0000000..2383ce4
@@ -0,0 +1,6 @@
+#!/bin/sh
+#set -x
+cd $3
+exec 1< /dev/null       # open descriptor 1
+exec 2< /dev/null       # open descriptor 1
+nohup ./testsf_s $1 $2 &

Signature · 13 lines

1.8.4.2


------------------------------------------------------------------------------
November Webinars for C, C++, Fortran Developers
Accelerate application performance with scalable programming models. Explore
techniques for threading, error checking, porting, and tuning. Get the most 
from the latest Intel processors and coprocessors. See abstracts and register
http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

[email protected]

2013-11-11 17:22 UTC #3 lore raw

Re: [LTP] [PATCH] sendfile01: rename SF_Server to sendfile01_server and add it into Makefile

Hi!

Quoted 5 lines

1) Rename SF_Server to sendfile01_server to avoid collisions
2) The test always fails because SF_Server is not installed, add sendfile01_server into sendfile01 makefile to install it.
Signed-off-by Simon Xu <[email protected]>

Pushed, thanks.

Signature · 13 lines

Cyril Hrubis
[email protected]

------------------------------------------------------------------------------
November Webinars for C, C++, Fortran Developers
Accelerate application performance with scalable programming models. Explore
techniques for threading, error checking, porting, and tuning. Get the most 
from the latest Intel processors and coprocessors. See abstracts and register
http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list