Skip to contentSkip to conversation

libevas: disable on avr32

PATCH New spdawson at gmail.com 2 participants 5 messages Nov 6, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libevas: disable on avr32

From: Simon Dawson <[email protected]>

Neither epoll_create1 nor inotify_init1 is available on avr32. Fixes build failures such as the following.

http://autobuild.buildroot.net/results/4d435a5fc608936362d605aca696c01023be9723

---
 package/efl/expedite/Config.in      | 2 ++
 package/efl/libecore/Config.in      | 2 ++
 package/efl/libedje/Config.in       | 2 ++
 package/efl/libelementary/Config.in | 2 ++
 package/efl/libethumb/Config.in     | 2 ++
 package/efl/libevas/Config.in       | 1 +
 package/enlightenment/Config.in     | 2 ++
 7 files changed, 13 insertions(+)
package/efl/expedite/Config.in +2 -0
index 466fd7d..5f6e97f 100644
@@ -4,6 +4,8 @@ config BR2_PACKAGE_EXPEDITE
 	select BR2_PACKAGE_LIBEVAS
 	select BR2_PACKAGE_LIBEET
 	depends on BR2_INSTALL_LIBSTDCPP
+	# libevas
+	depends on !BR2_avr32
 	help
 	  Expedite is the official Evas benchmark tool. It can test different
 	  engines, such as X11, XRender, OpenGL (also ES variant), SDL,
package/efl/libecore/Config.in +2 -0
index 6c887f5..77b5283 100644
@@ -38,5 +38,7 @@ config BR2_PACKAGE_LIBECORE_X_XCB
 config BR2_PACKAGE_LIBECORE_EVAS
 	bool "libecore Evas support"
 	select BR2_PACKAGE_LIBEVAS
+	# libevas
+	depends on !BR2_avr32
 
 endif # BR2_PACKAGE_LIBECORE
package/efl/libedje/Config.in +2 -0
index f0985dd..d142268 100644
@@ -7,6 +7,8 @@ config BR2_PACKAGE_LIBEDJE
 	select BR2_PACKAGE_LIBEMBRYO
 	select BR2_PACKAGE_LIBEVAS
 	select BR2_PACKAGE_LUA
+	# libevas
+	depends on !BR2_avr32
 	help
 	  A graphical layout and animation library for animated
 	  resizable, compressed and scalable themes.
package/efl/libelementary/Config.in +2 -0
index 59af80e..c43d80d 100644
@@ -4,6 +4,8 @@ config BR2_PACKAGE_LIBELEMENTARY
 	select BR2_PACKAGE_LIBEVAS
 	select BR2_PACKAGE_LIBECORE
 	select BR2_PACKAGE_LIBEDJE
+	# libevas
+	depends on !BR2_avr32
 	help
 	  Elementary is a widget toolkit and EFL wrapper and convenience
 	  library to make it easy to build applications and tools with UIs
package/efl/libethumb/Config.in +2 -0
index fb0032a..e85aa1d 100644
@@ -5,6 +5,8 @@ config BR2_PACKAGE_LIBETHUMB
 	select BR2_PACKAGE_LIBECORE
 	select BR2_PACKAGE_LIBECORE_EVAS
 	select BR2_PACKAGE_LIBEDJE
+	# libevas
+	depends on !BR2_avr32
 	help
 	  Ethumb is a library for generating thumbnail images of documents.
 
package/efl/libevas/Config.in +1 -0
index f73376b..8c4193f 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_LIBEVAS
 	bool "libevas"
+	depends on !BR2_avr32 # no epoll_create1 or inotify_init1
 	select BR2_PACKAGE_FREETYPE
 	select BR2_PACKAGE_LIBEINA
 	# required to build so far
package/enlightenment/Config.in +2 -0
index 54c0ac6..5ec85a5 100644
@@ -26,6 +26,8 @@ config BR2_PACKAGE_ENLIGHTENMENT
 	# libedbus -> dbus
 	depends on BR2_USE_MMU
 	depends on BR2_PACKAGE_XORG7
+	# libevas
+	depends on !BR2_avr32
 	help
 	  Enlightenment, also known simply as E, is a stacking window
 	  manager for the X Window System which can be used alone or
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/1 libevas: disable on avr32

Quoted 98 lines · On Wed, Nov 6, 2013 at 11:54 AM, <[email protected]> wrote:

From: Simon Dawson <[email protected]>

Neither epoll_create1 nor inotify_init1 is available on avr32. Fixes build failures such as the following.

http://autobuild.buildroot.net/results/4d435a5fc608936362d605aca696c01023be9723

---
 package/efl/expedite/Config.in      | 2 ++
 package/efl/libecore/Config.in      | 2 ++
 package/efl/libedje/Config.in       | 2 ++
 package/efl/libelementary/Config.in | 2 ++
 package/efl/libethumb/Config.in     | 2 ++
 package/efl/libevas/Config.in       | 1 +
 package/enlightenment/Config.in     | 2 ++
 7 files changed, 13 insertions(+)
package/efl/expedite/Config.in +2 -0
index 466fd7d..5f6e97f 100644
@@ -4,6 +4,8 @@ config BR2_PACKAGE_EXPEDITE
        select BR2_PACKAGE_LIBEVAS
        select BR2_PACKAGE_LIBEET
        depends on BR2_INSTALL_LIBSTDCPP
+       # libevas
+       depends on !BR2_avr32
        help
          Expedite is the official Evas benchmark tool. It can test different
          engines, such as X11, XRender, OpenGL (also ES variant), SDL,
package/efl/libecore/Config.in +2 -0
index 6c887f5..77b5283 100644
@@ -38,5 +38,7 @@ config BR2_PACKAGE_LIBECORE_X_XCB
 config BR2_PACKAGE_LIBECORE_EVAS
        bool "libecore Evas support"
        select BR2_PACKAGE_LIBEVAS
+       # libevas
+       depends on !BR2_avr32
 
 endif # BR2_PACKAGE_LIBECORE
package/efl/libedje/Config.in +2 -0
index f0985dd..d142268 100644
@@ -7,6 +7,8 @@ config BR2_PACKAGE_LIBEDJE
        select BR2_PACKAGE_LIBEMBRYO
        select BR2_PACKAGE_LIBEVAS
        select BR2_PACKAGE_LUA
+       # libevas
+       depends on !BR2_avr32
        help
          A graphical layout and animation library for animated
          resizable, compressed and scalable themes.
package/efl/libelementary/Config.in +2 -0
index 59af80e..c43d80d 100644
@@ -4,6 +4,8 @@ config BR2_PACKAGE_LIBELEMENTARY
        select BR2_PACKAGE_LIBEVAS
        select BR2_PACKAGE_LIBECORE
        select BR2_PACKAGE_LIBEDJE
+       # libevas
+       depends on !BR2_avr32
        help
          Elementary is a widget toolkit and EFL wrapper and convenience
          library to make it easy to build applications and tools with UIs
package/efl/libethumb/Config.in +2 -0
index fb0032a..e85aa1d 100644
@@ -5,6 +5,8 @@ config BR2_PACKAGE_LIBETHUMB
        select BR2_PACKAGE_LIBECORE
        select BR2_PACKAGE_LIBECORE_EVAS
        select BR2_PACKAGE_LIBEDJE
+       # libevas
+       depends on !BR2_avr32
        help
          Ethumb is a library for generating thumbnail images of documents.
 
package/efl/libevas/Config.in +1 -0
index f73376b..8c4193f 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_LIBEVAS
        bool "libevas"
+       depends on !BR2_avr32 # no epoll_create1 or inotify_init1
        select BR2_PACKAGE_FREETYPE
        select BR2_PACKAGE_LIBEINA
        # required to build so far
package/enlightenment/Config.in +0 -0
index 54c0ac6..5ec85a5 100644

package/enlightenment/Config.in config BR2_PACKAGE_ENLIGHTENMENT

Quoted 9 lines
package/enlightenment/Config.in +2 -1
@@ -26,6 +26,8 @@ config BR2_PACKAGE_ENLIGHTENMENT
        # libedbus -> dbus
        depends on BR2_USE_MMU
        depends on BR2_PACKAGE_XORG7
+       # libevas
+       depends on !BR2_avr32
        help
          Enlightenment, also known simply as E, is a stacking window
          manager for the X Window System which can be used alone or
--

In all these places, the new 'depends on' should be repeated on the comment that is shown when one of the toolchain options is missing.

Regarding the structure:

       # libevas
       depends on !BR2_avr32

I find it more clear to use:
depends on !BR2_avr32 # libevas

Best regards,
Thomas

#2 lore raw

PATCH 1/1 libevas: disable on avr32

Hi Thomas, thanks for the feedback.

Quoted 2 lines · Thomas De Schampheleire

In all these places, the new 'depends on' should be repeated on the comment that is shown when one of the toolchain options is missing.

Okay. I thought the policy was not to mention architecture dependencies on the comments...

Quoted 6 lines

Regarding the structure:

       # libevas
       depends on !BR2_avr32

I find it more clear to use:
depends on !BR2_avr32 # libevas

Okay. I'll tidy this up.

Simon.

#3 lore raw

PATCH 1/1 libevas: disable on avr32

Hi Simon,

Quoted 10 lines · Simon Dawson

Hi Thomas, thanks for the feedback.

Quoted 2 lines · Thomas De Schampheleire

In all these places, the new 'depends on' should be repeated on the comment that is shown when one of the toolchain options is missing.

Okay. I thought the policy was not to mention architecture dependencies on the comments...

This is still correct, the comment should not mention the architecture dependency.
But, the comment should only be _visible_ when it is relevant. Since the package itself is not relevant on avr32, it makes no sense to show the comment. Hence, the comment should get an extra 'depends on !avr32'.

Best regards,
Thomas

#4 lore raw

PATCH 1/1 libevas: disable on avr32

Quoted 6 lines · Thomas De Schampheleire

This is still correct, the comment should not mention the architecture dependency.
But, the comment should only be _visible_ when it is relevant. Since the package itself is not relevant on avr32, it makes no sense to show the comment. Hence, the comment should get an extra 'depends on !avr32'.

Okay, I understand. Thanks for the clarification.

Simon.