connman: disable on avr32
PATCH v2 1/1 connman: disable on avr32
From: Simon Dawson <[email protected]>
The inotify_init1 syscall is not available on avr32. Fixes build failures such as the following.
http://autobuild.buildroot.net/results/0d8/0d8e7bd8bd3f227fabfb0d5feb59a5d316026d3f
---
v2: Disable comment on avr32, as suggested by Thomas De Schampheleire
package/connman/Config.in | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
package/connman/Config.in +3 -1
@@ -4,6 +4,7 @@ config BR2_PACKAGE_CONNMAN select BR2_PACKAGE_LIBGLIB2 select BR2_PACKAGE_IPTABLES select BR2_PACKAGE_GNUTLS + depends on !BR2_avr32 # no inotify_init1 depends on !BR2_UCLIBC_VERSION_0_9_32 depends on BR2_USE_WCHAR # libglib2 and gnutls depends on BR2_INET_IPV6
@@ -50,5 +51,6 @@ config BR2_PACKAGE_CONNMAN_CLIENT endif # BR2_PACKAGE_CONNMAN comment "connman needs a toolchain w/ IPv6, wchar, threads, resolver" - depends on BR2_UCLIBC_VERSION_0_9_32 || \ + depends on !BR2_avr32 && \ + BR2_UCLIBC_VERSION_0_9_32 || \ !BR2_USE_WCHAR || !BR2_INET_IPV6 || !BR2_TOOLCHAIN_HAS_THREADS
Signature · 1 line
1.8.3.2
PATCH v2 1/1 connman: disable on avr32
Hi Simon,
Quoted 27 lines · On Wed, Nov 6, 2013 at 2:08 PM, <[email protected]> wrote:
From: Simon Dawson <[email protected]>
The
inotify_init1syscall is not available on avr32. Fixes build failures such as the following.http://autobuild.buildroot.net/results/0d8/0d8e7bd8bd3f227fabfb0d5feb59a5d316026d3f
Signed-off-by Simon Dawson <[email protected]>---
v2: Disable comment on avr32, as suggested by Thomas De Schampheleirepackage/connman/Config.in | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)package/connman/Config.in +1
-0@@ -4,6 +4,7 @@ config BR2_PACKAGE_CONNMAN select BR2_PACKAGE_LIBGLIB2 select BR2_PACKAGE_IPTABLES select BR2_PACKAGE_GNUTLS + depends on !BR2_avr32 # no inotify_init1 depends on !BR2_UCLIBC_VERSION_0_9_32 depends on BR2_USE_WCHAR # libglib2 and gnutls depends on BR2_INET_IPV6
package/connman/Config.in config BR2_PACKAGE_CONNMAN_CLIENT · line 56
Quoted 7 lines
package/connman/Config.in +2
-1@@ -50,5 +51,6 @@ config BR2_PACKAGE_CONNMAN_CLIENT endif # BR2_PACKAGE_CONNMAN comment "connman needs a toolchain w/ IPv6, wchar, threads, resolver" - depends on BR2_UCLIBC_VERSION_0_9_32 || \ + depends on !BR2_avr32 && \ + BR2_UCLIBC_VERSION_0_9_32 || \ !BR2_USE_WCHAR || !BR2_INET_IPV6 || !BR2_TOOLCHAIN_HAS_THREADS
In my patches
http://patchwork.ozlabs.org/patch/288125/
http://patchwork.ozlabs.org/patch/288250/
I have used two separate depends on statements, to separate the base dependencies (that are common for the comment and its corresponding config) from the toolchain options (that are the inverse on the comment compared to the config option).
So in case of connman this would be:
comment "connman needs a toolchain w/ IPv6, wchar, threads, resolver"
depends on !BR2_avr32
depends on BR2_UCLIBC_VERSION_0_9_32 || \
!BR2_USE_WCHAR || !BR2_INET_IPV6 || !BR2_TOOLCHAIN_HAS_THREADSBest regards,
Thomas
PATCH v2 1/1 connman: disable on avr32
Hi Thomas,
Quoted 9 lines · Thomas De Schampheleire
In my patches
http://patchwork.ozlabs.org/patch/288125/
http://patchwork.ozlabs.org/patch/288250/I have used two separate depends on statements, to separate the base dependencies (that are common for the comment and its corresponding config) from the toolchain options (that are the inverse on the comment compared to the config option).
Quoted 5 lines
So in case of connman this would be:
comment "connman needs a toolchain w/ IPv6, wchar, threads, resolver"depends on !BR2_avr32 depends on BR2_UCLIBC_VERSION_0_9_32 || \ !BR2_USE_WCHAR || !BR2_INET_IPV6 || !BR2_TOOLCHAIN_HAS_THREADS
Okay. Thanks for the feedback; will fix my patch and resubmit.
Simon.