Skip to contentSkip to conversation

ARM: support for Trusted Foundations secure monitor

PATCH Superseded Alexandre Courbot 5 participants 21 messages Nov 7, 2013 – Nov 21, 2013

Subsystems (4)

v10 of 11 Superseded Latest is v11 →

lore
Share & tools
lore
#0 lore raw

v10 cover ARM: support for Trusted Foundations secure monitor

Just a set of small fixes to address the concerns expressed on v9 with the non-prefixed version DT properties. I hope there won't be a need for an eleventh (!) version. :P

Changelog from v9:
- Renamed tl vendor prefix to tlm (for Trusted Logic Mobility)
- Prefixed version properties with "tlm,"
- Split the DT bindings patches as per new recommendations

Alexandre Courbot (7):
ARM: add basic support for Trusted Foundations
of: add vendor prefix for Trusted Logic Mobility
of: add Trusted Foundations bindings
ARM: tegra: add support for Trusted Foundations
ARM: tegra: split setting of CPU reset handler
ARM: tegra: set CPU reset handler with firmware op
ARM: tegra: support Trusted Foundations by default

 .../arm/firmware/tlm,trusted-foundations.txt       | 20 ++++++
 Documentation/devicetree/bindings/arm/tegra.txt    |  5 ++
 .../devicetree/bindings/vendor-prefixes.txt        |  1 +
 arch/arm/Kconfig                                   |  2 +
 arch/arm/Makefile                                  |  1 +
 arch/arm/configs/tegra_defconfig                   |  1 +
 arch/arm/firmware/Kconfig                          | 28 ++++++++
 arch/arm/firmware/Makefile                         |  1 +
 arch/arm/firmware/trusted_foundations.c            | 81 ++++++++++++++++++++++
 arch/arm/include/asm/trusted_foundations.h         | 67 ++++++++++++++++++
 arch/arm/mach-tegra/Kconfig                        |  1 +
 arch/arm/mach-tegra/common.c                       |  2 +
 arch/arm/mach-tegra/reset.c                        | 40 ++++++++---
 13 files changed, 239 insertions(+), 11 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/arm/firmware/tlm,trusted-foundations.txt
 create mode 100644 arch/arm/firmware/Kconfig
 create mode 100644 arch/arm/firmware/Makefile
 create mode 100644 arch/arm/firmware/trusted_foundations.c
 create mode 100644 arch/arm/include/asm/trusted_foundations.h
Signature · 1 line
1.8.4.2
#1 lore raw

PATCH v10 1/7 ARM: add basic support for Trusted Foundations

Trusted Foundations is a TrustZone-based secure monitor for ARM that can be invoked using the same SMC-based API on all supported platforms. This patch adds initial basic support for Trusted Foundations using the ARM firmware API. Current features are limited to the ability to boot secondary processors.

Note: The API followed by Trusted Foundations does *not* follow the SMC calling conventions. It has nothing to do with PSCI neither and is only relevant to devices that use Trusted Foundations (like most Tegra-based retail devices).

---
 arch/arm/Kconfig                           |  2 +
 arch/arm/Makefile                          |  1 +
 arch/arm/firmware/Kconfig                  | 28 +++++++++++
 arch/arm/firmware/Makefile                 |  1 +
 arch/arm/firmware/trusted_foundations.c    | 81 ++++++++++++++++++++++++++++++
 arch/arm/include/asm/trusted_foundations.h | 67 ++++++++++++++++++++++++
 6 files changed, 180 insertions(+)
 create mode 100644 arch/arm/firmware/Kconfig
 create mode 100644 arch/arm/firmware/Makefile
 create mode 100644 arch/arm/firmware/trusted_foundations.c
 create mode 100644 arch/arm/include/asm/trusted_foundations.h
arch/arm/Kconfig +2 -0
index 1ad6fb6c094d..bf14cec7777c 100644
@@ -1076,6 +1076,8 @@ config ARM_TIMER_SP804
 	select CLKSRC_MMIO
 	select CLKSRC_OF if OF
 
+source "arch/arm/firmware/Kconfig"
+
 source arch/arm/mm/Kconfig
 
 config ARM_NR_BANKS
arch/arm/Makefile +1 -0
index db50b626be98..f9a8e93a9ee2 100644
@@ -268,6 +268,7 @@ core-$(CONFIG_KVM_ARM_HOST) 	+= arch/arm/kvm/
 core-y				+= arch/arm/kernel/ arch/arm/mm/ arch/arm/common/
 core-y				+= arch/arm/net/
 core-y				+= arch/arm/crypto/
+core-y				+= arch/arm/firmware/
 core-y				+= $(machdirs) $(platdirs)
 
 drivers-$(CONFIG_OPROFILE)      += arch/arm/oprofile/
arch/arm/firmware/Kconfig new file +28 -0
new file mode 100644
index 000000000000..bb00ccf00d66
@@ -0,0 +1,28 @@
+config ARCH_SUPPORTS_FIRMWARE
+	bool
+
+config ARCH_SUPPORTS_TRUSTED_FOUNDATIONS
+	bool
+	select ARCH_SUPPORTS_FIRMWARE
+
+menu "Firmware options"
+	depends on ARCH_SUPPORTS_FIRMWARE
+
+config TRUSTED_FOUNDATIONS
+	bool "Trusted Foundations secure monitor support"
+	depends on ARCH_SUPPORTS_TRUSTED_FOUNDATIONS
+	help
+	  Some devices (including most Tegra-based consumer devices on the
+	  market) are booted with the Trusted Foundations secure monitor
+	  active, requiring some core operations to be performed by the secure
+	  monitor instead of the kernel.
+
+	  This option allows the kernel to invoke the secure monitor whenever
+	  required on devices using Trusted Foundations. See
+	  arch/arm/include/asm/trusted_foundations.h or the
+	  tl,trusted-foundations device tree binding documentation for details
+	  on how to use it.
+
+	  Say n if you don't know what this is about.
+
+endmenu
arch/arm/firmware/Makefile new file +1 -0
new file mode 100644
index 000000000000..a71f16536b6c
@@ -0,0 +1 @@
+obj-$(CONFIG_TRUSTED_FOUNDATIONS)	+= trusted_foundations.o
arch/arm/firmware/trusted_foundations.c new file +81 -0

81 lines not on this page · raw message

arch/arm/include/asm/trusted_foundations.h new file +67 -0

67 lines not on this page · raw message

Signature · 1 line
1.8.4.2
#2 lore raw

PATCH v10 2/7 of: add vendor prefix for Trusted Logic Mobility

In reply to Alexandre Courbot

Add the "tlm" prefix for Trusted Logic Mobility.

---
 Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/vendor-prefixes.txt +1 -0
index 2956800f0240..d4d42aa9f2fa 100644
@@ -66,6 +66,7 @@ ste	ST-Ericsson
 stericsson	ST-Ericsson
 toumaz	Toumaz
 ti	Texas Instruments
+tlm	Trusted Logic Mobility
 toshiba	Toshiba Corporation
 v3	V3 Semiconductor
 via	VIA Technologies, Inc.
Signature · 1 line
1.8.4.2
#3 lore raw

PATCH v10 3/7 of: add Trusted Foundations bindings

In reply to Alexandre Courbot

Add the Device Tree bindings for the Trusted Foundation secure monitor.

---
 .../arm/firmware/tlm,trusted-foundations.txt         | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/firmware/tlm,trusted-foundations.txt
Documentation/devicetree/bindings/arm/firmware/tlm,trusted-foundations.txt new file +20 -0
new file mode 100644
index 000000000000..adb471c3d2dc
@@ -0,0 +1,20 @@
+Trusted Foundations
+-------------------
+
+Boards that use the Trusted Foundations secure monitor can signal its
+presence by declaring a node compatible with "tlm,trusted-foundations"
+under the /firmware/ node
+
+Required properties:
+- compatible : "tlm,trusted-foundations"
+- tlm,version-major : major version number of Trusted Foundations firmware
+- tlm,version-minor: minor version number of Trusted Foundations firmware
+
+Example:
+	firmware {
+		trusted-foundations {
+			compatible = "tlm,trusted-foundations";
+			tlm,version-major = <2>;
+			tlm,version-minor = <8>;
+		};
+	};
Signature · 1 line
1.8.4.2
#4 lore raw

PATCH v10 4/7 ARM: tegra: add support for Trusted Foundations

In reply to Alexandre Courbot

Register the firmware operations for Trusted Foundations if the device tree indicates it is active on the device.

---
 Documentation/devicetree/bindings/arm/tegra.txt | 5 +++++
 arch/arm/mach-tegra/Kconfig                     | 1 +
 arch/arm/mach-tegra/common.c                    | 2 ++
 3 files changed, 8 insertions(+)
Documentation/devicetree/bindings/arm/tegra.txt +5 -0
index ed9c85334436..558ed4b4ef39 100644
@@ -32,3 +32,8 @@ board-specific compatible values:
   nvidia,whistler
   toradex,colibri_t20-512
   toradex,iris
+
+Trusted Foundations
+-------------------------------------------
+Tegra supports the Trusted Foundation secure monitor. See the
+"tlm,trusted-foundations" binding's documentation for more details.
arch/arm/mach-tegra/Kconfig +1 -0
index 67a76f2dfb9f..4e512782ea23 100644
@@ -2,6 +2,7 @@ config ARCH_TEGRA
 	bool "NVIDIA Tegra" if ARCH_MULTI_V7
 	select ARCH_HAS_CPUFREQ
 	select ARCH_REQUIRE_GPIOLIB
+	select ARCH_SUPPORTS_TRUSTED_FOUNDATIONS
 	select ARM_GIC
 	select CLKDEV_LOOKUP
 	select CLKSRC_MMIO
arch/arm/mach-tegra/common.c +2 -0
index 94a119a35af8..b405e4594cb5 100644
@@ -27,6 +27,7 @@
 #include <linux/clk-provider.h>
 
 #include <asm/hardware/cache-l2x0.h>
+#include <asm/trusted_foundations.h>
 
 #include "board.h"
 #include "common.h"
@@ -99,6 +100,7 @@ static void __init tegra_init_cache(void)
 
 void __init tegra_init_early(void)
 {
+	of_register_trusted_foundations();
 	tegra_cpu_reset_handler_init();
 	tegra_apb_io_init();
 	tegra_init_fuse();
Signature · 1 line
1.8.4.2
#5 lore raw

Re: [PATCH v10 4/7] ARM: tegra: add support for Trusted Foundations

arch/arm/mach-tegra/common.c static void __init tegra_init_cache(void) · line 106

Quoted 11 lines · Alexandre Courbot

Register the firmware operations for Trusted Foundations if the device tree indicates it is active on the device.

arch/arm/mach-tegra/common.c +1 -0
 
 void __init tegra_init_early(void)
 {
+	of_register_trusted_foundations();
 	tegra_cpu_reset_handler_init();
 	tegra_apb_io_init();
 	tegra_init_fuse();

Your other bugfix patch for 3.13 moved tegra_cpu_reset_handler_init(). Should the call to of_register_trusted_foundations() move with it when this is applied, or should it just stay right at the start of tegra_init_early()? Either way is fine; just let me know which way to fix up the conflict when this gets applied.

#6 lore raw

Re: [PATCH v10 4/7] ARM: tegra: add support for Trusted Foundations

Quoted 6 lines · Stephen Warren
Quoted 4 lines · Alexandre Courbot

Register the firmware operations for Trusted Foundations if the device tree indicates it is active on the device.

arch/arm/mach-tegra/common.c +0 -0
Quoted 12 lines

arch/arm/mach-tegra/common.c static void __init tegra_init_cache(void) · line 106

Quoted 6 lines
  void __init tegra_init_early(void)
  {
arch/arm/mach-tegra/common.c +1 -0
+	of_register_trusted_foundations();
  	tegra_cpu_reset_handler_init();
  	tegra_apb_io_init();
  	tegra_init_fuse();

Your other bugfix patch for 3.13 moved tegra_cpu_reset_handler_init(). Should the call to of_register_trusted_foundations() move with it when this is applied, or should it just stay right at the start of tegra_init_early()? Either way is fine; just let me know which way to fix up the conflict when this gets applied.

I rebased on -next and left it at the start of tegra_init_early(). Even though at the moment the only requirement is that the call is made before tegra_cpu_reset_handler_init(), it seems to make sense to get rid of firmware-related initialization as early as possible.

Btw, this patchset is still based on the 3.12 code, before common.c got renamed to tegra.c, so you will have a problem here as well (sorry about that). The conflict is easy to resolve, but if you want me to send you a properly rebased version, just let me know.

#7 lore raw

PATCH v10 5/7 ARM: tegra: split setting of CPU reset handler

In reply to Alexandre Courbot

Not all Tegra devices can set the CPU reset handler in the same way. In particular, devices using a TrustZone secure monitor cannot set the reset handler directly and need to do it through a firmware operation.

This patch separates the act of setting the reset handler from its preparation, so the former can be implemented in a different way.

---
 arch/arm/mach-tegra/reset.c | 27 +++++++++++++++++----------
 1 file changed, 17 insertions(+), 10 deletions(-)
arch/arm/mach-tegra/reset.c +17 -10
index fd0bbf8a6c94..e282395b071c 100644
@@ -33,26 +33,18 @@
 
 static bool is_enabled;
 
-static void __init tegra_cpu_reset_handler_enable(void)
+static void __init tegra_cpu_reset_handler_set(const u32 reset_address)
 {
-	void __iomem *iram_base = IO_ADDRESS(TEGRA_IRAM_RESET_BASE);
 	void __iomem *evp_cpu_reset =
 		IO_ADDRESS(TEGRA_EXCEPTION_VECTORS_BASE + 0x100);
 	void __iomem *sb_ctrl = IO_ADDRESS(TEGRA_SB_BASE);
 	u32 reg;
 
-	BUG_ON(is_enabled);
-	BUG_ON(tegra_cpu_reset_handler_size > TEGRA_IRAM_RESET_HANDLER_SIZE);
-
-	memcpy(iram_base, (void *)__tegra_cpu_reset_handler_start,
-			tegra_cpu_reset_handler_size);
-
 	/*
 	 * NOTE: This must be the one and only write to the EVP CPU reset
 	 *       vector in the entire system.
 	 */
-	writel(TEGRA_IRAM_RESET_BASE + tegra_cpu_reset_handler_offset,
-			evp_cpu_reset);
+	writel(reset_address, evp_cpu_reset);
 	wmb();
 	reg = readl(evp_cpu_reset);
 
@@ -66,6 +58,21 @@ static void __init tegra_cpu_reset_handler_enable(void)
 		writel(reg, sb_ctrl);
 		wmb();
 	}
+}
+
+static void __init tegra_cpu_reset_handler_enable(void)
+{
+	void __iomem *iram_base = IO_ADDRESS(TEGRA_IRAM_RESET_BASE);
+	const u32 reset_address = TEGRA_IRAM_RESET_BASE +
+						tegra_cpu_reset_handler_offset;
+
+	BUG_ON(is_enabled);
+	BUG_ON(tegra_cpu_reset_handler_size > TEGRA_IRAM_RESET_HANDLER_SIZE);
+
+	memcpy(iram_base, (void *)__tegra_cpu_reset_handler_start,
+			tegra_cpu_reset_handler_size);
+
+	tegra_cpu_reset_handler_set(reset_address);
 
 	is_enabled = true;
 }
Signature · 1 line
1.8.4.2
#8 lore raw

PATCH v10 6/7 ARM: tegra: set CPU reset handler with firmware op

In reply to Alexandre Courbot

Use a firmware operation to set the CPU reset handler and only resort to doing it ourselves if there is none defined.

This supports the booting of secondary CPUs on devices using a TrustZone secure monitor.

---
 arch/arm/mach-tegra/reset.c | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)
arch/arm/mach-tegra/reset.c +14 -3
index e282395b071c..368af0afde46 100644
@@ -21,6 +21,7 @@
 
 #include <asm/cacheflush.h>
 #include <asm/hardware/cache-l2x0.h>
+#include <asm/firmware.h>
 
 #include "iomap.h"
 #include "irammap.h"
@@ -65,6 +66,7 @@ static void __init tegra_cpu_reset_handler_enable(void)
 	void __iomem *iram_base = IO_ADDRESS(TEGRA_IRAM_RESET_BASE);
 	const u32 reset_address = TEGRA_IRAM_RESET_BASE +
 						tegra_cpu_reset_handler_offset;
+	int err;
 
 	BUG_ON(is_enabled);
 	BUG_ON(tegra_cpu_reset_handler_size > TEGRA_IRAM_RESET_HANDLER_SIZE);
@@ -72,9 +74,18 @@ static void __init tegra_cpu_reset_handler_enable(void)
 	memcpy(iram_base, (void *)__tegra_cpu_reset_handler_start,
 			tegra_cpu_reset_handler_size);
 
-	tegra_cpu_reset_handler_set(reset_address);
-
-	is_enabled = true;
+	err = call_firmware_op(set_cpu_boot_addr, 0, reset_address);
+	switch (err) {
+	case -ENOSYS:
+		tegra_cpu_reset_handler_set(reset_address);
+		/* pass-through */
+	case 0:
+		is_enabled = true;
+		break;
+	default:
+		pr_crit("Cannot set CPU reset handler: %d\n", err);
+		BUG();
+	}
 }
 
 void __init tegra_cpu_reset_handler_init(void)
Signature · 1 line
1.8.4.2
#9 lore raw

PATCH v10 7/7 ARM: tegra: support Trusted Foundations by default

In reply to Alexandre Courbot

Support for Trusted Foundations is light and allows the kernel to run on a wider range of devices, so enable it by default.

---
 arch/arm/configs/tegra_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/tegra_defconfig +1 -0
index ea042e80e54d..dddb97b06b79 100644
@@ -32,6 +32,7 @@ CONFIG_PCI=y
 CONFIG_PCI_MSI=y
 CONFIG_PCI_TEGRA=y
 CONFIG_PCIEPORTBUS=y
+CONFIG_TRUSTED_FOUNDATIONS=y
 CONFIG_SMP=y
 CONFIG_PREEMPT=y
 CONFIG_AEABI=y
Signature · 1 line
1.8.4.2
#10 lore raw
In reply to Alexandre Courbot
Quoted 3 lines · Alexandre Courbot

Just a set of small fixes to address the concerns expressed on v9 with the non-prefixed version DT properties. I hope there won't be a need for an eleventh (!) version. :P

BTW, this version looks fine to me. On IRC, Olof said it looked OK to him. I'm just waiting to hear back from Olof/Russell whether I should merge this through the Tegra tree, or whether the first 1-3 patches should go through Russell's tree.

#11 lore raw
Quoted 9 lines · Stephen Warren
Quoted 3 lines · Alexandre Courbot

Just a set of small fixes to address the concerns expressed on v9 with the non-prefixed version DT properties. I hope there won't be a need for an eleventh (!) version. :P

BTW, this version looks fine to me. On IRC, Olof said it looked OK to him. I'm just waiting to hear back from Olof/Russell whether I should merge this through the Tegra tree, or whether the first 1-3 patches should go through Russell's tree.

I pinged Russell, and he brought up the fact that there were earlier requests to move it to drivers/firmware. It would make sense to try to get that done before merging, especially if you anticipate someone using TF on 64-bit platforms.

-Olof

#12 lore raw
Quoted 11 lines · Olof Johansson
Quoted 9 lines · Stephen Warren
Quoted 3 lines · Alexandre Courbot

Just a set of small fixes to address the concerns expressed on v9 with the non-prefixed version DT properties. I hope there won't be a need for an eleventh (!) version. :P

BTW, this version looks fine to me. On IRC, Olof said it looked OK to him. I'm just waiting to hear back from Olof/Russell whether I should merge this through the Tegra tree, or whether the first 1-3 patches should go through Russell's tree.

Quoted 4 lines

I pinged Russell, and he brought up the fact that there were earlier requests to move it to drivers/firmware. It would make sense to try to get that done before merging, especially if you anticipate someone using TF on 64-bit platforms.

IIRC when we discussed this point your last comment was as follows:

Quoted 5 lines · Olof Johansson

I think we can probably merge this under arch/arm now, and when we figure out what needs to be common with ARM64 we can move it out to a good location. It might be that mostly just a header file with ABI conventions needs to be shared, not actual implementation, for example.

So I thought we agreed on that. If in the end we prefer to move the ARM firmware interface into drivers/firmware, I'm fine with that too (Tomasz also confirmed he would be ok with it) but I wonder if that would not be somehow premature.

Another worry of mine is that this might delay this patchset some more. Support for TF is one of the last remaining step towards making NVIDIA branded Tegra retail devices (SHIELD and TegraNote at the moment) run upstream directly. I missed 3.13, I'd like to make sure I won't miss 3.14. Would it be acceptable if we move the ARM firmware interface to a common place after this patchset is merged?

#13 lore raw
Quoted 19 lines · Alex Courbot
Quoted 18 lines · Olof Johansson
Quoted 13 lines · Stephen Warren
Quoted 5 lines · Alexandre Courbot

Just a set of small fixes to address the concerns expressed on v9 with the
non-prefixed version DT properties. I hope there won't be a need for an eleventh (!) version. :P

BTW, this version looks fine to me. On IRC, Olof said it looked OK to him. I'm just waiting to hear back from Olof/Russell whether I should merge this through the Tegra tree, or whether the first 1-3 patches should go through Russell's tree.

Quoted 7 lines
Quoted 4 lines

I pinged Russell, and he brought up the fact that there were earlier requests to move it to drivers/firmware. It would make sense to try to get that done before merging, especially if you anticipate someone using TF on 64-bit platforms.

IIRC when we discussed this point your last comment was as follows:

Touche. :) Thanks for the reminder.

Quoted 12 lines · Olof Johansson
Quoted 5 lines

I think we can probably merge this under arch/arm now, and when we figure out what needs to be common with ARM64 we can move it out to a good location. It might be that mostly just a header file with ABI conventions needs to be shared, not actual implementation, for example.

So I thought we agreed on that. If in the end we prefer to move the ARM firmware interface into drivers/firmware, I'm fine with that too (Tomasz also confirmed he would be ok with it) but I wonder if that would not be somehow premature.

Quoted 6 lines

Another worry of mine is that this might delay this patchset some more. Support for TF is one of the last remaining step towards making NVIDIA branded Tegra retail devices (SHIELD and TegraNote at the moment) run upstream directly. I missed 3.13, I'd like to make sure I won't miss 3.14. Would it be acceptable if we move the ARM firmware interface to a common place after this patchset is merged?

Well, as I already said I'm ok with things going into arch/arm to start with, as long as Russell is. Once we see 64-bit needs for the same we'll move it out -- it's not like it's a whole lot of code to start with. But Russell has veto on the topic. :-)

Russell still has his pull requests outstanding so I'm not sure where things are at, but I don't think this will miss 3.14 at this rate.

-Olof

#14 lore raw
Quoted 49 lines · Olof Johansson
Quoted 19 lines · Alex Courbot
Quoted 18 lines · Olof Johansson
Quoted 13 lines · Stephen Warren
Quoted 5 lines · Alexandre Courbot

Just a set of small fixes to address the concerns expressed on v9 with the
non-prefixed version DT properties. I hope there won't be a need for an eleventh (!) version. :P

BTW, this version looks fine to me. On IRC, Olof said it looked OK to him. I'm just waiting to hear back from Olof/Russell whether I should merge this through the Tegra tree, or whether the first 1-3 patches should go through Russell's tree.

Quoted 7 lines
Quoted 4 lines

I pinged Russell, and he brought up the fact that there were earlier requests to move it to drivers/firmware. It would make sense to try to get that done before merging, especially if you anticipate someone using TF on 64-bit platforms.

IIRC when we discussed this point your last comment was as follows:

Touche. :) Thanks for the reminder.

Quoted 12 lines · Olof Johansson
Quoted 5 lines

I think we can probably merge this under arch/arm now, and when we figure out what needs to be common with ARM64 we can move it out to a good location. It might be that mostly just a header file with ABI conventions needs to be shared, not actual implementation, for example.

So I thought we agreed on that. If in the end we prefer to move the ARM firmware interface into drivers/firmware, I'm fine with that too (Tomasz also confirmed he would be ok with it) but I wonder if that would not be somehow premature.

Quoted 6 lines

Another worry of mine is that this might delay this patchset some more. Support for TF is one of the last remaining step towards making NVIDIA branded Tegra retail devices (SHIELD and TegraNote at the moment) run upstream directly. I missed 3.13, I'd like to make sure I won't miss 3.14. Would it be acceptable if we move the ARM firmware interface to a common place after this patchset is merged?

Quoted 4 lines

Well, as I already said I'm ok with things going into arch/arm to start with, as long as Russell is. Once we see 64-bit needs for the same we'll move it out -- it's not like it's a whole lot of code to start with. But Russell has veto on the topic. :-)

Thanks Olof. Russell, are you ok with the patchset in its current form? I can start moving the firmware interface out of arch/arm if that's what you want (there is no user outside of ARM at the moment, but as Olof pointed out that's not too much code) but I'd really like to see this series secured for 3.14.

Thanks,
Alex.

#15 lore raw
Quoted 70 lines · Alex Courbot
Quoted 63 lines · Olof Johansson
Quoted 26 lines · Alex Courbot
Quoted 24 lines · Olof Johansson
Quoted 17 lines · Stephen Warren
Quoted 7 lines · Alexandre Courbot

Just a set of small fixes to address the concerns expressed on v9 with the
non-prefixed version DT properties. I hope there won't be a need for an
eleventh (!) version. :P

BTW, this version looks fine to me. On IRC, Olof said it looked OK to him. I'm just waiting to hear back from Olof/Russell whether I should merge this through the Tegra tree, or whether the first 1-3 patches should go through Russell's tree.

Quoted 8 lines
Quoted 4 lines

I pinged Russell, and he brought up the fact that there were earlier requests to move it to drivers/firmware. It would make sense to try to get that done before merging, especially if you anticipate someone using TF on 64-bit platforms.

IIRC when we discussed this point your last comment was as follows:

Touche. :) Thanks for the reminder.

Quoted 14 lines · Olof Johansson
Quoted 6 lines

I think we can probably merge this under arch/arm now, and when we figure out what needs to be common with ARM64 we can move it out to a good location. It might be that mostly just a header file with ABI conventions needs to be shared, not actual implementation, for example.

So I thought we agreed on that. If in the end we prefer to move the ARM firmware interface into drivers/firmware, I'm fine with that too (Tomasz also confirmed he would be ok with it) but I wonder if that would not be somehow premature.

Quoted 7 lines

Another worry of mine is that this might delay this patchset some more. Support for TF is one of the last remaining step towards making NVIDIA branded Tegra retail devices (SHIELD and TegraNote at the moment) run upstream directly. I missed 3.13, I'd like to make sure I won't miss 3.14.
Would it be acceptable if we move the ARM firmware interface to a common place after this patchset is merged?

Quoted 4 lines

Well, as I already said I'm ok with things going into arch/arm to start with, as long as Russell is. Once we see 64-bit needs for the same we'll move it out -- it's not like it's a whole lot of code to start with. But Russell has veto on the topic. :-)

Quoted 5 lines

Thanks Olof. Russell, are you ok with the patchset in its current form? I can start moving the firmware interface out of arch/arm if that's what you want (there is no user outside of ARM at the moment, but as Olof pointed out that's not too much code) but I'd really like to see this series secured for 3.14.

Never mind, I have submitted a patch that moves firmware_ops to drivers/firmware, that will hopefully settle this issue. Then maybe we can finally flush this series as well (I will need to resubmit a new version though).

Alex.

#16 lore raw
Quoted 77 lines · Alexandre Courbot
Quoted 70 lines · Alex Courbot
Quoted 63 lines · Olof Johansson
Quoted 26 lines · Alex Courbot
Quoted 24 lines · Olof Johansson
Quoted 17 lines · Stephen Warren
Quoted 7 lines · Alexandre Courbot

Just a set of small fixes to address the concerns expressed on v9 with the
non-prefixed version DT properties. I hope there won't be a need for an
eleventh (!) version. :P

BTW, this version looks fine to me. On IRC, Olof said it looked OK to him. I'm just waiting to hear back from Olof/Russell whether I should merge this through the Tegra tree, or whether the first 1-3 patches should go through Russell's tree.

Quoted 8 lines
Quoted 4 lines

I pinged Russell, and he brought up the fact that there were earlier requests to move it to drivers/firmware. It would make sense to try to get that done before merging, especially if you anticipate someone using TF on 64-bit platforms.

IIRC when we discussed this point your last comment was as follows:

Touche. :) Thanks for the reminder.

Quoted 14 lines · Olof Johansson
Quoted 6 lines

I think we can probably merge this under arch/arm now, and when we figure out what needs to be common with ARM64 we can move it out to a good location. It might be that mostly just a header file with ABI conventions needs to be shared, not actual implementation, for example.

So I thought we agreed on that. If in the end we prefer to move the ARM firmware interface into drivers/firmware, I'm fine with that too (Tomasz also confirmed he would be ok with it) but I wonder if that would not be somehow premature.

Quoted 7 lines

Another worry of mine is that this might delay this patchset some more. Support for TF is one of the last remaining step towards making NVIDIA branded Tegra retail devices (SHIELD and TegraNote at the moment) run upstream directly. I missed 3.13, I'd like to make sure I won't miss 3.14.
Would it be acceptable if we move the ARM firmware interface to a common place after this patchset is merged?

Quoted 4 lines

Well, as I already said I'm ok with things going into arch/arm to start with, as long as Russell is. Once we see 64-bit needs for the same we'll move it out -- it's not like it's a whole lot of code to start with. But Russell has veto on the topic. :-)

Quoted 5 lines

Thanks Olof. Russell, are you ok with the patchset in its current form? I can start moving the firmware interface out of arch/arm if that's what you want (there is no user outside of ARM at the moment, but as Olof pointed out that's not too much code) but I'd really like to see this series secured for 3.14.

Quoted 4 lines

Never mind, I have submitted a patch that moves firmware_ops to drivers/firmware, that will hopefully settle this issue. Then maybe we can finally flush this series as well (I will need to resubmit a new version though).

... and that patch is very likely to not make it, for (I think) valid reasons. Thus I'm not quite sure where we are with this series now.

#17 lore raw
In reply to Olof Johansson

(Russell, a question for you at the bottom)

Quoted 2 lines · Olof Johansson
Quoted 1 line · Alex Courbot

On 11/13/2013 05:38 AM, Olof Johansson wrote:

...

Quoted 20 lines
Quoted 6 lines
Quoted 4 lines

I pinged Russell, and he brought up the fact that there were earlier requests to move it to drivers/firmware. It would make sense to try to get that done before merging, especially if you anticipate someone using TF on 64-bit platforms.

IIRC when we discussed this point your last comment was as follows:

Touche. :) Thanks for the reminder.

Quoted 11 lines · Olof Johansson
Quoted 5 lines

I think we can probably merge this under arch/arm now, and when we figure out what needs to be common with ARM64 we can move it out to a good location. It might be that mostly just a header file with ABI conventions needs to be shared, not actual implementation, for example.

So I thought we agreed on that. If in the end we prefer to move the ARM firmware interface into drivers/firmware, I'm fine with that too (Tomasz also confirmed he would be ok with it) but I wonder if that would not be somehow premature.

...

Quoted 2 lines

Well, as I already said I'm ok with things going into arch/arm to start with, as long as Russell is.

...

Russell, the patch Alex sent to move firmware_ops into drivers/firmware was rejected, so I don't think we can update this series to move the code there instead.

So, are you OK with merging this series as-is, in arch/arm/firmware? If you could ack the patch/series to indicate that, it would be awesome. Thanks.

#18 lore raw
Quoted 29 lines · Stephen Warren

(Russell, a question for you at the bottom)

Quoted 2 lines · Olof Johansson
Quoted 1 line · Alex Courbot

On 11/13/2013 05:38 AM, Olof Johansson wrote:

...

Quoted 20 lines
Quoted 6 lines
Quoted 4 lines

I pinged Russell, and he brought up the fact that there were earlier requests to move it to drivers/firmware. It would make sense to try to get that done before merging, especially if you anticipate someone using TF on 64-bit platforms.

IIRC when we discussed this point your last comment was as follows:

Touche. :) Thanks for the reminder.

Quoted 11 lines · Olof Johansson
Quoted 5 lines

I think we can probably merge this under arch/arm now, and when we figure out what needs to be common with ARM64 we can move it out to a good location. It might be that mostly just a header file with ABI conventions needs to be shared, not actual implementation, for example.

So I thought we agreed on that. If in the end we prefer to move the ARM firmware interface into drivers/firmware, I'm fine with that too (Tomasz also confirmed he would be ok with it) but I wonder if that would not be somehow premature.

...

Quoted 2 lines

Well, as I already said I'm ok with things going into arch/arm to start with, as long as Russell is.

Quoted 8 lines

...

Russell, the patch Alex sent to move firmware_ops into drivers/firmware was rejected, so I don't think we can update this series to move the code there instead.

So, are you OK with merging this series as-is, in arch/arm/firmware? If you could ack the patch/series to indicate that, it would be awesome.

Sorry, this was stuck on my to-read-and-reply list.

I think merging for arch/arm is what makes sense here, even if we end up at some point in the future moving it out. Only time will tell if that makes sense or not, and it's not going to be a big deal to handle at that time.

An ack from Russell would be appreciated, or we'd need to set up a shared branch given the Tegra dependencies that would go on top. Either is ok with me.

-Olof

#19 lore raw
Quoted 3 lines · Olof Johansson

An ack from Russell would be appreciated, or we'd need to set up a shared branch given the Tegra dependencies that would go on top. Either is ok with me.

Note that I'm *not* looking at anything new until after the merge window has closed, so I'm not acking or reviewing anything at the moment.

#20 lore raw
Quoted 7 lines · Russell King - ARM Linux
Quoted 3 lines · Olof Johansson

An ack from Russell would be appreciated, or we'd need to set up a shared branch given the Tegra dependencies that would go on top. Either is ok with me.

Note that I'm *not* looking at anything new until after the merge window has closed, so I'm not acking or reviewing anything at the moment.

OK, that's fair. Do we need to ping you again or repost once -rc1 is out, or do you have a TODO list that you'll check?