Skip to contentSkip to conversation

designware_i2c: remove 10msec delay in i2c_xfer_finish

PATCH In review Alexey Brodkin 2 participants 2 messages Nov 7, 2013 – Nov 13, 2013 I2C

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 designware_i2c: remove 10msec delay in i2c_xfer_finish

This delay applies to any data transfer on I2C bus.

For example 1kB data read with per-byte access (which happens if environment is stored in I2C EEPROM) takes more than 10 seconds.

Moreover data bus driver has to care about bus state and data transfer, but not about internal states of attached devices.

Cc Tom Rini <[email protected]>
cc Armando Visconti <[email protected]>
Cc Stefan Roese <[email protected]>
Cc Albert ARIBAUD <[email protected]>
Cc Heiko Schocher <[email protected]>
Cc Vipin KUMAR <[email protected]>
Cc Tom Rix <[email protected]>
Cc Mischa Jonker <[email protected]>
---
 drivers/i2c/designware_i2c.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/i2c/designware_i2c.c +0 -3
index c5c6015..cb2ac04 100644
@@ -249,9 +249,6 @@ static int i2c_xfer_finish(void)
 
 	i2c_flush_rxfifo();
 
-	/* Wait for read/write operation to complete on actual memory */
-	udelay(10000);
-
 	return 0;
 }
 
Signature · 1 line
1.8.4.2
#1 lore raw

Hello Alexey,

Am 07.11.2013 14:52, schrieb Alexey Brodkin:

Quoted 19 lines

This delay applies to any data transfer on I2C bus.

For example 1kB data read with per-byte access (which happens if environment is stored in I2C EEPROM) takes more than 10 seconds.

Moreover data bus driver has to care about bus state and data transfer, but not about internal states of attached devices.

Cc Tom Rini<[email protected]>
cc Armando Visconti<[email protected]>
Cc Stefan Roese<[email protected]>
Cc Albert ARIBAUD<[email protected]>
Cc Heiko Schocher<[email protected]>
Cc Vipin KUMAR<[email protected]>
Cc Tom Rix<[email protected]>
Cc Mischa Jonker<[email protected]>
Quoted 3 lines

---
drivers/i2c/designware_i2c.c | 3 ---

  1 file changed, 3 deletions(-)

Applied to u-boot-i2c.git

Thanks!

bye,
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany