Skip to contentSkip to conversation

qapi-schema: Update description for NewImageMode

PATCH Applied Max Reitz 5 participants 5 messages Nov 7, 2013 – Nov 11, 2013

lore
Share & tools
lore

Max Reitz

author
#0 lore raw

PATCH 1/1 qapi-schema: Update description for NewImageMode

If the NewImageMode is "absolute-paths" but no backing file is available (e.g., when mirroring a device with an unbacked image), the target image will not be backed either. This patch updates the documentation in qapi-schema.json accordingly.

---
Follow-up to:
- block/drive-mirror: Check for NULL backing_hd

---
 qapi-schema.json | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
qapi-schema.json +2 -1
index 81a375b..dde8e45 100644
@@ -1736,7 +1736,8 @@
 # @existing: QEMU should look for an existing image file.
 #
 # @absolute-paths: QEMU should create a new image with absolute paths
-# for the backing file.
+# for the backing file. If there is no backing file available, the new
+# image will not be backed either.
 #
 # Since: 1.1
 ##
Signature · 1 line
1.8.4.2
Reviewed-by Benoit Canet on v1 1/1
#1 lore raw
Quoted 31 lines · Max Reitz

If the NewImageMode is "absolute-paths" but no backing file is available (e.g., when mirroring a device with an unbacked image), the target image will not be backed either. This patch updates the documentation in qapi-schema.json accordingly.

---
Follow-up to:
- block/drive-mirror: Check for NULL backing_hd

---
 qapi-schema.json | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
qapi-schema.json +2 -1
index 81a375b..dde8e45 100644
@@ -1736,7 +1736,8 @@
 # @existing: QEMU should look for an existing image file.
 #
 # @absolute-paths: QEMU should create a new image with absolute paths
-# for the backing file.
+# for the backing file. If there is no backing file available, the new
+# image will not be backed either.
 #
 # Since: 1.1
 ##
Signature · 1 line
1.8.4.2
Reviewed-by on v1 1/1
#2 lore raw
In reply to Max Reitz
Quoted 5 lines · Max Reitz

If the NewImageMode is "absolute-paths" but no backing file is available (e.g., when mirroring a device with an unbacked image), the target image will not be backed either. This patch updates the documentation in qapi-schema.json accordingly.

Quoted 7 lines

---
Follow-up to:
- block/drive-mirror: Check for NULL backing_hd

---
 qapi-schema.json | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Trivial enough to include in 1.7, if desired.

Signature · 2 lines
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org
#3 lore raw
In reply to Max Reitz
Quoted 19 lines · Max Reitz

If the NewImageMode is "absolute-paths" but no backing file is available (e.g., when mirroring a device with an unbacked image), the target image will not be backed either. This patch updates the documentation in qapi-schema.json accordingly.

---
Follow-up to:
- block/drive-mirror: Check for NULL backing_hd

---
  qapi-schema.json | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
qapi-schema.json +0 -0
index 81a375b..dde8e45 100644

qapi-schema.json line 1743

Quoted 9 lines
qapi-schema.json +2 -1
@@ -1736,7 +1736,8 @@
  # @existing: QEMU should look for an existing image file.
  #
  # @absolute-paths: QEMU should create a new image with absolute paths
-# for the backing file.
+# for the backing file. If there is no backing file available, the new
+# image will not be backed either.
  #
  # Since: 1.1
  ##

It seems 2nd line should start with space, how about:
# @absolute-paths: QEMU should create a new image with absolute paths,

#                  the new image would usually have a backing file. If
#                  no backing file available, the new image will not be
#                  backed either.
Applied
#4 lore raw
In reply to Max Reitz

Am 07.11.2013 um 19:47 hat Max Reitz geschrieben:

Quoted 9 lines

If the NewImageMode is "absolute-paths" but no backing file is available (e.g., when mirroring a device with an unbacked image), the target image will not be backed either. This patch updates the documentation in qapi-schema.json accordingly.

---
Follow-up to:
- block/drive-mirror: Check for NULL backing_hd

Thanks, applied to the block branch.

Kevin