Skip to contentSkip to conversation

udev: ship source files to related dbg package

PATCH In review [email protected] 3 participants 7 messages Nov 7, 2013 – Nov 11, 2013

lore
Share & tools
lore
#0 lore raw

cover udev: ship source files to related dbg package

From: Wenzong Fan <[email protected]>

Just ship these sources to their own dbg packages instead of udev-dbg:

    libudev* -> libudev-dbg
    gudev*   -> libgudev-dbg
    others   -> udev-dbg

The following changes since commit d6cc7c8ed76c8b1117cf03c7bd4b0742f98f79b3:

toolchain-scripts/meta-environment: Further cleanup code duplication (2013-11-06 11:02:27 +0000)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib wenzong/udev-dbg-fix
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=wenzong/udev-dbg-fix

Wenzong Fan (1):
udev: ship source files to related dbg package

 meta/recipes-core/udev/udev.inc |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 udev: ship source files to related dbg package

From: Wenzong Fan <[email protected]>

Currently all source files will be shipped to udev-dbg regardless they should belong libudev-dbg or libgudev-dbg, just update the FILES list to ship those files to their own packages:

libudev-dbg: libudev*, libgudev-dbg: gudev*, udev-dbg: others

---
 meta/recipes-core/udev/udev.inc |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
meta/recipes-core/udev/udev.inc +5 -2
index 2ff8f00..b4327bd 100644
@@ -63,11 +63,14 @@ FILES_${PN}-dbg += "${base_libdir}/udev/.debug/*"
 FILES_${PN}-dbg += "${nonarch_base_libdir}/udev/.debug/*"
 FILES_${PN}-dev = "${datadir}/pkgconfig/udev.pc"
 FILES_libudev = "${base_libdir}/libudev.so.*"
-FILES_libudev-dbg = "${base_libdir}/.debug/libudev.so.*"
+FILES_libudev-dbg = "/usr/src/debug/${BPN}/${PV}-${PR}/${BP}/src/libudev* \
+                     ${base_libdir}/.debug/libudev.so.*"
 FILES_libudev-dev = "${includedir}/libudev.h ${libdir}/libudev.so ${libdir}/libudev.la \
                      ${libdir}/libudev.a ${libdir}/pkgconfig/libudev.pc"
 FILES_libgudev = "${base_libdir}/libgudev*.so.* ${libdir}/libgudev*.so.*"
-FILES_libgudev-dbg = "${base_libdir}/.debug/libgudev*.so.* ${libdir}/.debug/libgudev*.so.*"
+FILES_libgudev-dbg = "/usr/src/debug/${BPN}/${PV}-${PR}/${BP}/src/gudev* \
+                      /usr/src/debug/${BPN}/${PV}-${PR}/build/src/gudev* \
+                      ${base_libdir}/.debug/libgudev*.so.* ${libdir}/.debug/libgudev*.so.*"
 FILES_libgudev-dev = "${includedir}/gudev* ${libdir}/libgudev*.so ${libdir}/libgudev*.la \
                      ${libdir}/libgudev*.a ${libdir}/pkgconfig/gudev*.pc"
 FILES_udev-cache = "${sysconfdir}/init.d/udev-cache ${sysconfdir}/default/udev-cache"
Signature · 1 line
1.7.9.5
#2 lore raw
In reply to [email protected]
Quoted 7 lines · On 7 November 2013 11:03, <[email protected]> wrote:

From: Wenzong Fan <[email protected]>

Just ship these sources to their own dbg packages instead of udev-dbg:

    libudev* -> libudev-dbg
    gudev*   -> libgudev-dbg
    others   -> udev-dbg

Why do this? Multiple -dbg packages could make sense in a recipe which builds a multi-gigabyte -dbg package (such as webkit) but what's the rationale for doing this in udev?

Ross

#3 lore raw
Quoted 5 lines · Ross
Quoted 4 lines · On 7 November 2013 11:03, <[email protected]> wrote:

From: Wenzong Fan <[email protected]>

Just ship these sources to their own dbg packages instead of udev-dbg:

Quoted 7 lines
Quoted 3 lines
     libudev* -> libudev-dbg
     gudev*   -> libgudev-dbg
     others   -> udev-dbg

Why do this? Multiple -dbg packages could make sense in a recipe which builds a multi-gigabyte -dbg package (such as webkit) but what's the rationale for doing this in udev?

Actually I don't know clear about why it needs three -dbg packages, looks they have been there since very early commits of udev. I suspect that udev/libudev/libgudev are independent each other, so they are shipped into different packages (base/-dev/-dbg). This patch only ships their source code to -dbg packages accordingly.

Thanks
Wenzong

Quoted 4 lines

Ross

#4 lore raw
Quoted 14 lines · wenzong fan
Quoted 5 lines · Ross
Quoted 4 lines · On 7 November 2013 11:03, <[email protected]> wrote:

From: Wenzong Fan <[email protected]>

Just ship these sources to their own dbg packages instead of udev-dbg:

Quoted 7 lines
Quoted 3 lines
     libudev* -> libudev-dbg
     gudev*   -> libgudev-dbg
     others   -> udev-dbg

Why do this? Multiple -dbg packages could make sense in a recipe which builds a multi-gigabyte -dbg package (such as webkit) but what's the rationale for doing this in udev?

Quoted 5 lines

Actually I don't know clear about why it needs three -dbg packages, looks they have been there since very early commits of udev. I suspect that udev/libudev/libgudev are independent each other, so they are shipped into different packages (base/-dev/-dbg). This patch only ships their source code to -dbg packages accordingly.

We don't support multiple -dbg packages and this looks like an error.

Cheers,

Richard

#5 lore raw
Quoted 15 lines · Richard Purdie
Quoted 14 lines · wenzong fan
Quoted 12 lines · Ross
Quoted 7 lines · On 7 November 2013 11:03, <[email protected]> wrote:

From: Wenzong Fan <[email protected]>

Just ship these sources to their own dbg packages instead of udev-dbg:

      libudev* -> libudev-dbg
      gudev*   -> libgudev-dbg
      others   -> udev-dbg

Why do this? Multiple -dbg packages could make sense in a recipe which builds a multi-gigabyte -dbg package (such as webkit) but what's the rationale for doing this in udev?

Quoted 7 lines
Quoted 5 lines

Actually I don't know clear about why it needs three -dbg packages, looks they have been there since very early commits of udev. I suspect that udev/libudev/libgudev are independent each other, so they are shipped into different packages (base/-dev/-dbg). This patch only ships their source code to -dbg packages accordingly.

We don't support multiple -dbg packages and this looks like an error.

What about the -dev packages?

So the correct fix is removing below configs, at least -dbg configs, right?

+ FILES_libudev = "${base_libdir}/libudev.so.*"
+ FILES_libudev-dbg = "${base_libdir}/.debug/libudev.so.*"

+ FILES_libudev-dev = "${includedir}/libudev.h ${libdir}/libudev.so ${libdir}/libudev.la \
                     ${libdir}/libudev.a ${libdir}/pkgconfig/libudev.pc"

+ FILES_libgudev = "${base_libdir}/libgudev*.so.* ${libdir}/libgudev*.so.*"
+ FILES_libgudev-dbg = "${base_libdir}/.debug/libgudev*.so.* ${libdir}/.debug/libgudev*.so.*"

+ FILES_libgudev-dev = "${includedir}/gudev* ${libdir}/libgudev*.so ${libdir}/libgudev*.la \
                     ${libdir}/libgudev*.a ${libdir}/pkgconfig/gudev*.pc"

Thanks
Wenzong

Quoted 7 lines

Cheers,

Richard

#6 lore raw
In reply to Richard Purdie
Quoted 15 lines · Richard Purdie
Quoted 14 lines · wenzong fan
Quoted 12 lines · Ross
Quoted 7 lines · On 7 November 2013 11:03, <[email protected]> wrote:

From: Wenzong Fan <[email protected]>

Just ship these sources to their own dbg packages instead of udev-dbg:

      libudev* -> libudev-dbg
      gudev*   -> libgudev-dbg
      others   -> udev-dbg

Why do this? Multiple -dbg packages could make sense in a recipe which builds a multi-gigabyte -dbg package (such as webkit) but what's the rationale for doing this in udev?

Quoted 7 lines
Quoted 5 lines

Actually I don't know clear about why it needs three -dbg packages, looks they have been there since very early commits of udev. I suspect that udev/libudev/libgudev are independent each other, so they are shipped into different packages (base/-dev/-dbg). This patch only ships their source code to -dbg packages accordingly.

We don't support multiple -dbg packages and this looks like an error.

Ok, another patch for removing the extra -dbg packages has been sent with subject:

udev: remove libudev-dbg and libgudev-dbg

Thanks
Wenzong

Quoted 7 lines

Cheers,

Richard