alsa-lib: FLAT: Disable alsa lib when FLAT bianry is selected.
PATCH v2 1/1 alsa-lib: FLAT: Disable alsa lib when FLAT bianry is selected.
From: Sonic Zhang <[email protected]>
Alsa lib depends on the runtime library loader.
--- package/alsa-lib/Config.in | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
package/alsa-lib/Config.in +3 -2
@@ -9,14 +9,15 @@ config BR2_PACKAGE_ALSA_LIB # the usage of alsa-lib on no-thread systems is pretty # unlikely, just require thread support globally for alsa-lib. depends on BR2_TOOLCHAIN_HAS_THREADS + depends on !BR2_BINFMT_FLAT help The Advanced Linux Sound Architecture (ALSA) provides audio and MIDI functionality to the Linux operating system. http://www.alsa-project.org/ -comment "alsa-lib needs a toolchain w/ threads" - depends on !BR2_TOOLCHAIN_HAS_THREADS +comment "alsa-lib needs a toolchain w/ threads and none FLAT binary format" + depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_BINFMT_FLAT if BR2_PACKAGE_ALSA_LIB
Signature · 1 line
1.8.2.3
PATCH v2 1/1 alsa-lib: FLAT: Disable alsa lib when FLAT bianry is selected.
Hi Sonic,
Quoted 18 lines · On Mon, Nov 11, 2013 at 11:24 AM, <[email protected]> wrote:
From: Sonic Zhang <[email protected]>
Alsa lib depends on the runtime library loader.
Signed-off-by Sonic Zhang <[email protected]>--- package/alsa-lib/Config.in | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)package/alsa-lib/Config.in +1
-0@@ -9,14 +9,15 @@ config BR2_PACKAGE_ALSA_LIB # the usage of alsa-lib on no-thread systems is pretty # unlikely, just require thread support globally for alsa-lib. depends on BR2_TOOLCHAIN_HAS_THREADS + depends on !BR2_BINFMT_FLAT
package/alsa-lib/Config.in config BR2_PACKAGE_ALSA_LIB · line 20
Quoted 10 lines
package/alsa-lib/Config.in +2
-2help The Advanced Linux Sound Architecture (ALSA) provides audio and MIDI functionality to the Linux operating system. http://www.alsa-project.org/ -comment "alsa-lib needs a toolchain w/ threads" - depends on !BR2_TOOLCHAIN_HAS_THREADS +comment "alsa-lib needs a toolchain w/ threads and none FLAT binary format" + depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_BINFMT_FLAT
This is not what I meant. The comment should not mention the dependency on flat, but rather the comment should only be visible if that dependency is met, so:
comment "alsa-lib needs a toolchain w/ threads"
depends on !BR2_BINFMT_FLAT
depends on !BR2_TOOLCHAIN_HAS_THREADS
(note that this does not yet take into account the other comments you received from ThomasP, Gustavo, ...)