Skip to contentSkip to conversation

libqmi: fix autobuild failures

PATCH New spdawson at gmail.com 3 participants 3 messages Nov 11, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libqmi: fix autobuild failures

From: Simon Dawson <[email protected]>

The libqmi build specifies -Werror in the CFLAGS by default. This causes build failures such as the following.

http://autobuild.buildroot.net/results/070/070449299aa9025c4bc6769524a6e22d66c92a65/

The -Werror flag can be disabled using a configuration switch.

---
 package/libqmi/libqmi.mk | 2 ++
 1 file changed, 2 insertions(+)
package/libqmi/libqmi.mk +2 -0
index 911b1a7..8bd4577 100644
@@ -13,4 +13,6 @@ LIBQMI_INSTALL_STAGING = YES
 
 LIBQMI_DEPENDENCIES = libglib2
 
+LIBQMI_CONF_OPT = --enable-more-warnings=yes
+
 $(eval $(autotools-package))
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/1 libqmi: fix autobuild failures

Hi Simon,

Quoted 19 lines · spdawson at gmail.com

From: Simon Dawson <[email protected]>

The libqmi build specifies -Werror in the CFLAGS by default. This causes build failures such as the following.

http://autobuild.buildroot.net/results/070/070449299aa9025c4bc6769524a6e22d66c92a65/

The -Werror flag can be disabled using a configuration switch.

---
 package/libqmi/libqmi.mk | 2 ++
 1 file changed, 2 insertions(+)
package/libqmi/libqmi.mk +0 -0
index 911b1a7..8bd4577 100644

package/libqmi/libqmi.mk LIBQMI_INSTALL_STAGING = YES · line 16

Quoted 4 lines
package/libqmi/libqmi.mk +1 -0
@@ -13,4 +13,6 @@ LIBQMI_INSTALL_STAGING = YES
 
 LIBQMI_DEPENDENCIES = libglib2
 
+LIBQMI_CONF_OPT = --enable-more-warnings=yes

A comment would be nice. Something like:

# Disable -Werror

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#2 lore raw

PATCH 1/1 libqmi: fix autobuild failures

In reply to spdawson at gmail.com
Quoted 20 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"spdawson" == spdawson <[email protected]> writes:

From: Simon Dawson <[email protected]>
The libqmi build specifies -Werror in the CFLAGS by default. This causes build failures such as the following.

http://autobuild.buildroot.net/results/070/070449299aa9025c4bc6769524a6e22d66c92a65/

The -Werror flag can be disabled using a configuration switch.

---
 package/libqmi/libqmi.mk | 2 ++
 1 file changed, 2 insertions(+)
package/libqmi/libqmi.mk +0 -0
index 911b1a7..8bd4577 100644

package/libqmi/libqmi.mk LIBQMI_INSTALL_STAGING = YES · line 16

Quoted 4 lines
package/libqmi/libqmi.mk +1 -0
@@ -13,4 +13,6 @@ LIBQMI_INSTALL_STAGING = YES
 
 LIBQMI_DEPENDENCIES = libglib2
 
+LIBQMI_CONF_OPT = --enable-more-warnings=yes

That's not immediately obvious. Looking at compiler-warnings.m4 I see that =yes adds a bunch of -Wblah options to CFLAGS, so I instead changed it to =no and added a comment why.

Committed with that fixed, thanks.

Signature · 1 line
Bye, Peter Korsgaard