tests: tests for libnftables
PATCH v2 1/1 tests: tests for libnftables
Makefile and tests files for libnftables.
In this patch, I create a initial object 'a' and I set a testing values. Then, I convert this object in a Netlink message.
From this Netlink message, I parse that (through nft_table_nlmsg_parse function) in 'b' objetc.
Thus, we make sure that object transformations are correct.
---
v2: fix writing erorres in messages that I unintentionally added in v1 that were spotted by Phil Oester.
Fix a multiline comment error. The nft-ruleset-test is not included in this patch, also, I delete it in the tests/test-script.sh. Those errors were spotted by Arturo Borrero.
tests/Makefile.am | 82 ++++++++++++++++++++++++++++- tests/nft-chain-test.c | 105 +++++++++++++++++++++++++++++++++++++ tests/nft-expr_bitwise-test.c | 104 +++++++++++++++++++++++++++++++++++++ tests/nft-expr_byteorder-test.c | 92 +++++++++++++++++++++++++++++++++ tests/nft-expr_cmp-test.c | 87 +++++++++++++++++++++++++++++++ tests/nft-expr_counter-test.c | 79 ++++++++++++++++++++++++++++ tests/nft-expr_ct-test.c | 83 +++++++++++++++++++++++++++++ tests/nft-expr_exthdr-test.c | 87 +++++++++++++++++++++++++++++++ tests/nft-expr_immediate-test.c | 98 +++++++++++++++++++++++++++++++++++ tests/nft-expr_limit-test.c | 81 +++++++++++++++++++++++++++++ tests/nft-expr_log-test.c | 87 +++++++++++++++++++++++++++++++ tests/nft-expr_lookup-test.c | 90 ++++++++++++++++++++++++++++++++ tests/nft-expr_match-test.c | 105 +++++++++++++++++++++++++++++++++++++ tests/nft-expr_meta-test.c | 79 ++++++++++++++++++++++++++++ tests/nft-expr_nat-test.c | 97 ++++++++++++++++++++++++++++++++++ tests/nft-expr_payload-test.c | 88 +++++++++++++++++++++++++++++++ tests/nft-expr_reject-test.c | 81 +++++++++++++++++++++++++++++ tests/nft-expr_target-test.c | 112 ++++++++++++++++++++++++++++++++++++++++ tests/nft-rule-test.c | 76 +++++++++++++++++++++++++++ tests/nft-set-test.c | 74 ++++++++++++++++++++++++++ tests/nft-table-test.c | 64 +++++++++++++++++++++++ tests/test-script.sh | 19 +++++++ 22 files changed, 1869 insertions(+), 1 deletion(-) create mode 100644 tests/nft-chain-test.c create mode 100644 tests/nft-expr_bitwise-test.c create mode 100644 tests/nft-expr_byteorder-test.c create mode 100644 tests/nft-expr_cmp-test.c create mode 100644 tests/nft-expr_counter-test.c create mode 100644 tests/nft-expr_ct-test.c create mode 100644 tests/nft-expr_exthdr-test.c create mode 100644 tests/nft-expr_immediate-test.c create mode 100644 tests/nft-expr_limit-test.c create mode 100644 tests/nft-expr_log-test.c create mode 100644 tests/nft-expr_lookup-test.c create mode 100644 tests/nft-expr_match-test.c create mode 100644 tests/nft-expr_meta-test.c create mode 100644 tests/nft-expr_nat-test.c create mode 100644 tests/nft-expr_payload-test.c create mode 100644 tests/nft-expr_reject-test.c create mode 100644 tests/nft-expr_target-test.c create mode 100644 tests/nft-rule-test.c create mode 100644 tests/nft-set-test.c create mode 100644 tests/nft-table-test.c create mode 100755 tests/test-script.sh
tests/Makefile.am +81 -1
@@ -1,6 +1,86 @@ include $(top_srcdir)/Make_global.am -check_PROGRAMS = nft-parsing-test +check_PROGRAMS = nft-parsing-test \ + nft-table-test \ + nft-chain-test \ + nft-rule-test \ + nft-set-test \ + nft-expr_bitwise-test \ + nft-expr_byteorder-test \ + nft-expr_counter-test \ + nft-expr_cmp-test \ + nft-expr_ct-test \ + nft-expr_exthdr-test \ + nft-expr_immediate-test \ + nft-expr_limit-test \ + nft-expr_lookup-test \ + nft-expr_log-test \ + nft-expr_match-test \ + nft-expr_meta-test \ + nft-expr_nat-test \ + nft-expr_payload-test \ + nft-expr_reject-test \ + nft-expr_target-test nft_parsing_test_SOURCES = nft-parsing-test.c nft_parsing_test_LDADD = ../src/libnftables.la ${LIBMNL_LIBS} ${LIBXML_LIBS} ${LIBJSON_LIBS} + +nft_table_test_SOURCES = nft-table-test.c +nft_table_test_LDADD = ../src/libnftables.la ${LIBMNL_LIBS} + +nft_chain_test_SOURCES = nft-chain-test.c +nft_chain_test_LDADD = ../src/libnftables.la ${LIBMNL_LIBS} + +nft_rule_test_SOURCES = nft-rule-test.c +nft_rule_test_LDADD = ../src/libnftables.la ${LIBMNL_LIBS} + +nft_set_test_SOURCES = nft-set-test.c +nft_set_test_LDADD = ../src/libnftables.la ${LIBMNL_LIBS} + +nft_expr_bitwise_test_SOURCES = nft-expr_bitwise-test.c +nft_expr_bitwise_test_LDADD = ../src/libnftables.la ${LIBMNL_LIBS} + +nft_expr_byteorder_test_SOURCES = nft-expr_byteorder-test.c +nft_expr_byteorder_test_LDADD = ../src/libnftables.la ${LIBMNL_LIBS} + +nft_expr_cmp_test_SOURCES = nft-expr_cmp-test.c +nft_expr_cmp_test_LDADD = ../src/libnftables.la ${LIBMNL_LIBS} + +nft_expr_counter_test_SOURCES = nft-expr_counter-test.c +nft_expr_counter_test_LDADD = ../src/libnftables.la ${LIBMNL_LIBS} + +nft_expr_exthdr_test_SOURCES = nft-expr_exthdr-test.c +nft_expr_exthdr_test_LDADD = ../src/libnftables.la ${LIBMNL_LIBS} + +nft_expr_ct_test_SOURCES = nft-expr_ct-test.c +nft_expr_ct_test_LDADD = ../src/libnftables.la ${LIBMNL_LIBS} + +nft_expr_immediate_test_SOURCES = nft-expr_counter-test.c +nft_expr_immediate_test_LDADD = ../src/libnftables.la ${LIBMNL_LIBS} + +nft_expr_limit_test_SOURCES = nft-expr_limit-test.c +nft_expr_limit_test_LDADD = ../src/libnftables.la ${LIBMNL_LIBS} + +nft_expr_lookup_test_SOURCES = nft-expr_limit-test.c +nft_expr_lookup_test_LDADD = ../src/libnftables.la ${LIBMNL_LIBS} + +nft_expr_log_test_SOURCES = nft-expr_log-test.c +nft_expr_log_test_LDADD = ../src/libnftables.la ${LIBMNL_LIBS} + +nft_expr_match_test_SOURCES = nft-expr_match-test.c +nft_expr_match_test_LDADD = ../src/libnftables.la ${LIBMNL_LIBS} + +nft_expr_meta_test_SOURCES = nft-expr_meta-test.c +nft_expr_meta_test_LDADD = ../src/libnftables.la ${LIBMNL_LIBS} + +nft_expr_nat_test_SOURCES = nft-expr_nat-test.c +nft_expr_nat_test_LDADD = ../src/libnftables.la ${LIBMNL_LIBS} + +nft_expr_payload_test_SOURCES = nft-expr_payload-test.c +nft_expr_payload_test_LDADD = ../src/libnftables.la ${LIBMNL_LIBS} + +nft_expr_reject_test_SOURCES = nft-expr_reject-test.c +nft_expr_reject_test_LDADD = ../src/libnftables.la ${LIBMNL_LIBS} + +nft_expr_target_test_SOURCES = nft-expr_target-test.c +nft_expr_target_test_LDADD = ../src/libnftables.la ${LIBMNL_LIBS}
tests/nft-chain-test.c new file +105 -0
105 lines not on this page · raw message
tests/nft-expr_bitwise-test.c new file +104 -0
104 lines not on this page · raw message
tests/nft-expr_byteorder-test.c new file +92 -0
92 lines not on this page · raw message
tests/nft-expr_cmp-test.c new file +87 -0
87 lines not on this page · raw message
tests/nft-expr_counter-test.c new file +79 -0
79 lines not on this page · raw message
tests/nft-expr_ct-test.c new file +83 -0
83 lines not on this page · raw message
tests/nft-expr_exthdr-test.c new file +87 -0
87 lines not on this page · raw message
tests/nft-expr_immediate-test.c new file +98 -0
98 lines not on this page · raw message
tests/nft-expr_limit-test.c new file +81 -0
81 lines not on this page · raw message
tests/nft-expr_log-test.c new file +87 -0
87 lines not on this page · raw message
tests/nft-expr_lookup-test.c new file +90 -0
90 lines not on this page · raw message
tests/nft-expr_match-test.c new file +105 -0
105 lines not on this page · raw message
tests/nft-expr_meta-test.c new file +79 -0
79 lines not on this page · raw message
tests/nft-expr_nat-test.c new file +97 -0
97 lines not on this page · raw message
tests/nft-expr_payload-test.c new file +88 -0
88 lines not on this page · raw message
tests/nft-expr_reject-test.c new file +81 -0
81 lines not on this page · raw message
tests/nft-expr_target-test.c new file +112 -0
112 lines not on this page · raw message
tests/nft-rule-test.c new file +76 -0
76 lines not on this page · raw message
tests/nft-set-test.c new file +74 -0
74 lines not on this page · raw message
tests/nft-table-test.c new file +64 -0
64 lines not on this page · raw message
tests/test-script.sh new file +19 -0
@@ -0,0 +1,19 @@ +./nft-chain-test +./nft-expr_bitwise-test +./nft-expr_byteorder-test +./nft-expr_cmp-test +./nft-expr_counter-test +./nft-expr_ct-test +./nft-expr_exthdr-test +./nft-expr_immediate-test +./nft-expr_limit-test +./nft-expr_log-test +./nft-expr_lookup-test +./nft-expr_match-test +./nft-expr_meta-test +./nft-expr_nat-test +./nft-expr_payload-test +./nft-expr_target-test +./nft-rule-test +./nft-set-test +./nft-table-test
Signature · 6 lines
1.8.4.rc3 -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 8 lines · Ana Rey
Makefileand tests files for libnftables.In this patch, I create a initial object 'a' and I set a testing values. Then, I convert this object in a Netlink message.
From this Netlink message, I parse that (through
nft_table_nlmsg_parsefunction) in 'b' objetc.
Quoted 9 lines
Thus, we make sure that object transformations are correct.
---
v2: fix writing erorres in messages that I unintentionally added in v1 that were spotted by Phil Oester.Fix a multiline comment error. The nft-ruleset-test is not included in this patch, also, I delete it in the
tests/test-script.sh. Those errors were spotted by Arturo Borrero.
Hi Ana, thanks for the update.
I've been testing your patch. Some comments below.
Quoted 20 lines
tests/nft-expr_bitwise-test.c new file +14
-0@@ -0,0 +1,104 @@ +#include <stdio.h> +#include <stdlib.h> +#include <string.h> + +#include <netinet/in.h> +#include <netinet/ip.h> +#include <linux/netfilter/nf_tables.h> +#include <libmnl/libmnl.h> +#include <libnftables/rule.h> +#include <libnftables/expr.h> + +static void die (const char *msg) +{ +printf ("\033[31mERROR:\e[0m %s\n" , msg);
tests/nft-expr_bitwise-test.c line 24
Quoted 10 lines
tests/nft-expr_bitwise-test.c new file +10
-0+exit (EXIT_FAILURE ); +} + +static void cmp_nft_rule_expr (struct nft_rule_expr *rule_a, +struct nft_rule_expr *rule_b) +{ +uint32_t maska =NULL ; +uint32_t maskb =NULL ; +uint32_t xora =NULL ; +uint32_t xorb =NULL ;
I think those initialization are unnecessary. Also, my compiler says:
nft-expr_bitwise-test.c: In function ‘cmp_nft_rule_expr’:
nft-expr_bitwise-test.c:21:19: warning: initialization makes integer from pointer without a cast [enabled by default] nft-expr_bitwise-test.c:22:19: warning: initialization makes integer from pointer without a cast [enabled by default] nft-expr_bitwise-test.c:23:18: warning: initialization makes integer from pointer without a cast [enabled by default] nft-expr_bitwise-test.c:24:18: warning: initialization makes integer from pointer without a cast [enabled by default]
Same in nft-expr_cmp-test.c
Quoted 6 lines
tests/nft-expr_match-test.c new file +0
-0
tests/nft-expr_match-test.c line 10
Quoted 10 lines
tests/nft-expr_match-test.c new file +10
-0@@ -0,0 +1,105 @@ +#include <stdio.h> +#include <stdlib.h> +#include <string.h> + +#include <arpa/inet.h> +#include <netinet/in.h> +#include <netinet/ip.h> +#include <linux/netfilter/nf_tables.h> +#include <linux/netfilter/xt_iprange.h> +#include <linux/netfilter_ipv4/ipt_LOG.h>
In file included from nft-expr_match-test.c:10:0:/usr/include/linux/netfilter_ipv4/ipt_LOG.h:4:2: warning: #warning "Please update iptables, this file will be removed soon!" [-Wcpp]
Should we ignore this warning?
Also found in nft-expr_target-test.c
Quoted 42 lines
tests/nft-expr_target-test.c new file +36
-0@@ -0,0 +1,112 @@ +#include <stdio.h> +#include <stdlib.h> +#include <string.h> + +#include <netinet/in.h> +#include <netinet/ip.h> +#include <linux/netfilter/nf_tables.h> +#include <linux/netfilter/xt_iprange.h> +#include <linux/netfilter_ipv4/ipt_LOG.h> +#include <libmnl/libmnl.h> +#include <libnftables/rule.h> +#include <libnftables/expr.h> + +static void die (const char *msg) +{ +printf ("\033[31mERROR:\e[0m %s\n" , msg); +exit (EXIT_FAILURE ); +} + +static void die2 (const char *msg,uint32_t a,uint32_t b) +{ +printf ("\033[31mERROR:\e[0m %s size a: %d b: %d \n" ,msg, a, b); +exit (EXIT_FAILURE ); +} + +static void cmp_nft_rule_expr (struct nft_rule_expr *rule_a, +struct nft_rule_expr *rule_b) +{ +uint32_t lena, lenb; + +if (strcmp (nft_rule_expr_get_str (rule_a,NFT_EXPR_TG_NAME ), +nft_rule_expr_get_str (rule_b,NFT_EXPR_TG_NAME )) !=0 ) +die ("Expr TG_NAME mismatches" ); + +if (nft_rule_expr_get_u32 (rule_a,NFT_EXPR_TG_REV ) != +nft_rule_expr_get_u32 (rule_b,NFT_EXPR_TG_REV ))
tests/nft-expr_target-test.c line 46
Quoted 10 lines
tests/nft-expr_target-test.c new file +10
-0+die ("Expr TG_REV mismatches" ); + +nft_rule_expr_get (rule_a,NFT_EXPR_TG_INFO , &lena); +nft_rule_expr_get (rule_b,NFT_EXPR_TG_INFO , &lenb); + +/* TODO ¿BUG? */ +if (lena != lenb) +die2 ("Expr TG_DATA size mismatches" , lena, lenb); +} +
When I run the test:
root@debian:/home/aborrero/git/libnftables/tests# ./test-script.sh /home/aborrero/git/libnftables/tests/.libs/lt-nft-chain-test: OK /home/aborrero/git/libnftables/tests/.libs/lt-nft-expr_bitwise-test: OK /home/aborrero/git/libnftables/tests/.libs/lt-nft-expr_byteorder-test: OK /home/aborrero/git/libnftables/tests/.libs/lt-nft-expr_cmp-test: OK /home/aborrero/git/libnftables/tests/.libs/lt-nft-expr_counter-test: OK /home/aborrero/git/libnftables/tests/.libs/lt-nft-expr_ct-test: OK /home/aborrero/git/libnftables/tests/.libs/lt-nft-expr_exthdr-test: OK /home/aborrero/git/libnftables/tests/.libs/lt-nft-expr_immediate-test: OK /home/aborrero/git/libnftables/tests/.libs/lt-nft-expr_limit-test: OK /home/aborrero/git/libnftables/tests/.libs/lt-nft-expr_log-test: OK /home/aborrero/git/libnftables/tests/.libs/lt-nft-expr_lookup-test: OK /home/aborrero/git/libnftables/tests/.libs/lt-nft-expr_match-test: OK /home/aborrero/git/libnftables/tests/.libs/lt-nft-expr_meta-test: OK /home/aborrero/git/libnftables/tests/.libs/lt-nft-expr_nat-test: OK /home/aborrero/git/libnftables/tests/.libs/lt-nft-expr_payload-test: OK ERROR: Expr TG_DATA size mismatches size a: 32 b: 36 /home/aborrero/git/libnftables/tests/.libs/lt-nft-rule-test: OK /home/aborrero/git/libnftables/tests/.libs/lt-nft-set-test: OK /home/aborrero/git/libnftables/tests/.libs/lt-nft-table-test: OK
I guess the error above is the bug you spotted.
Quoted 53 lines
tests/nft-expr_target-test.c new file +53
-0+int main (int argc,char *argv[]) +{ +struct nft_rule *a, *b; +struct nft_rule_expr *ex; +struct nlmsghdr *nlh; +struct ipt_log_info *info; +char buf[4096 ]; +struct nft_rule_expr_iter *iter_a, *iter_b; +struct nft_rule_expr *rule_a, *rule_b; + + a =nft_rule_alloc (); + b =nft_rule_alloc (); +if (a ==NULL || b ==NULL ) +die ("OOM" ); + + ex =nft_rule_expr_alloc ("target" ); +if (ex ==NULL ) +die ("OOM" ); +nft_rule_expr_set (ex,NFT_EXPR_TG_NAME ,"LOG" ,strlen ("LOG" )); +nft_rule_expr_set_u32 (ex,NFT_EXPR_TG_REV ,0x12345678 ); + + info =calloc (1 ,sizeof (struct ipt_log_info )); +if (info ==NULL ) +die ("OOM" ); +sprintf (info->prefix,"test: " ); + info->prefix[sizeof (info->prefix)-1 ] ='\0' ; + info->logflags =0x0f ; + info->level =5 ; +nft_rule_expr_set (ex,NFT_EXPR_TG_INFO , info,sizeof (*info)); + +nft_rule_add_expr (a, ex); + + nlh =nft_rule_nlmsg_build_hdr (buf,NFT_MSG_NEWRULE ,AF_INET ,0 ,1234 ); +nft_rule_nlmsg_build_payload (nlh, a); + +if (nft_rule_nlmsg_parse (nlh, b) <0 ) +die ("parsing problems" ); + + iter_a =nft_rule_expr_iter_create (a); + iter_b =nft_rule_expr_iter_create (b); +if (iter_a ==NULL || iter_b ==NULL ) +die ("OOM" ); + + rule_a =nft_rule_expr_iter_next (iter_a); + rule_b =nft_rule_expr_iter_next (iter_b); +if (rule_a ==NULL || rule_b ==NULL ) +die ("OOM" ); + +cmp_nft_rule_expr (rule_a, rule_b); + +if (nft_rule_expr_iter_next (iter_a) !=NULL || +nft_rule_expr_iter_next (iter_b) !=NULL ) +die ("More 1 expr." );
tests/nft-expr_target-test.c line 109
Quoted 10 lines
tests/nft-expr_target-test.c new file +10
-0+ +nft_rule_expr_iter_destroy (iter_a); +nft_rule_expr_iter_destroy (iter_b); +nft_rule_free (a); +nft_rule_free (b); +/* BUG: leak memory +==28351== HEAP SUMMARY: +* ==28351== in use at exit: 436 bytes in 8 blocks +* ==28351== total heap usage: 8 allocs, 0 frees, 436 bytes allocated +*/
Do you think the leak is in nft_rule_expr_iter_destroy()?
==1860== 16 bytes in 1 blocks are definitely lost in loss record 2 of 8
==1860== at 0x4C272B8: calloc (vg_replace_malloc.c:566) ==1860== by 0x4E388D2: nft_rule_expr_iter_create (rule.c:860) ==1860== by 0x400D6F: main (nft-expr_target-test.c:85)
Also, I think the comment itself is not in good format (sorry for being repetitive).
Regards
Signature · 5 lines
Arturo Borrero González -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html