Skip to contentSkip to conversation

udev: remove libudev-dbg and libgudev-dbg

PATCH In review [email protected] 3 participants 6 messages Nov 11, 2013 – Nov 14, 2013

lore
Share & tools
lore
#0 lore raw

cover udev: remove libudev-dbg and libgudev-dbg

From: Wenzong Fan <[email protected]>

We don't support multiple -dbg packages, so just remove the libudev-dbg, libgudev-dbg and put all debug stuffs to 'udev-dbg'.

The following changes since commit 4fdc3d77d4a875b7236536bf78849a4d1f6a7449:

kbd: Fix stdarg related errors on uclibc (2013-11-08 17:31:36 +0000)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib wenzong/udev-remove-dbg
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=wenzong/udev-remove-dbg

Wenzong Fan (1):
udev: remove libudev-dbg and libgudev-dbg

 meta/recipes-core/udev/udev.inc |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 udev: remove libudev-dbg and libgudev-dbg

From: Wenzong Fan <[email protected]>

We don't support multiple -dbg packages, all debug stuffs will be shipped to 'udev-dbg'.

---
 meta/recipes-core/udev/udev.inc |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
meta/recipes-core/udev/udev.inc +2 -4
index 02cab3b..ec638ea 100644
@@ -45,8 +45,8 @@ EXTRA_OECONF = "--disable-introspection \
                "
 
 PACKAGES =+ "udev-utils udev-cache"
-PACKAGES =+ "libudev libudev-dev libudev-dbg"
-PACKAGES =+ "libgudev libgudev-dev libgudev-dbg"
+PACKAGES =+ "libudev libudev-dev"
+PACKAGES =+ "libgudev libgudev-dev"
 
 INITSCRIPT_PACKAGES = "udev udev-cache"
 INITSCRIPT_NAME_udev = "udev"
@@ -63,11 +63,9 @@ FILES_${PN}-dbg += "${base_libdir}/udev/.debug/*"
 FILES_${PN}-dbg += "${nonarch_base_libdir}/udev/.debug/*"
 FILES_${PN}-dev = "${datadir}/pkgconfig/udev.pc"
 FILES_libudev = "${base_libdir}/libudev.so.*"
-FILES_libudev-dbg = "${base_libdir}/.debug/libudev.so.*"
 FILES_libudev-dev = "${includedir}/libudev.h ${libdir}/libudev.so ${libdir}/libudev.la \
                      ${libdir}/libudev.a ${libdir}/pkgconfig/libudev.pc"
 FILES_libgudev = "${base_libdir}/libgudev*.so.* ${libdir}/libgudev*.so.*"
-FILES_libgudev-dbg = "${base_libdir}/.debug/libgudev*.so.* ${libdir}/.debug/libgudev*.so.*"
 FILES_libgudev-dev = "${includedir}/gudev* ${libdir}/libgudev*.so ${libdir}/libgudev*.la \
                      ${libdir}/libgudev*.a ${libdir}/pkgconfig/gudev*.pc"
 FILES_udev-cache = "${sysconfdir}/init.d/udev-cache ${sysconfdir}/default/udev-cache"
Signature · 1 line
1.7.9.5
#2 lore raw
In reply to [email protected]
Quoted 4 lines · On 11/11/13, 4:10 AM, [email protected] wrote:

From: Wenzong Fan <[email protected]>

We don't support multiple -dbg packages, so just remove the libudev-dbg, libgudev-dbg and put all debug stuffs to 'udev-dbg'.

I'm a bit confused, we do support package that want to provide multiple -dbg files to generate them.

This way large recipes that provide lots of different bits of functionality can no only segment the packages they create, but keep the side of the -dbg information reasonable as well. (It's not all that commonly used, but it does work with the IMAGE_FEATURES 'dbg-pkgs'.)

What issue was being solved by combining the two items back into one?

--Mark

Quoted 15 lines

The following changes since commit 4fdc3d77d4a875b7236536bf78849a4d1f6a7449:

kbd: Fix stdarg related errors on uclibc (2013-11-08 17:31:36 +0000)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib wenzong/udev-remove-dbg
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=wenzong/udev-remove-dbg

Wenzong Fan (1):
udev: remove libudev-dbg and libgudev-dbg

  meta/recipes-core/udev/udev.inc |    6 ++----
  1 file changed, 2 insertions(+), 4 deletions(-)
#3 lore raw
Quoted 9 lines · Mark Hatle
Quoted 4 lines · On 11/11/13, 4:10 AM, [email protected] wrote:

From: Wenzong Fan <[email protected]>

We don't support multiple -dbg packages, so just remove the libudev-dbg, libgudev-dbg and put all debug stuffs to 'udev-dbg'.

I'm a bit confused, we do support package that want to provide multiple -dbg files to generate them.

Quoted 6 lines

This way large recipes that provide lots of different bits of functionality can no only segment the packages they create, but keep the side of the -dbg information reasonable as well. (It's not all that commonly used, but it does work with the IMAGE_FEATURES 'dbg-pkgs'.)

What issue was being solved by combining the two items back into one?

Hi Mark,

This is an updated patch for fixing the 'source codes <--> -dbg packages' (i.e. which src should be shipped to which -dbg package), details please refer to another thread about:

Subject: udev: ship source files to related dbg package

As Richard mentioned:

"We don't support multiple -dbg packages and this looks like an error." - (the udev have there -dbg packages: libudev-dbg/libgudev-dbg/udev-dbg)

If I was wrong please correct me.

Thanks
Wenzong

Quoted 27 lines

--Mark

Quoted 9 lines

The following changes since commit
4fdc3d77d4a875b7236536bf78849a4d1f6a7449:

kbd: Fix stdarg related errors on uclibc (2013-11-08 17:31:36 +0000)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib wenzong/udev-remove-dbg

Quoted 9 lines

http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=wenzong/udev-remove-dbg

Wenzong Fan (1):
udev: remove libudev-dbg and libgudev-dbg

  meta/recipes-core/udev/udev.inc |    6 ++----
  1 file changed, 2 insertions(+), 4 deletions(-)

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#4 lore raw
In reply to Mark Hatle
Quoted 8 lines · Mark Hatle
Quoted 4 lines · On 11/11/13, 4:10 AM, [email protected] wrote:

From: Wenzong Fan <[email protected]>

We don't support multiple -dbg packages, so just remove the libudev-dbg, libgudev-dbg and put all debug stuffs to 'udev-dbg'.

I'm a bit confused, we do support package that want to provide multiple -dbg files to generate them.

No, we do not. We don't support multiple -dev packages either. Yes packages can generate them but the system does not correctly handle them and never has.

Cheers,

Richard

#5 lore raw
Quoted 7 lines · Richard Purdie
Quoted 6 lines · Mark Hatle
Quoted 4 lines · On 11/11/13, 4:10 AM, [email protected] wrote:

From: Wenzong Fan <[email protected]>

We don't support multiple -dbg packages, so just remove the libudev-dbg, libgudev-dbg and put all debug stuffs to 'udev-dbg'.

Quoted 6 lines
Quoted 2 lines

I'm a bit confused, we do support package that want to provide multiple -dbg files to generate them.

No, we do not. We don't support multiple -dev packages either. Yes packages can generate them but the system does not correctly handle them and never has.

Ok, a V2 patch was sent for removing extra -dev/-dbg packages for udev.

Thanks
Wenzong

Quoted 11 lines

Cheers,

Richard

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core