perf trace: Fix syscall summary duration order
PATCH 1/1 perf trace: Fix syscall summary duration order
Switch duration order to minimum, average, maximum for the '--summary' command line option because it's more natural to read.
Cc David Ahern <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Arnaldo Carvalho de Melo <[email protected]>
Signed-off-by Pekka Enberg <[email protected]>
--- tools/perf/builtin-trace.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
tools/perf/builtin-trace.c +3 -3
@@ -2085,7 +2085,7 @@ static size_t trace__fprintf_threads_header(FILE *fp) printed =fprintf (fp,"\n _____________________________________________________________________________\n" ); printed +=fprintf (fp," __) Summary of events (__\n\n" ); printed +=fprintf (fp," [ task - pid ] [ events ] [ ratio ] [ runtime ]\n" ); - printed +=fprintf (fp," syscall count min max avg stddev\n" ); + printed +=fprintf (fp," syscall count min avg max stddev\n" ); printed +=fprintf (fp," msec msec msec %%\n" ); printed +=fprintf (fp," _____________________________________________________________________________\n\n" );
@@ -2121,8 +2121,8 @@ static size_t thread__dump_stats(struct thread_trace *ttrace, sc = &trace->syscalls.table[inode->i]; printed +=fprintf (fp,"%24s %14s : " ,"" , sc->name); printed +=fprintf (fp,"%5" PRIu64" %8.3f %8.3f" , - n, min, max); - printed +=fprintf (fp," %8.3f %6.2f\n" , avg, pct); + n, min, avg); + printed +=fprintf (fp," %8.3f %6.2f\n" , max, pct); } inode =intlist__next (inode);
Signature · 1 line
1.8.3.1
Quoted 10 lines · Pekka Enberg
Switch duration order to minimum, average, maximum for the '--summary' command line option because it's more natural to read.
Cc David Ahern <[email protected]>Cc Ingo Molnar <[email protected]>Cc Arnaldo Carvalho de Melo <[email protected]>Signed-off-by Pekka Enberg <[email protected]>--- tools/perf/builtin-trace.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
I would change the 'Fix' in the summary line to 'Change'. Other than that...
Acked-by David Ahern <[email protected]>
tip-bot for Pekka Enberg
merge bot[tip:perf/urgent] perf trace: Change syscall summary duration order
In reply to Pekka Enbergperf trace: Change syscall summary duration order
Commit-ID: 7f7a4138c66e857cc5bbf6e248a47379765349b5 Gitweb: http://git.kernel.org/tip/7f7a4138c66e857cc5bbf6e248a47379765349b5 Author: Pekka Enberg <[email protected]> AuthorDate: Tue, 12 Nov 2013 16:10:10 +0200 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Tue, 12 Nov 2013 13:00:38 -0300
perf trace: Change syscall summary duration order
Switch duration order to minimum, average, maximum for the '--summary' command line option because it's more natural to read.
Signed-off-by Pekka Enberg <[email protected]>
Acked-by David Ahern <[email protected]>
Cc David Ahern <[email protected]>
Cc Ingo Molnar <[email protected]>
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
--- tools/perf/builtin-trace.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
tools/perf/builtin-trace.c +3 -3
@@ -2093,7 +2093,7 @@ static size_t trace__fprintf_threads_header(FILE *fp) printed =fprintf (fp,"\n _____________________________________________________________________________\n" ); printed +=fprintf (fp," __) Summary of events (__\n\n" ); printed +=fprintf (fp," [ task - pid ] [ events ] [ ratio ] [ runtime ]\n" ); - printed +=fprintf (fp," syscall count min max avg stddev\n" ); + printed +=fprintf (fp," syscall count min avg max stddev\n" ); printed +=fprintf (fp," msec msec msec %%\n" ); printed +=fprintf (fp," _____________________________________________________________________________\n\n" );
@@ -2129,8 +2129,8 @@ static size_t thread__dump_stats(struct thread_trace *ttrace, sc = &trace->syscalls.table[inode->i]; printed +=fprintf (fp,"%24s %14s : " ,"" , sc->name); printed +=fprintf (fp,"%5" PRIu64" %8.3f %8.3f" , - n, min, max); - printed +=fprintf (fp," %8.3f %6.2f\n" , avg, pct); + n, min, avg); + printed +=fprintf (fp," %8.3f %6.2f\n" , max, pct); } inode =intlist__next (inode);