curl: build with c-ares library support.
PATCH 1/1 curl: build with c-ares library support.
Also added c-ares library recipe.
In libcurl there is an issue with DNS lookups that cause crash on some platforms:
http://curl.haxx.se/mail/lib-2008-09/0197.html
To avoid this issue libcurl has to be built with c-ares name resolver.
--- meta/recipes-support/c-ares/c-ares_1.10.0.bb | 22 ++++++++++++++++++++++ meta/recipes-support/curl/curl_7.33.0.bb | 3 ++- 2 files changed, 24 insertions(+), 1 deletion(-) create mode 100644 meta/recipes-support/c-ares/c-ares_1.10.0.bb
meta/recipes-support/c-ares/c-ares_1.10.0.bb new file +22 -0
@@ -0,0 +1,22 @@ +DESCRIPTION = "c-ares is a C library that resolves names asynchronously." +HOMEPAGE = "http://daniel.haxx.se/projects/c-ares/" +SECTION = "libs" +LICENSE = "MIT" +LIC_FILES_CHKSUM = "file://README;beginline=17;endline=18;md5=b320556568bc067d215a1e34c5b34a14" + +inherit autotools +inherit pkgconfig + +SRC_URI = "http://c-ares.haxx.se/download/${BP}.tar.gz" +SRC_URI[md5sum] = "1196067641411a75d3cbebe074fd36d8" +SRC_URI[sha256sum] = "3d701674615d1158e56a59aaede7891f2dde3da0f46a6d3c684e0ae70f52d3db" + +EXTRA_OECONF = "--enable-shared" + +# install private headers to ares subdirectory +do_install_append() { + install -d ${D}/${includedir}/ares + install -m 0644 ares*.h ${D}/${includedir}/ares/ +} + +FILES_${PN}-dev += "${includedir}/ares/*.h"
meta/recipes-support/curl/curl_7.33.0.bb +2 -1
@@ -5,7 +5,7 @@ SECTION = "console/network" LICENSE = "MIT" LIC_FILES_CHKSUM = "file://COPYING;beginline=7;md5=3a34942f4ae3fbf1a303160714e664ac" -DEPENDS = "zlib gnutls" +DEPENDS = "zlib gnutls c-ares" DEPENDS_class-native = "zlib-native openssl-native" DEPENDS_class-nativesdk = "nativesdk-zlib"
@@ -30,6 +30,7 @@ EXTRA_OECONF = "--with-zlib=${STAGING_LIBDIR}/../ \ --enable-crypto-auth \ --disable-ldap \ --disable-ldaps \ + --enable-ares \ ${CURLGNUTLS} \ "
Signature · 1 line
1.8.1.2
Quoted 6 lines · Yevhen Kyriukha
Also added c-ares library recipe.
In libcurl there is an issue with DNS lookups that cause crash on some platforms:
http://curl.haxx.se/mail/lib-2008-09/0197.html
To avoid this issue libcurl has to be built with c-ares name resolver.
I am still considering this patch, but need to understand what platforms curl is failing on.
Quoted 3 lines
Signed-off-by Yevhen Kyriukha <[email protected]>--- meta/recipes-support/c-ares/c-ares_1.10.0.bb | 22 ++++++++++++++++++++++
Additionally, if adding this to oe-core, it needs to be in it's own patch crediting the orignal author / layer, I found a 1.10 version in the meta-webos-ports, is this where it came from?
Sau!
Quoted 54 lines
meta/recipes-support/curl/curl_7.33.0.bb | 3 ++- 2 files changed, 24 insertions(+), 1 deletion(-)create mode 100644 meta/recipes-support/c-ares/c-ares_1.10.0.bb
meta/recipes-support/c-ares/c-ares_1.10.0.bb new file +22
-0@@ -0,0 +1,22 @@ +DESCRIPTION = "c-ares is a C library that resolves names asynchronously." +HOMEPAGE = "http://daniel.haxx.se/projects/c-ares/" +SECTION = "libs" +LICENSE = "MIT" +LIC_FILES_CHKSUM = "file://README;beginline=17;endline=18;md5=b320556568bc067d215a1e34c5b34a14" + +inherit autotools +inherit pkgconfig + +SRC_URI = "http://c-ares.haxx.se/download/${BP}.tar.gz" +SRC_URI[md5sum] = "1196067641411a75d3cbebe074fd36d8" +SRC_URI[sha256sum] = "3d701674615d1158e56a59aaede7891f2dde3da0f46a6d3c684e0ae70f52d3db" + +EXTRA_OECONF = "--enable-shared" + +# install private headers to ares subdirectory +do_install_append() { + install -d ${D}/${includedir}/ares + install -m 0644 ares*.h ${D}/${includedir}/ares/ +} + +FILES_${PN}-dev += "${includedir}/ares/*.h"meta/recipes-support/curl/curl_7.33.0.bb +2
-1@@ -5,7 +5,7 @@ SECTION = "console/network" LICENSE = "MIT" LIC_FILES_CHKSUM = "file://COPYING;beginline=7;md5=3a34942f4ae3fbf1a303160714e664ac" -DEPENDS = "zlib gnutls" +DEPENDS = "zlib gnutls c-ares" DEPENDS_class-native = "zlib-native openssl-native" DEPENDS_class-nativesdk = "nativesdk-zlib"@@ -30,6 +30,7 @@ EXTRA_OECONF = "--with-zlib=${STAGING_LIBDIR}/../ \ --enable-crypto-auth \ --disable-ldap \ --disable-ldaps \ + --enable-ares \ ${CURLGNUTLS} \ "
Quoted 3 lines · Saul Wold
Additionally, if adding this to oe-core, it needs to be in it's own patch crediting the orignal author / layer, I found a 1.10 version in the meta-webos-ports, is this where it came from?
There is a c-ares recipe in oe-classic which looks quite similar to this one and I suspect that's probably where it came from (though perhaps indirectly).
But, configuring curl to use c-ares support is not as trivial a change as it might appear and there is a significant chance that it will cause unforeseen (and probably unwanted) effects for at least some people. Adding a PACKAGECONFIG option for it which defaults to off would obviously be fine, and changing the default to be the libcurl internal threaded resolver (which would probably fix the original complaint as well, and doesn't require any extra recipes) might also be fine, but enabling c-ares by default is not something that should be done capriciously.
p.
Quoted 9 lines · Phil Blundell
Quoted 3 lines · Saul Wold
Additionally, if adding this to oe-core, it needs to be in it's own patch crediting the orignal author / layer, I found a 1.10 version in the meta-webos-ports, is this where it came from?
There is a c-ares recipe in oe-classic which looks quite similar to this one and I suspect that's probably where it came from (though perhaps indirectly).
Quoted 10 lines
But, configuring curl to use c-ares support is not as trivial a change as it might appear and there is a significant chance that it will cause unforeseen (and probably unwanted) effects for at least some people. Adding a PACKAGECONFIG option for it which defaults to off would obviously be fine, and changing the default to be the libcurl internal threaded resolver (which would probably fix the original complaint as well, and doesn't require any extra recipes) might also be fine, but enabling c-ares by default is not something that should be done capriciously.
This is why I wanted to understand the orignal failure, so using PACKAGECONFIG sounds reasonable, I think we have had a case in the past where we even allowed for a non-default PACKAGECONFIG point outside of oe-core (I can't remember which one it was now).
Sau!
Quoted 5 lines
p.
Quoted 4 lines · Saul Wold
This is why I wanted to understand the orignal failure, so using PACKAGECONFIG sounds reasonable, I think we have had a case in the past where we even allowed for a non-default PACKAGECONFIG point outside of oe-core (I can't remember which one it was now).
I think having c-ares in oe-core would be a splendid plan, actually. But I don't think that making curl use it by default is a good idea.
p.