Skip to contentSkip to conversation

util-linux: Fix QA warnings about ALTERNATIVES

PATCH Superseded [email protected] 3 participants 4 messages Nov 13, 2013

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 util-linux: Fix QA warnings about ALTERNATIVES

From: Lu Chong <[email protected]>

Previously, EXTRA_OECONF would be overwritten by EXTRA_OECONF_class-native and EXTRA_OECONF_class-nativesdk when we executed make export-sdk' command. As a result, some applications such as last', mesg' and reset' didn't get compiled.

The patch rewrote EXTRA_OECONF_class-native and EXTRA_OECONF_class-nativesdk variables to fix QA warnings.

usr/share/man/man1/last.1.util-linux does not exist usr/share/man/man1/mesg.1.util-linux does not exist usr/bin/last.util-linux does not exist usr/bin/mesg.util-linux does not exist bin/reset does not exist

---
 meta/recipes-core/util-linux/util-linux_2.23.2.bb |   22 +++++++++++++++++++--
 1 file changed, 20 insertions(+), 2 deletions(-)
meta/recipes-core/util-linux/util-linux_2.23.2.bb +20 -2
index b5c221b..b9cdc61 100644
@@ -18,5 +18,23 @@ SRC_URI[md5sum] = "39a02ad0b3b37824c394f40930b7aa38"
 SRC_URI[sha256sum] = "6c5be3f7beec91b4893de14bbd722886fa2521be5bfa0fc079b749d0018633b1"
 
 CACHED_CONFIGUREVARS += "scanf_cv_alloc_modifier=as"
-EXTRA_OECONF_class-native += "--disable-fallocate --disable-use-tty-group"
-EXTRA_OECONF_class-nativesdk += "--disable-fallocate --disable-use-tty-group"
+EXTRA_OECONF_class-native = "--disable-use-tty-group \
+                             --disable-makeinstall-chown --enable-elvtune --enable-init \
+                             --enable-kill --enable-last --enable-mesg --enable-partx \
+                             --enable-raw --enable-rdev --enable-reset --disable-login \
+                             --disable-vipw --disable-newgrp --disable-chfn-chsh \
+                             --enable-write --enable-arch --enable-mount --with-fsprobe=builtin \
+                             --enable-libuuid --enable-libblkid --enable-fsck --without-udev \
+                             usrsbin_execdir='${sbindir}' \
+                             --disable-fallocate --disable-use-tty-group \
+"
+EXTRA_OECONF_class-nativesdk = "--disable-use-tty-group \
+                                --disable-makeinstall-chown --enable-elvtune --enable-init \
+                                --enable-kill --enable-last --enable-mesg --enable-partx \
+                                --enable-raw --enable-rdev --enable-reset --disable-login \
+                                --disable-vipw --disable-newgrp --disable-chfn-chsh \
+                                --enable-write --enable-arch --enable-mount --with-fsprobe=builtin \
+                                --enable-libuuid --enable-libblkid --enable-fsck --without-udev \
+                                usrsbin_execdir='${sbindir}' \
+                                --disable-fallocate --disable-use-tty-group \
+"
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 4 lines · On Wed, 2013-11-13 at 16:11 +0800, [email protected] wrote:

From: Lu Chong <[email protected]>

Previously, EXTRA_OECONF would be overwritten by EXTRA_OECONF_class-native and EXTRA_OECONF_class-nativesdk when we executed `make export-sdk' command.

We don't have an export-sdk command do we?

Quoted 37 lines

As a result, some applications such as last', mesg' and `reset' didn't get compiled.

The patch rewrote EXTRA_OECONF_class-native and EXTRA_OECONF_class-nativesdk variables to fix QA warnings.

usr/share/man/man1/last.1.util-linux does not exist usr/share/man/man1/mesg.1.util-linux does not exist usr/bin/last.util-linux does not exist usr/bin/mesg.util-linux does not exist bin/reset does not exist

---
 meta/recipes-core/util-linux/util-linux_2.23.2.bb |   22 +++++++++++++++++++--
 1 file changed, 20 insertions(+), 2 deletions(-)
meta/recipes-core/util-linux/util-linux_2.23.2.bb +10 -2
index b5c221b..b9cdc61 100644
@@ -18,5 +18,23 @@ SRC_URI[md5sum] = "39a02ad0b3b37824c394f40930b7aa38"
 SRC_URI[sha256sum] = "6c5be3f7beec91b4893de14bbd722886fa2521be5bfa0fc079b749d0018633b1"
 
 CACHED_CONFIGUREVARS += "scanf_cv_alloc_modifier=as"
-EXTRA_OECONF_class-native += "--disable-fallocate --disable-use-tty-group"
-EXTRA_OECONF_class-nativesdk += "--disable-fallocate --disable-use-tty-group"
+EXTRA_OECONF_class-native = "--disable-use-tty-group \
+                             --disable-makeinstall-chown --enable-elvtune --enable-init \
+                             --enable-kill --enable-last --enable-mesg --enable-partx \
+                             --enable-raw --enable-rdev --enable-reset --disable-login \
+                             --disable-vipw --disable-newgrp --disable-chfn-chsh \
+                             --enable-write --enable-arch --enable-mount --with-fsprobe=builtin \
+                             --enable-libuuid --enable-libblkid --enable-fsck --without-udev \
+                             usrsbin_execdir='${sbindir}' \
+                             --disable-fallocate --disable-use-tty-group \
+"

meta/recipes-core/util-linux/util-linux_2.23.2.bb SRC_URI[md5sum] = "39a02ad0b3b37824c394f40930b7aa38" · line 40

Quoted 10 lines
meta/recipes-core/util-linux/util-linux_2.23.2.bb +10 -0
+EXTRA_OECONF_class-nativesdk = "--disable-use-tty-group \
+                                --disable-makeinstall-chown --enable-elvtune --enable-init \
+                                --enable-kill --enable-last --enable-mesg --enable-partx \
+                                --enable-raw --enable-rdev --enable-reset --disable-login \
+                                --disable-vipw --disable-newgrp --disable-chfn-chsh \
+                                --enable-write --enable-arch --enable-mount --with-fsprobe=builtin \
+                                --enable-libuuid --enable-libblkid --enable-fsck --without-udev \
+                                usrsbin_execdir='${sbindir}' \
+                                --disable-fallocate --disable-use-tty-group \
+"

We are not duplicating EXTRA_OECONF like that, its horrible. How about something like:

EXTRA_OECONF = "xxxx ${SOMEVAR}"
SOMEVAR = "z"
SOMEVAR_class-native = "x"
SOMEVAR_class-nativesdk = "y"

? I'm having to guess at what your real problem is though as the commit message doesn't contain the right information.

Cheers,

Richard

#2 lore raw
Quoted 8 lines · Richard Purdie
Quoted 4 lines · On Wed, 2013-11-13 at 16:11 +0800, [email protected] wrote:

From: Lu Chong <[email protected]>

Previously, EXTRA_OECONF would be overwritten by EXTRA_OECONF_class-native and EXTRA_OECONF_class-nativesdk when we executed `make export-sdk' command.

We don't have an export-sdk command do we?

Hi RP,

Sorry, "make export-sdk" is a wrlinux command, which is equivlant to do_populate_sdk, Chong is a new guy, sorry for the confusion:-)

// Robert

Quoted 70 lines
Quoted 37 lines

As a result, some applications such as last', mesg' and `reset' didn't get compiled.

The patch rewrote EXTRA_OECONF_class-native and EXTRA_OECONF_class-nativesdk variables to fix QA warnings.

usr/share/man/man1/last.1.util-linux does not exist usr/share/man/man1/mesg.1.util-linux does not exist usr/bin/last.util-linux does not exist usr/bin/mesg.util-linux does not exist bin/reset does not exist

---
  meta/recipes-core/util-linux/util-linux_2.23.2.bb |   22 +++++++++++++++++++--
  1 file changed, 20 insertions(+), 2 deletions(-)
meta/recipes-core/util-linux/util-linux_2.23.2.bb +10 -2
index b5c221b..b9cdc61 100644
@@ -18,5 +18,23 @@ SRC_URI[md5sum] = "39a02ad0b3b37824c394f40930b7aa38"
  SRC_URI[sha256sum] = "6c5be3f7beec91b4893de14bbd722886fa2521be5bfa0fc079b749d0018633b1"
 
  CACHED_CONFIGUREVARS += "scanf_cv_alloc_modifier=as"
-EXTRA_OECONF_class-native += "--disable-fallocate --disable-use-tty-group"
-EXTRA_OECONF_class-nativesdk += "--disable-fallocate --disable-use-tty-group"
+EXTRA_OECONF_class-native = "--disable-use-tty-group \
+                             --disable-makeinstall-chown --enable-elvtune --enable-init \
+                             --enable-kill --enable-last --enable-mesg --enable-partx \
+                             --enable-raw --enable-rdev --enable-reset --disable-login \
+                             --disable-vipw --disable-newgrp --disable-chfn-chsh \
+                             --enable-write --enable-arch --enable-mount --with-fsprobe=builtin \
+                             --enable-libuuid --enable-libblkid --enable-fsck --without-udev \
+                             usrsbin_execdir='${sbindir}' \
+                             --disable-fallocate --disable-use-tty-group \
+"

meta/recipes-core/util-linux/util-linux_2.23.2.bb SRC_URI[md5sum] = "39a02ad0b3b37824c394f40930b7aa38" · line 40

Quoted 10 lines
meta/recipes-core/util-linux/util-linux_2.23.2.bb +10 -0
+EXTRA_OECONF_class-nativesdk = "--disable-use-tty-group \
+                                --disable-makeinstall-chown --enable-elvtune --enable-init \
+                                --enable-kill --enable-last --enable-mesg --enable-partx \
+                                --enable-raw --enable-rdev --enable-reset --disable-login \
+                                --disable-vipw --disable-newgrp --disable-chfn-chsh \
+                                --enable-write --enable-arch --enable-mount --with-fsprobe=builtin \
+                                --enable-libuuid --enable-libblkid --enable-fsck --without-udev \
+                                usrsbin_execdir='${sbindir}' \
+                                --disable-fallocate --disable-use-tty-group \
+"

We are not duplicating EXTRA_OECONF like that, its horrible. How about something like:

EXTRA_OECONF = "xxxx ${SOMEVAR}"
SOMEVAR = "z"
SOMEVAR_class-native = "x"
SOMEVAR_class-nativesdk = "y"

? I'm having to guess at what your real problem is though as the commit message doesn't contain the right information.

Cheers,

Richard

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

author
#3 lore raw

Hi, Richard

I will resend another commit, please ignore this one. I'm very sorry.

Best Regards
Chong

Quoted 109 lines · Robert Yang
Quoted 8 lines · Richard Purdie
Quoted 4 lines · On Wed, 2013-11-13 at 16:11 +0800, [email protected] wrote:

From: Lu Chong <[email protected]>

Previously, EXTRA_OECONF would be overwritten by EXTRA_OECONF_class-native and EXTRA_OECONF_class-nativesdk when we executed `make export-sdk' command.

We don't have an export-sdk command do we?

Hi RP,

Sorry, "make export-sdk" is a wrlinux command, which is equivlant to do_populate_sdk, Chong is a new guy, sorry for the confusion:-)

// Robert

Quoted 88 lines
Quoted 55 lines

As a result, some applications such as last', mesg' and `reset' didn't get compiled.

The patch rewrote EXTRA_OECONF_class-native and EXTRA_OECONF_class-nativesdk variables to fix QA warnings.

usr/share/man/man1/last.1.util-linux does not exist usr/share/man/man1/mesg.1.util-linux does not exist usr/bin/last.util-linux does not exist usr/bin/mesg.util-linux does not exist bin/reset does not exist

---
  meta/recipes-core/util-linux/util-linux_2.23.2.bb |   22 
+++++++++++++++++++--
  1 file changed, 20 insertions(+), 2 deletions(-)
meta/recipes-core/util-linux/util-linux_2.23.2.bb +0 -0
index b5c221b..b9cdc61 100644
@@ -18,5 +18,23 @@ SRC_URI[md5sum] = "39a02ad0b3b37824c394f40930b7aa38"
  SRC_URI[sha256sum] = 

"6c5be3f7beec91b4893de14bbd722886fa2521be5bfa0fc079b749d0018633b1"

CACHED_CONFIGUREVARS += "scanf_cv_alloc_modifier=as"

meta/recipes-core/util-linux/util-linux_2.23.2.bb +14 -14
-EXTRA_OECONF_class-native += "--disable-fallocate 
--disable-use-tty-group"
-EXTRA_OECONF_class-nativesdk += "--disable-fallocate 
--disable-use-tty-group"
+EXTRA_OECONF_class-native = "--disable-use-tty-group \
+                             --disable-makeinstall-chown 
--enable-elvtune --enable-init \
+                             --enable-kill --enable-last 
--enable-mesg --enable-partx \
+                             --enable-raw --enable-rdev 
--enable-reset --disable-login \
+                             --disable-vipw --disable-newgrp 
--disable-chfn-chsh \
+                             --enable-write --enable-arch 
--enable-mount --with-fsprobe=builtin \
+                             --enable-libuuid --enable-libblkid 
--enable-fsck --without-udev \
+                             usrsbin_execdir='${sbindir}' \
+                             --disable-fallocate 
--disable-use-tty-group \
+"
+EXTRA_OECONF_class-nativesdk = "--disable-use-tty-group \
+                                --disable-makeinstall-chown 
--enable-elvtune --enable-init \
+                                --enable-kill --enable-last 
--enable-mesg --enable-partx \
+                                --enable-raw --enable-rdev 
--enable-reset --disable-login \

meta/recipes-core/util-linux/util-linux_2.23.2.bb

Quoted 10 lines
meta/recipes-core/util-linux/util-linux_2.23.2.bb +6 -4
+                                --disable-vipw --disable-newgrp 
--disable-chfn-chsh \
+                                --enable-write --enable-arch 
--enable-mount --with-fsprobe=builtin \
+                                --enable-libuuid --enable-libblkid 
--enable-fsck --without-udev \
+                                usrsbin_execdir='${sbindir}' \
+                                --disable-fallocate 
--disable-use-tty-group \
+"

We are not duplicating EXTRA_OECONF like that, its horrible. How about something like:

EXTRA_OECONF = "xxxx ${SOMEVAR}"
SOMEVAR = "z"
SOMEVAR_class-native = "x"
SOMEVAR_class-nativesdk = "y"

? I'm having to guess at what your real problem is though as the commit message doesn't contain the right information.

Cheers,

Richard

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core