Skip to contentSkip to conversation

Document that --push-remove is generally more suitable than --push-reset

PATCH In review Gert Doering 4 participants 8 messages Sep 8, 2020 – Sep 9, 2020 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Document that --push-remove is generally more suitable than --push-reset

It's a long-standing and well-known problem that --push-reset removes "critical" options from the push list (like "topology subnet") which will then lead to non-working client configs. This can not be reasonably fixed, because the list of "critical" options depends on overall server config.

So just document the fact, and point people towards --push-remove as a more selective tool.

Trac: #29

---
 doc/man-sections/server-options.rst | 8 ++++++++
 1 file changed, 8 insertions(+)
doc/man-sections/server-options.rst +8 -0
index f1f0667a..2009953c 100644
@@ -530,6 +530,14 @@ fast hardware. SSL/TLS authentication must be used in this mode.
   ``--client-config-dir`` configuration file. This option will ignore
   ``--push`` options at the global config file level.
 
+  *NOTE*: ``--push-reset`` is very thorough: it will remove almost
+  all options from the list of to-be-pushed options.  In many cases,
+  some of these options will need to be re-configured afterwards -
+  specifically, ``--topology subnet`` and ``--route-gateway`` will get
+  lost and this will break client configs in many cases.  Thus, for most
+  purposes, ``--push-remove`` is better suited to selectively remove
+  push options for individual clients.
+
 --server args
   A helper directive designed to simplify the configuration of OpenVPN's
   server mode. This directive will set up an OpenVPN server which will
Signature · 1 line
2.26.2
Acked-by on v1 1/1
#1 lore raw

Am 08.09.20 um 13:15 schrieb Gert Doering:

Quoted 9 lines

It's a long-standing and well-known problem that --push-reset removes "critical" options from the push list (like "topology subnet") which will then lead to non-working client configs. This can not be reasonably fixed, because the list of "critical" options depends on overall server config.

So just document the fact, and point people towards --push-remove as a more selective tool.

Acked-by on v1 1/1
#2 lore raw
In reply to Gert Doering
Quoted 9 lines · Gert Doering

It's a long-standing and well-known problem that --push-reset removes "critical" options from the push list (like "topology subnet") which will then lead to non-working client configs. This can not be reasonably fixed, because the list of "critical" options depends on overall server config.

So just document the fact, and point people towards --push-remove as a more selective tool.

Quoted 6 lines

Trac: #29

---
 doc/man-sections/server-options.rst | 8 ++++++++
 1 file changed, 8 insertions(+)

It would be good if --push-reset would actually not remove certain critical options, but this is anyhow a good heads-up for our users.

Signature · 4 lines
kind regards,

David Sommerseth
OpenVPN Inc
#3 lore raw

Hi,

Quoted 2 lines · David Sommerseth

It would be good if --push-reset would actually not remove certain critical options, but this is anyhow a good heads-up for our users.

Well, that ticket sat there 10 years (!!) waiting for someone to go and implement it... 6 years it sat on your lap, 4 years on mine (or so), so it looks like this is not going to happen any time soon.

gert

Signature · 6 lines
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
                             Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany                             [email protected]...
#4 lore raw

Am 08.09.20 um 18:35 schrieb Gert Doering:

Quoted 9 lines

Hi,

Quoted 2 lines · David Sommerseth

It would be good if --push-reset would actually not remove certain critical options, but this is anyhow a good heads-up for our users.

Well, that ticket sat there 10 years (!!) waiting for someone to go and implement it... 6 years it sat on your lap, 4 years on mine (or so), so it looks like this is not going to happen any time soon.

It also feels like a feature from a different area when pushed options were few and not as essential to OpenVPN. It would remove/deprecate that feature instead of trying to figure out how it should now.

Arne

#5 lore raw

Hi,

My vote would be to deprecate --push-reset
(same for --route-nopull)

André

Sent with ProtonMail Secure Email.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

Quoted 21 lines · Arne Schwabe

Am 08.09.20 um 18:35 schrieb Gert Doering:

Quoted 9 lines

Hi,

Quoted 2 lines · David Sommerseth

It would be good if --push-reset would actually not remove certain critical options, but this is anyhow a good heads-up for our users.

Well, that ticket sat there 10 years (!!) waiting for someone to go and implement it... 6 years it sat on your lap, 4 years on mine (or so), so it looks like this is not going to happen any time soon.

It also feels like a feature from a different area when pushed options were few and not as essential to OpenVPN. It would remove/deprecate that feature instead of trying to figure out how it should now.

Arne

Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

A message that is not in the archive (sent off-list or not yet received): eAWhYvj75Zizi0tQw1j-aAO6OQYYZZhQFc8scdog5dIVs9au2ZcRGqVZN0QkmlmxPwasBDCV7wWROCzi0d5h1A1YKwGHOmOO5hfXL3e823o=@protonmail.com

#7 lore raw

Am 08.09.20 um 19:04 schrieb André:

Quoted 5 lines

Hi,

My vote would be to deprecate --push-reset
(same for --route-nopull)

Route-nopull is still a very useful option that has no good replacement. I regularly use it when the server should not mess up my routing table.

Arne

#8 lore raw
In reply to Gert Doering

Patch has been applied to the master, release/2.5 and release/2.4 branch.

The 2.4 patch is "the same words, just in nroff format, to openvpn.8"

commit 5fd66510dfdef628fa95f156c5f9d80af9ae1531 (master) commit cdeef20bc6ea4c15824427055f2ffeff53651dee (release/2.5) commit d61cbfcde78bf65ec677d164d5d03e00f092befd (release/2.4)

Author: Gert Doering
Date:   Tue Sep 8 13:15:11 2020 +0200
     Document that --push-remove is generally more suitable than --push-reset

     Signed-off-by: Gert Doering <[email protected]...>
     Acked-by: Arne Schwabe <[email protected]...>
     Acked-by: David Sommerseth <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg20899.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering