Skip to contentSkip to conversation

perf trace: Remove thread summary coloring

PATCH Applied Pekka Enberg 4 participants 4 messages Nov 14, 2013 – Nov 30, 2013 perf events

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 perf trace: Remove thread summary coloring

Thread summary line coloring looks ugly. It doesn't add much value so remove coloring completely.

---
 tools/perf/builtin-trace.c | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)
tools/perf/builtin-trace.c +2 -11
index 943087f..b03551e 100644
@@ -2150,7 +2150,6 @@ static int trace__fprintf_one_thread(struct thread *thread, void *priv)
 	size_t printed = data->printed;
 	struct trace *trace = data->trace;
 	struct thread_trace *ttrace = thread->priv;
-	const char *color;
 	double ratio;
 
 	if (ttrace == NULL)
@@ -2158,17 +2157,9 @@ static int trace__fprintf_one_thread(struct thread *thread, void *priv)
 
 	ratio = (double)ttrace->nr_events / trace->nr_events * 100.0;
 
-	color = PERF_COLOR_NORMAL;
-	if (ratio > 50.0)
-		color = PERF_COLOR_RED;
-	else if (ratio > 25.0)
-		color = PERF_COLOR_GREEN;
-	else if (ratio > 5.0)
-		color = PERF_COLOR_YELLOW;
-
-	printed += color_fprintf(fp, color, " %s (%d), ", thread__comm_str(thread), thread->tid);
+	printed += fprintf(fp, " %s (%d), ", thread__comm_str(thread), thread->tid);
 	printed += fprintf(fp, "%lu events, ", ttrace->nr_events);
-	printed += color_fprintf(fp, color, "%.1f%%", ratio);
+	printed += fprintf(fp, "%.1f%%", ratio);
 	printed += fprintf(fp, ", %.3f msec\n", ttrace->runtime_ms);
 	printed += thread__dump_stats(ttrace, trace, fp);
 
Signature · 1 line
1.8.3.1
#2 lore raw

Em Thu, Nov 14, 2013 at 01:31:48PM -0700, David Ahern escreveu:

Quoted 12 lines · Pekka Enberg
Quoted 8 lines

Thread summary line coloring looks ugly. It doesn't add much value so remove coloring completely.

---
 tools/perf/builtin-trace.c | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

Looks good to me.

Applied, and thanks David for bringing this to my attention :-)

- Arnaldo

#3 lore raw
In reply to Pekka Enberg
perf trace: Remove thread summary coloring
Commit-ID:  15e65c693d7de4c83d1e97fd89f87d47f2219782
Gitweb:     http://git.kernel.org/tip/15e65c693d7de4c83d1e97fd89f87d47f2219782
Author:     Pekka Enberg <[email protected]>
AuthorDate: Thu, 14 Nov 2013 18:43:30 +0200
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Wed, 27 Nov 2013 14:58:34 -0300

perf trace: Remove thread summary coloring

Thread summary line coloring looks ugly. It doesn't add much value so remove coloring completely.

---
 tools/perf/builtin-trace.c | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)
tools/perf/builtin-trace.c +2 -11
index 8be17fc..e9f345e2 100644
@@ -2158,7 +2158,6 @@ static int trace__fprintf_one_thread(struct thread *thread, void *priv)
 	size_t printed = data->printed;
 	struct trace *trace = data->trace;
 	struct thread_trace *ttrace = thread->priv;
-	const char *color;
 	double ratio;
 
 	if (ttrace == NULL)
@@ -2166,17 +2165,9 @@ static int trace__fprintf_one_thread(struct thread *thread, void *priv)
 
 	ratio = (double)ttrace->nr_events / trace->nr_events * 100.0;
 
-	color = PERF_COLOR_NORMAL;
-	if (ratio > 50.0)
-		color = PERF_COLOR_RED;
-	else if (ratio > 25.0)
-		color = PERF_COLOR_GREEN;
-	else if (ratio > 5.0)
-		color = PERF_COLOR_YELLOW;
-
-	printed += color_fprintf(fp, color, " %s (%d), ", thread__comm_str(thread), thread->tid);
+	printed += fprintf(fp, " %s (%d), ", thread__comm_str(thread), thread->tid);
 	printed += fprintf(fp, "%lu events, ", ttrace->nr_events);
-	printed += color_fprintf(fp, color, "%.1f%%", ratio);
+	printed += fprintf(fp, "%.1f%%", ratio);
 	printed += fprintf(fp, ", %.3f msec\n", ttrace->runtime_ms);
 	printed += thread__dump_stats(ttrace, trace, fp);