Skip to contentSkip to conversation

drm/i915/ddi: set sink to power down mode on dp disable

PATCH Applied Jani Nikula 3 participants 3 messages Nov 15, 2013 – Nov 21, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/ddi: set sink to power down mode on dp disable

Similar to
commit fdbc3b1f639bb2cbfb32c612b2699e0ba373317d

Author: Jani Nikula <[email protected]>
Date:   Tue Nov 12 17:10:13 2013 +0200

drm/i915/dp: set sink to power down mode on dp disable

but for DDI, where we've never done this.

---

UNTESTED!

---
 drivers/gpu/drm/i915/intel_ddi.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_ddi.c +2 -1
index 1591576..6a63a09 100644
@@ -1158,9 +1158,10 @@ static void intel_ddi_post_disable(struct intel_encoder *intel_encoder)
 	if (wait)
 		intel_wait_ddi_buf_idle(dev_priv, port);
 
-	if (type == INTEL_OUTPUT_EDP) {
+	if (type == INTEL_OUTPUT_DISPLAYPORT || type == INTEL_OUTPUT_EDP) {
 		struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
 		ironlake_edp_panel_vdd_on(intel_dp);
+		intel_dp_sink_dpms(intel_dp, DRM_MODE_DPMS_OFF);
 		ironlake_edp_panel_off(intel_dp);
 	}
 
Signature · 1 line
1.7.9.5
#1 lore raw

2013/11/15 Jani Nikula <[email protected]>:

Quoted 10 lines

Similar to
commit fdbc3b1f639bb2cbfb32c612b2699e0ba373317d

Author: Jani Nikula <[email protected]>
Date:   Tue Nov 12 17:10:13 2013 +0200

drm/i915/dp: set sink to power down mode on dp disable

but for DDI, where we've never done this.

Makes sense, but I wonder if the correct place is this or intel_disable_ddi(), right after the call to ironlake_edp_backlight_off(). The current place is still better than nowhere, so: Reviewed-by: Paulo Zanoni <[email protected]>

Quoted 4 lines

---

UNTESTED!

I'll leave your patch applied on my tree for now. If anything explodes and I survive, I'll tell you :)

Quoted 23 lines
---
 drivers/gpu/drm/i915/intel_ddi.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_ddi.c +2 -2
index 1591576..6a63a09 100644
@@ -1158,9 +1158,10 @@ static void intel_ddi_post_disable(struct intel_encoder *intel_encoder)
        if (wait)
                intel_wait_ddi_buf_idle(dev_priv, port);
 
-       if (type == INTEL_OUTPUT_EDP) {
+       if (type == INTEL_OUTPUT_DISPLAYPORT || type == INTEL_OUTPUT_EDP) {
                struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
                ironlake_edp_panel_vdd_on(intel_dp);
+               intel_dp_sink_dpms(intel_dp, DRM_MODE_DPMS_OFF);
                ironlake_edp_panel_off(intel_dp);
        }
 
--

1.7.9.5

Signature · 1 line
Paulo Zanoni
#2 lore raw
Quoted 18 lines · Paulo Zanoni

2013/11/15 Jani Nikula <[email protected]>:

Quoted 10 lines

Similar to
commit fdbc3b1f639bb2cbfb32c612b2699e0ba373317d

Author: Jani Nikula <[email protected]>
Date:   Tue Nov 12 17:10:13 2013 +0200

drm/i915/dp: set sink to power down mode on dp disable

but for DDI, where we've never done this.

Makes sense, but I wonder if the correct place is this or intel_disable_ddi(), right after the call to ironlake_edp_backlight_off(). The current place is still better than nowhere, so: Reviewed-by: Paulo Zanoni <[email protected]>

Quoted 1 line
Quoted 6 lines
Quoted 3 lines

---

UNTESTED!

I'll leave your patch applied on my tree for now. If anything explodes and I survive, I'll tell you :)

Picked up for -fixes, thanks for the patch.
-Daniel

Quoted 34 lines
Quoted 25 lines

---
 drivers/gpu/drm/i915/intel_ddi.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_ddi.c +2 -2
index 1591576..6a63a09 100644
@@ -1158,9 +1158,10 @@ static void intel_ddi_post_disable(struct intel_encoder *intel_encoder)
        if (wait)
                intel_wait_ddi_buf_idle(dev_priv, port);
 
-       if (type == INTEL_OUTPUT_EDP) {
+       if (type == INTEL_OUTPUT_DISPLAYPORT || type == INTEL_OUTPUT_EDP) {
                struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
                ironlake_edp_panel_vdd_on(intel_dp);
+               intel_dp_sink_dpms(intel_dp, DRM_MODE_DPMS_OFF);
                ironlake_edp_panel_off(intel_dp);
        }
 
--

1.7.9.5

Signature · 5 lines
Paulo Zanoni
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch