Skip to contentSkip to conversation

staging: slicoss: fix possible missing iounmap

PATCH In review Laurent Navet 2 participants 2 messages Nov 15, 2013 – Nov 25, 2013 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: slicoss: fix possible missing iounmap

if slic_card_locate failed, memmapped_ioaddr is not unmapped.

---
 drivers/staging/slicoss/slicoss.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/slicoss/slicoss.c +1 -1
index 652272b..ab7206d 100644
@@ -3708,7 +3708,7 @@ static int slic_entry_probe(struct pci_dev *pcidev,
 	err = slic_card_locate(adapter);
 	if (err) {
 		dev_err(&pcidev->dev, "cannot locate card\n");
-		goto err_out_free_mmio_region;
+		goto err_out_unmap;
 	}
 
 	card = adapter->card;
Signature · 1 line
1.8.4.2
maintainer
#1 lore raw
Quoted 6 lines · Laurent Navet

if slic_card_locate failed, memmapped_ioaddr is not unmapped.

---
 drivers/staging/slicoss/slicoss.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

This patch causes a build warning to be added to the system, implying that you didn't even test-build this patch :(

Sorry, I can't take this as-is for this obvious reason.

Please fix this up and resend.

thanks,

greg k-h