Skip to contentSkip to conversation

expr: log: release prefix

PATCH New Pablo Neira Ayuso 1 participant 1 message Nov 18, 2013 netfilter

lore
Share & tools
lore

Pablo Neira Ayuso

author maintainer
#0 lore raw

PATCH 1/1 expr: log: release prefix

Ana Rey reported a leak in the log expression. Fix it by using the new .free interface added in (3cf788a expr: fix leak in target and match expressions).

---
 src/expr/log.c |    8 ++++++++
 1 file changed, 8 insertions(+)
src/expr/log.c +8 -0
index 1f88246..2d3e0cf 100644
@@ -268,10 +268,18 @@ nft_rule_expr_log_snprintf(char *buf, size_t len, uint32_t type,
 	return -1;
 }
 
+static void nft_rule_expr_log_free(struct nft_rule_expr *e)
+{
+	struct nft_expr_log *log = nft_expr_data(e);
+
+	xfree(log->prefix);
+}
+
 struct expr_ops expr_ops_log = {
 	.name		= "log",
 	.alloc_len	= sizeof(struct nft_expr_log),
 	.max_attr	= NFTA_LOG_MAX,
+	.free		= nft_rule_expr_log_free,
 	.set		= nft_rule_expr_log_set,
 	.get		= nft_rule_expr_log_get,
 	.parse		= nft_rule_expr_log_parse,
Signature · 1 line
1.7.10.4