Skip to contentSkip to conversation

ARM: tegra: Add Tegra124 PWM support

PATCH In review Thierry Reding 2 participants 4 messages Nov 18, 2013 – Dec 14, 2013 2 messages not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 ARM: tegra: Add Tegra124 PWM support

The PWM controller on Tegra124 is the same as the one on earlier SoC generations.

---
 arch/arm/boot/dts/tegra124.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/arm/boot/dts/tegra124.dtsi +8 -0
index dcbf40b742fe..1e5fd14ecfad 100644
@@ -114,6 +114,14 @@
 		status = "disabled";
 	};
 
+	pwm@7000a000 {
+		compatible = "nvidia,tegra124-pwm", "nvidia,tegra20-pwm";
+		reg = <0x7000a000 0x100>;
+		#pwm-cells = <2>;
+		clocks = <&tegra_car TEGRA124_CLK_PWM>;
+		status = "disabled";
+	};
+
 	rtc@7000e000 {
 		compatible = "nvidia,tegra124-rtc", "nvidia,tegra20-rtc";
 		reg = <0x7000e000 0x100>;
Signature · 1 line
1.8.4.2

A message that is not in the archive (sent off-list or not yet received): 1384790435-30269-1-git-send-email-treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org

#2 lore raw

PATCH 2/2 ARM: tegra: Enable PWM on Venice2

Subsequent patches will need to reference a PWM channel for backlight support, so enable the PWM device and assign a label to it.

---
 arch/arm/boot/dts/tegra124-venice2.dts | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/boot/dts/tegra124-venice2.dts +4 -0
index bc502112eb04..302f47704834 100644
@@ -14,6 +14,10 @@
 		status = "okay";
 	};
 
+	pwm: pwm@7000a000 {
+		status = "okay";
+	};
+
 	pmc@7000e400 {
 		nvidia,invert-interrupt;
 		nvidia,suspend-mode = <1>;
Signature · 1 line
1.8.4.2
#3 lore raw
In reply to a message not in the archive
Quoted 2 lines · Thierry Reding

The PWM controller on Tegra124 is the same as the one on earlier SoC generations.

I've applied this series to Tegra's for-3.14/dt branch. Given the recent conversion to the common reset framework and DT bindings, I needed to insert a couple extra lines in this patch:

arch/arm/boot/dts/tegra124.dtsi line 121

Quoted 7 lines
arch/arm/boot/dts/tegra124.dtsi +5 -0
 
+	pwm@7000a000 {
+		compatible = "nvidia,tegra124-pwm", "nvidia,tegra20-pwm";
+		reg = <0x7000a000 0x100>;
+		#pwm-cells = <2>;
+		clocks = <&tegra_car TEGRA124_CLK_PWM>;

Here, I inserted:

+ resets = <&tegra_car 17>;
+ reset-names = "pwm";

... which matches the same node in at least tegra114.dtsi.

Quoted 2 lines
arch/arm/boot/dts/tegra124.dtsi +2 -0
+		status = "disabled";
+	};

A message that is not in the archive (sent off-list or not yet received): [email protected]

#5 lore raw
Quoted 21 lines · Stephen Warren
Quoted 2 lines · Thierry Reding

The PWM controller on Tegra124 is the same as the one on earlier SoC generations.

I've applied this series to Tegra's for-3.14/dt branch. Given the recent conversion to the common reset framework and DT bindings, I needed to insert a couple extra lines in this patch:

arch/arm/boot/dts/tegra124.dtsi line 121

Quoted 7 lines
arch/arm/boot/dts/tegra124.dtsi +5 -0
 
+	pwm@7000a000 {
+		compatible = "nvidia,tegra124-pwm", "nvidia,tegra20-pwm";
+		reg = <0x7000a000 0x100>;
+		#pwm-cells = <2>;
+		clocks = <&tegra_car TEGRA124_CLK_PWM>;

Here, I inserted:

(quoted diff) +2 -0
+               resets = <&tegra_car 17>;
+               reset-names = "pwm";
Quoted 1 line

... which matches the same node in at least tegra114.dtsi.

Looks good. I've also successfully tested this using next-20131213 with working backlight on Venice2.

Thierry