Skip to contentSkip to conversation

ulogd: ulogd_inppkt_NFLOG: close nflog handle after unbinding

PATCH In review Chris Boot 2 participants 2 messages Nov 18, 2013 netfilter

lore
Share & tools
lore

Chris Boot

author
#0 lore raw

PATCH 1/1 ulogd: ulogd_inppkt_NFLOG: close nflog handle after unbinding

The nflog handle is closed, and then nflog_unbind_pf() is called on it, which triggers an assertion failure within libnfnetlink. This patch simply moves the nflog_close() just after the nflog_unbind_pf() calls.

---

The below information is included in the Debian patch file (Debian's DEP-3 patch tagging guidelines):

Author: Chris Boot <[email protected]>

Bug-Debian: http://bugs.debian.org/729055
Bug-Ubuntu: https://bugs.launchpad.net/bugs/1250520
Forwarded: https://bugzilla.netfilter.org/attachment.cgi?id=425
Last-Update: 2013-11-15

Regards,
Chris

input/packet/ulogd_inppkt_NFLOG.c +1 -1
@@ -618,12 +618,12 @@ static int start(struct ulogd_pluginstan
 	return 0;
 
 out_bind:
-	nflog_close(ui->nful_h);
 	if (group_ce(upi->config_kset).u.value == 0) {
 		nflog_unbind_pf(ui->nful_h, AF_INET);
 		nflog_unbind_pf(ui->nful_h, AF_INET6);
 		nflog_unbind_pf(ui->nful_h, AF_BRIDGE);
 	}
+	nflog_close(ui->nful_h);
 out_handle:
 	free(ui->nfulog_buf);
 out_buf:
#1 lore raw

Hello,

Quoted 5 lines · Chris Boot

The nflog handle is closed, and then nflog_unbind_pf() is called on it, which triggers an assertion failure within libnfnetlink. This patch simply moves the nflog_close() just after the nflog_unbind_pf() calls.

Thanks a lot applied.

BR,

Quoted 35 lines

---

The below information is included in the Debian patch file (Debian's DEP-3 patch tagging guidelines):

Author: Chris Boot <[email protected]>

Bug-Debian: http://bugs.debian.org/729055
Bug-Ubuntu: https://bugs.launchpad.net/bugs/1250520
Forwarded: https://bugzilla.netfilter.org/attachment.cgi?id=425
Last-Update: 2013-11-15

Regards,
Chris

input/packet/ulogd_inppkt_NFLOG.c +1 -2
@@ -618,12 +618,12 @@ static int start(struct ulogd_pluginstan
 	return 0;
 
 out_bind:
-	nflog_close(ui->nful_h);
 	if (group_ce(upi->config_kset).u.value == 0) {
 		nflog_unbind_pf(ui->nful_h, AF_INET);
 		nflog_unbind_pf(ui->nful_h, AF_INET6);
 		nflog_unbind_pf(ui->nful_h, AF_BRIDGE);
 	}
+	nflog_close(ui->nful_h);
 out_handle:
 	free(ui->nfulog_buf);
 out_buf:
--

To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 2 lines
Eric Leblond <[email protected]>
Blog: https://home.regit.org/