Skip to contentSkip to conversation

backports: add support for wcn36xx

PATCH Superseded Jason Mobarak 4 participants 9 messages Nov 19, 2013 – Nov 21, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 backports: add support for wcn36xx

---
 backport/defconfigs/wcn36xx |   13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 backport/defconfigs/wcn36xx
backport/defconfigs/wcn36xx new file +13 -0
new file mode 100644
index 0000000..374eb11
@@ -0,0 +1,13 @@
+CPTCFG_CFG80211=m
+CPTCFG_CFG80211_DEFAULT_PS=y
+CPTCFG_CFG80211_DEBUGFS=y
+CPTCFG_MAC80211=m
+# CPTCFG_MAC80211_RC_PID is not set
+# CPTCFG_MAC80211_RC_MINSTREL is not set
+# CPTCFG_MAC80211_RC_DEFAULT_MINSTREL is not set
+CPTCFG_MAC80211_DEBUGFS=y
+CPTCFG_MAC80211_MESSAGE_TRACING=y
+CPTCFG_WLAN=y
+CPTCFG_ATH_CARDS=m
+CPTCFG_WCN36XX=m
+CPTCFG_WCN36XX_DEBUGFS=y
Signature · 1 line
1.7.10.4
#1 lore raw
Quoted 15 lines · Jason Mobarak
---
 backport/defconfigs/wcn36xx |   13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 backport/defconfigs/wcn36xx
backport/defconfigs/wcn36xx new file +3 -0
new file mode 100644
index 0000000..374eb11
@@ -0,0 +1,13 @@
+CPTCFG_CFG80211=m
+CPTCFG_CFG80211_DEFAULT_PS=y
+CPTCFG_CFG80211_DEBUGFS=y

backport/defconfigs/wcn36xx line 13

Quoted 10 lines
backport/defconfigs/wcn36xx new file +10 -0
+CPTCFG_MAC80211=m
+# CPTCFG_MAC80211_RC_PID is not set
+# CPTCFG_MAC80211_RC_MINSTREL is not set
+# CPTCFG_MAC80211_RC_DEFAULT_MINSTREL is not set
+CPTCFG_MAC80211_DEBUGFS=y
+CPTCFG_MAC80211_MESSAGE_TRACING=y
+CPTCFG_WLAN=y
+CPTCFG_ATH_CARDS=m
+CPTCFG_WCN36XX=m
+CPTCFG_WCN36XX_DEBUGFS=y

Could you add CPTCFG_CFG80211_WEXT=y please otherwise we will get bug reports where people are complaining that iwconfig does not work. And please add a Signed-off-by line.

Hauke

#2 lore raw
Quoted 5 lines · Hauke Mehrtens
Quoted 1 line · Jason Mobarak
 backport/defconfigs/wcn36xx |   13 +++++++++++++

Could you add CPTCFG_CFG80211_WEXT=y please otherwise we will get bug reports where people are complaining that iwconfig does not work.

Which device has wcn36xx and includes iwconfig in the build? Android moved to nl80211-based design quite some time ago.. Would someone really look at using wcn36xx in something else than Android and to do that with WEXT? Making iwconfig not work sounds more like a feature than bug in this specific case.

- Jouni

#3 lore raw
Quoted 10 lines · Jouni
Quoted 5 lines · Hauke Mehrtens
Quoted 1 line · Jason Mobarak
 backport/defconfigs/wcn36xx |   13 +++++++++++++

Could you add CPTCFG_CFG80211_WEXT=y please otherwise we will get bug reports where people are complaining that iwconfig does not work.

Quoted 8 lines

Which device has wcn36xx and includes iwconfig in the build? Android moved to nl80211-based design quite some time ago.. Would someone really look at using wcn36xx in something else than Android and to do that with WEXT? Making iwconfig not work sounds more like a feature than bug in this specific case.

- Jouni

Hi Jouni,

I am not familiar with Android. If this driver is mostly used in Android and WEXT isn't used there any more then I am fine with not setting CPTCFG_CFG80211_WEXT, someone building his own wifi driver in Android should also be able to activate such an option.

Hauke

#4 lore raw

PATCH v3 1/1 backports: add defconfig for wcn36xx

---

v2: Added CPTCFG_CFG80211_WEXT and Signed-of-by line.
v3: Alternate version without CPTCFG_CFG80211_WEXT.

 backport/defconfigs/wcn36xx |   13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 backport/defconfigs/wcn36xx
backport/defconfigs/wcn36xx new file +13 -0
new file mode 100644
index 0000000..374eb11
@@ -0,0 +1,13 @@
+CPTCFG_CFG80211=m
+CPTCFG_CFG80211_DEFAULT_PS=y
+CPTCFG_CFG80211_DEBUGFS=y
+CPTCFG_MAC80211=m
+# CPTCFG_MAC80211_RC_PID is not set
+# CPTCFG_MAC80211_RC_MINSTREL is not set
+# CPTCFG_MAC80211_RC_DEFAULT_MINSTREL is not set
+CPTCFG_MAC80211_DEBUGFS=y
+CPTCFG_MAC80211_MESSAGE_TRACING=y
+CPTCFG_WLAN=y
+CPTCFG_ATH_CARDS=m
+CPTCFG_WCN36XX=m
+CPTCFG_WCN36XX_DEBUGFS=y
Signature · 1 line
1.7.10.4
#5 lore raw

Re: [PATCH v3] backports: add defconfig for wcn36xx

Without CPTCFG_CFG80211_WEXT looks better to me.

Quoted 37 lines · Jason Mobarak

---

v2: Added CPTCFG_CFG80211_WEXT and Signed-of-by line.
v3: Alternate version without CPTCFG_CFG80211_WEXT.

 backport/defconfigs/wcn36xx |   13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 backport/defconfigs/wcn36xx
backport/defconfigs/wcn36xx new file +13 -1
new file mode 100644
index 0000000..374eb11
@@ -0,0 +1,13 @@
+CPTCFG_CFG80211=m
+CPTCFG_CFG80211_DEFAULT_PS=y
+CPTCFG_CFG80211_DEBUGFS=y
+CPTCFG_MAC80211=m
+# CPTCFG_MAC80211_RC_PID is not set
+# CPTCFG_MAC80211_RC_MINSTREL is not set
+# CPTCFG_MAC80211_RC_DEFAULT_MINSTREL is not set
+CPTCFG_MAC80211_DEBUGFS=y
+CPTCFG_MAC80211_MESSAGE_TRACING=y
+CPTCFG_WLAN=y
+CPTCFG_ATH_CARDS=m
+CPTCFG_WCN36XX=m
+CPTCFG_WCN36XX_DEBUGFS=y
--

1.7.10.4

_______________________________________________
wcn36xx mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/wcn36xx

Signature · 2 lines
Best regards,
Eugene
#6 lore raw

Re: [PATCH v3] backports: add defconfig for wcn36xx

In reply to Jason Mobarak
Quoted 10 lines · Jason Mobarak

---

v2: Added CPTCFG_CFG80211_WEXT and Signed-of-by line.
v3: Alternate version without CPTCFG_CFG80211_WEXT.

 backport/defconfigs/wcn36xx |   13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 backport/defconfigs/wcn36xx

Thank you for the patch, I applied this version and a new version was pushed out.

You do not have to send pull request over github, I will ignore then, sending a patch to the mailing list is the correct way.

Hauke

#7 lore raw

Re: [PATCH v3] backports: add defconfig for wcn36xx

On Thu, Nov 21, 2013 at 2:43 PM, Hauke Mehrtens <[email protected]> wrote:
[..]

Quoted 5 lines

Thank you for the patch, I applied this version and a new version was pushed out.

You do not have to send pull request over github, I will ignore then, sending a patch to the mailing list is the correct way.

OK, thanks for clarifying!

-Jason M

#8 lore raw

PATCH v2 1/1 backports: add defconfig for wcn36xx

In reply to Hauke Mehrtens

---

v2: Added CPTCFG_CFG80211_WEXT and Signed-of-by line.

 backport/defconfigs/wcn36xx |   14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 backport/defconfigs/wcn36xx
backport/defconfigs/wcn36xx new file +14 -0
new file mode 100644
index 0000000..9430ff1
@@ -0,0 +1,14 @@
+CPTCFG_CFG80211=m
+CPTCFG_CFG80211_DEFAULT_PS=y
+CPTCFG_CFG80211_DEBUGFS=y
+CPTCFG_MAC80211=m
+# CPTCFG_MAC80211_RC_PID is not set
+# CPTCFG_MAC80211_RC_MINSTREL is not set
+# CPTCFG_MAC80211_RC_DEFAULT_MINSTREL is not set
+CPTCFG_MAC80211_DEBUGFS=y
+CPTCFG_MAC80211_MESSAGE_TRACING=y
+CPTCFG_WLAN=y
+CPTCFG_ATH_CARDS=m
+CPTCFG_WCN36XX=m
+CPTCFG_WCN36XX_DEBUGFS=y
+CPTCFG_CFG80211_WEXT=y
Signature · 1 line
1.7.10.4