Skip to contentSkip to conversation

Support for ARM architected timer event stream generation on x86

PATCH Applied Pavel Machek 4 participants 5 messages Nov 20, 2013 – Nov 21, 2013 Clocksource, clockevent drivers

lore
Share & tools
lore
#0 lore raw

Hi!

On x86, I get asked if I want to support arm architectured timer. That's not exactly clever question... right?

I'd say it is from this merge... please fix.
Pavel

commit 191124efb4d6e5e47fe073b4b97350873523e88c
Merge: 68e9074 346e748
Author: Daniel Lezcano <[email protected]>
Date: Thu Oct 3 16:13:51 2013 +0200

Merge branch 'timer_evtstrm' of git://linux-arm.org/linux-skn into clockevents/3.13

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#1 lore raw

PATCH 1/1 drivers: clocksource: Hide arm_arch_timer eventstream Kconfig on non-ARM

Pavel Machek reports that this config is exposed on x86 where the ARM architected timers aren't even present. Make it depend on the ARM architected timers being selected so that non-ARM builds aren't asked about it.

---
 drivers/clocksource/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/clocksource/Kconfig +1 -0
index bdb953e..5c07a56 100644
@@ -87,6 +87,7 @@ config ARM_ARCH_TIMER
 config ARM_ARCH_TIMER_EVTSTREAM
 	bool "Support for ARM architected timer event stream generation"
 	default y if ARM_ARCH_TIMER
+	depends on ARM_ARCH_TIMER
 	help
 	  This option enables support for event stream generation based on
 	  the ARM architected timer. It is used for waking up CPUs executing
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
author Reviewed-by on v1 1/1
#2 lore raw

Re: [PATCH] drivers: clocksource: Hide arm_arch_timer eventstream Kconfig on non-ARM

Quoted 7 lines · Stephen Boyd

Pavel Machek reports that this config is exposed on x86 where the ARM architected timers aren't even present. Make it depend on the ARM architected timers being selected so that non-ARM builds aren't asked about it.

Thanks!
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#3 lore raw

Re: [PATCH] drivers: clocksource: Hide arm_arch_timer eventstream Kconfig on non-ARM

Quoted 6 lines · Pavel Machek
Quoted 5 lines · Stephen Boyd

Pavel Machek reports that this config is exposed on x86 where the ARM architected timers aren't even present. Make it depend on the ARM architected timers being selected so that non-ARM builds aren't asked about it.

Quoted 6 lines
Quoted 2 lines

Thanks!

Applied to my tree as a 3.13 fix.

Thanks Stephen and Pavel !

-- Daniel

Signature · 5 lines
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
#4 lore raw

Re: [PATCH] drivers: clocksource: Hide arm_arch_timer eventstream Kconfig on non-ARM

In reply to Stephen Boyd

At Wed, 20 Nov 2013 12:02:03 -0800,

Quoted 17 lines · Stephen Boyd

Pavel Machek reports that this config is exposed on x86 where the ARM architected timers aren't even present. Make it depend on the ARM architected timers being selected so that non-ARM builds aren't asked about it.

---
 drivers/clocksource/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/clocksource/Kconfig +0 -0
index bdb953e..5c07a56 100644

drivers/clocksource/Kconfig config ARM_ARCH_TIMER · line 90

Quoted 4 lines
drivers/clocksource/Kconfig +1 -0
@@ -87,6 +87,7 @@ config ARM_ARCH_TIMER
 config ARM_ARCH_TIMER_EVTSTREAM
 	bool "Support for ARM architected timer event stream generation"
 	default y if ARM_ARCH_TIMER
+	depends on ARM_ARCH_TIMER

We can drop "if ARM_ARCH_TIMER" in "default y" line now. But do we need "default y" at the first place?

Takashi