Skip to contentSkip to conversation

batman-adv: fix debuginfo macro style issue

PATCH In review Simon Wunderlich 2 participants 2 messages Nov 21, 2013 – Mar 10, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 batman-adv: fix debuginfo macro style issue

From: Simon Wunderlich <[email protected]>

Structure initialization within the macros should follow the general coding style used in the kernel: put the initialization of the first variable and the closing brace on a separate line.

---
 debugfs.c |   19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)
debugfs.c +11 -8
index cd5d24a..92d9d83 100644
@@ -322,14 +322,17 @@ static int batadv_nc_nodes_open(struct inode *inode, struct file *file)
 
 #define BATADV_DEBUGINFO(_name, _mode, _open)		\
 struct batadv_debuginfo batadv_debuginfo_##_name = {	\
-	.attr = { .name = __stringify(_name),		\
-		  .mode = _mode, },			\
-	.fops = { .owner = THIS_MODULE,			\
-		  .open = _open,			\
-		  .read	= seq_read,			\
-		  .llseek = seq_lseek,			\
-		  .release = single_release,		\
-		}					\
+	.attr = {					\
+		.name = __stringify(_name),		\
+		.mode = _mode,				\
+	},						\
+	.fops = {					\
+		.owner = THIS_MODULE,			\
+		.open = _open,				\
+		.read	= seq_read,			\
+		.llseek = seq_lseek,			\
+		.release = single_release,		\
+	},						\
 };
 
 /* the following attributes are general and therefore they will be directly
Signature · 1 line
1.7.10.4
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · On Thursday 21 November 2013 14:17:45 Simon Wunderlich wrote:

From: Simon Wunderlich <[email protected]>

Structure initialization within the macros should follow the general coding style used in the kernel: put the initialization of the first variable and the closing brace on a separate line.

---

It looks like this patch doesn't apply anymore. Can you please resent it or mark it correctly in patchwork [1].

But for the cleanup:

Thanks,
Sven

[1] https://patchwork.open-mesh.org/patch/3668/